fix(node): skip invalid role labels

Author: KKamJi98

kubernetes_monitoring.py

@@ -452,11 +452,16 @@ def _node_roles(node: Any) -> str:
     labels = _normalize_labels_mapping(
         getattr(getattr(node, "metadata", None), "labels", None)
     )
-    roles = [
-        label.split("/")[-1] or "-"
-        for label in labels
-        if isinstance(label, str) and label.startswith("node-role.kubernetes.io/")
-    ]
+    roles: List[str] = []
+    for raw_key in labels.keys():
+        if not isinstance(raw_key, str):
+            continue
+        if not raw_key.startswith("node-role.kubernetes.io/"):
+            continue
+        suffix = raw_key[len("node-role.kubernetes.io/") :].strip()
+        if not suffix:
+            suffix = "-"
+        roles.append(suffix.rstrip("/"))
     if not roles:
         return "<none>"
     return ",".join(sorted(roles))

tests/test_kubernetes_monitoring.py

@@ -216,13 +216,14 @@ def test_node_roles_handles_non_string_label_keys():
         "metadata": {
             "labels": {
                 "node-role.kubernetes.io/control-plane": "",
+                "node-role.kubernetes.io/": "",
                 None: "ignored",
                 10: "other",
             }
         }
     }
     node = kubernetes_monitoring._wrap_kubectl_value(node_payload)
-    assert kubernetes_monitoring._node_roles(node) == "control-plane"
+    assert kubernetes_monitoring._node_roles(node) == "-,control-plane"
 
 
 @patch("kubernetes_monitoring._run_kubectl_json")