Skip to content

Conversation

juliohm
Copy link
Member

@juliohm juliohm commented Aug 6, 2025

@eliascarv I remember we opted to return all columns of the original table to mimic DataFrames.jl's transform behavior. Is there any other reason? A more ergonomic behavior is proposed in this PR that only returns the new (target) columns in the result.

@juliohm juliohm requested a review from eliascarv August 6, 2025 17:36
@eliascarv
Copy link
Member

eliascarv commented Aug 6, 2025

@juliohm There was no other reason. I remember that mimicking the behavior of DataFrames.jl was the only reason.

Therefore, I think we can continue with this change.

@codecov-commenter
Copy link

codecov-commenter commented Aug 6, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 98.33%. Comparing base (52a900d) to head (be406eb).
⚠️ Report is 8 commits behind head on master.

Additional details and impacted files
@@            Coverage Diff             @@
##           master     #302      +/-   ##
==========================================
- Coverage   98.34%   98.33%   -0.02%     
==========================================
  Files          50       50              
  Lines        1450     1440      -10     
==========================================
- Hits         1426     1416      -10     
  Misses         24       24              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@juliohm juliohm merged commit ec9b98b into master Aug 6, 2025
8 checks passed
@juliohm juliohm deleted the map-refactor branch August 6, 2025 18:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants