refactor, add some tests, delete some unnecessary tests

Author: nsajko

test/no_invalidations.jl

@@ -51,9 +51,11 @@ function test_expr(f, supertype::Type)
 end
 
 @testset "no invalidations test set" begin
+    concrete_subtypes_integer = (Bool, Int8, UInt8, Int16, UInt16, Int32, UInt32, Int64, UInt64, Int128, UInt128, BigInt)
+    abstract_subtypes_number = (Signed, Unsigned, Integer, AbstractFloat, AbstractIrrational, Real, Number)
     @testset "2-arg `show` for various new types" begin
-        stypes = (Integer, AbstractString, DenseVector{UInt8}, DenseMatrix{Float32}, AbstractUnitRange{Int})
-        broken = (AbstractString,)
+        stypes = (Any, AbstractString, Function, abstract_subtypes_number...)
+        broken = (AbstractString, Function)
         @testset "S: $S" for S ∈ stypes
             @test test_expr((n -> :(function Base.show(::IO, ::$n) end)), S) broken=(S ∈ broken)
         end
@@ -71,24 +73,23 @@ end
         end
     end
     @testset "new subtype of `Integer`" begin
-        int_types = (Bool, Int8, UInt8, Int16, UInt16, Int32, UInt32, Int64, UInt64, Int128, UInt128, BigInt)
         @testset "construction of old int type from new type" begin
             broken = (UInt16, Int, UInt)
             (Int === Int64) && (broken = (broken..., Int32))
-            @testset "T: $T" for T ∈ int_types
+            @testset "T: $T" for T ∈ concrete_subtypes_integer
                 @test test_expr((n -> :(function Base.$T(::$n) end)), Integer) broken=(T ∈ broken)
             end
         end
         @testset "construction of new int type from old type" begin
             broken = ()
-            @testset "T: $T" for T ∈ int_types
+            @testset "T: $T" for T ∈ concrete_subtypes_integer
                 @test test_expr((n -> :(function $n(::$T) end)), Integer) broken=(T ∈ broken)
             end
         end
         @testset "arithmetic between old int types and new int type" begin
             ops = (:+, :*, :<<, :>>, :>>>)
             broken = ()
-            @testset "T: $T" for T ∈ int_types
+            @testset "T: $T" for T ∈ concrete_subtypes_integer
                 @testset "op: $op" for op ∈ ops
                     @test (
                         test_expr((n -> :(function Base.$op(::$n, ::$T) end)), Integer) &&
@@ -99,7 +100,7 @@ end
         end
         @testset "promotion between old int types and new int type" begin
             broken = (Bool, UInt8, Int)
-            @testset "T: $T" for T ∈ int_types
+            @testset "T: $T" for T ∈ concrete_subtypes_integer
                 @test (
                     test_expr((n -> :(function Base.promote_rule(::Type{$T}, ::Type{$n}) end)), Integer) &&
                     test_expr((n -> :(function Base.promote_rule(::Type{$n}, ::Type{$T}) end)), Integer)