Skip to content

Commit 333406a

Browse files
authored
make compatible to Julia 1.7 Downloads.jl updates (#26)
* make compatible to Julia 1.7 Downloads.jl updates Handle Downloads.jl method rename after JuliaLang/Downloads.jl@5bd0826 Should fix gRPC client hanging in Julia 1.7.3 * test: update ci julia versions * update julia and Downloads.jl required version
1 parent a82ef5e commit 333406a

File tree

3 files changed

+9
-5
lines changed

3 files changed

+9
-5
lines changed

.github/workflows/ci.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@ jobs:
1313
fail-fast: false
1414
matrix:
1515
version:
16-
- '1.3'
16+
- '1.6'
1717
- '1' # automatically expands to the latest stable 1.x release of Julia
1818
os:
1919
- ubuntu-latest

Project.toml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1,18 +1,18 @@
11
name = "gRPCClient"
22
uuid = "aaca4a50-36af-4a1d-b878-4c443f2061ad"
33
authors = ["Tanmay K.M. <[email protected]>"]
4-
version = "0.1.2"
4+
version = "0.1.3"
55

66
[deps]
77
Downloads = "f43a241f-c20a-4ad4-852c-f6b1247861c6"
88
LibCURL = "b27032c2-a3e7-50c8-80cd-2d36dbcbfd21"
99
ProtoBuf = "3349acd9-ac6a-5e09-bcdb-63829b23a429"
1010

1111
[compat]
12-
Downloads = "1.3"
12+
Downloads = "1.4"
1313
LibCURL = "0.6"
1414
ProtoBuf = "0.11"
15-
julia = "1.3"
15+
julia = "1.6"
1616

1717
[extras]
1818
Random = "9a3f8284-a2c9-5f02-9a11-845980a1fd5c"

src/curl.jl

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -188,7 +188,11 @@ function grpc_request(downloader::Downloader, url::String, input::Channel{T1}, o
188188
Curl.set_timeout(easy, request_timeout)
189189
set_connect_timeout(easy, connect_timeout)
190190
Curl.set_verbose(easy, verbose)
191-
Curl.add_upload_callbacks(easy)
191+
if isdefined(Curl, :add_upload_callbacks)
192+
Curl.add_upload_callbacks(easy)
193+
else
194+
Curl.add_upload_callback(easy)
195+
end
192196
Downloads.set_ca_roots(downloader, easy)
193197

194198
# do the request

0 commit comments

Comments
 (0)