Skip to content

Including the ADC frequency offset in the phase compensation #571

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Stockless opened this issue May 30, 2025 · 1 comment
Open

Including the ADC frequency offset in the phase compensation #571

Stockless opened this issue May 30, 2025 · 1 comment
Assignees

Comments

@Stockless
Copy link
Collaborator

ADC frequency offset is not being used in the handling of the ADC phase offset in the get_adc_phase_compensation function.

The proposed ideal solution steps are:

  1. Apply oversampling to the ADC data by calculating additional intermediate
    ADC samples (e.g. oversampling by a factor of 2, that should not be too
    expensive computationally);
  2. apply phase modulation in accordance with the frequency and phase settings
    of the ADC object;
  3. apply pass-band filtering similar to what is done by the hardware;
  4. compensate for the imperfect filter response and discard oversampling.

As a first approach, the recommendation is to implement the step 2 alone, adding a factor exp(-i * 2π * freq_offset * t), where t is the timing of the sample relative to the start of the ADC object.

Thanks to @m-a-x-i-m-z for taking the time to tell us about this error and the previously presented proposed solution.

@cncastillo
Copy link
Member

As a first approach, the recommendation is to implement the step 2 alone, adding a factor exp(-i * 2π * freq_offset * t), where t is the timing of the sample relative to the start of the ADC object.

Let's do this for now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants