Strict typing

[ffreyer]

voronoicells(points, rect) seems to be pretty strict on the type of points. A Point2f0 vector fails with

MethodError: no method matching map_to_computation_rectangle(::Vector{Point{2, Float32}}, ::Rectangle{Point2{Float64}}, ::Rectangle{GeometricalPredicates.Point2D})
Closest candidates are:
  map_to_computation_rectangle(::Vector{T}, ::Rectangle{T}, ::Rectangle) where T at ~/.julia/packages/VoronoiCells/PjjQG/src/Rectangle.jl:90

Stacktrace:
 [1] VoronoiCells.PointCollection(points::Vector{Point{2, Float32}}, rect::Rectangle{Point2{Float64}})
   @ VoronoiCells ~/.julia/packages/VoronoiCells/PjjQG/src/Cells.jl:18
 [2] voronoicells(points::Vector{Point{2, Float32}}, rect::Rectangle{Point2{Float64}})
   @ VoronoiCells ~/.julia/packages/VoronoiCells/PjjQG/src/Cells.jl:98

Same with Point2{Int64}.

I'm also wondering why this package implements its own Rectangle. Is the Rect in GeometryBasics missing functionality?

[robertdj]

Thanks for opening this issue. It fails here because the first two arguments should have the same eltype, but I see your point about not being able to mix Float32/Int64 with Float64. Let me see if I can find a solution. I'll try to squeeze it in this week.

I did indeed implement a Rectangle type because I was missing functionality in GeometryBasics. As I recall, it was because I could not figure out how to access specific sides of a GeometryBasics rectangle.

[robertdj]

I think an easy way is to promote points and rectangle corners to a common eltype, but I'm not sure this is a particularly good approach. I'll have to think more about how to solve this in good way.

[ffreyer]

Basing the output type on the vector element type seems like the right approach to me. I'm also not in a hurry with this. I thought this might be a possible solution for irregular heatmaps in Makie so I checked it out. This does do the trick, but having to convert from Point2f0 to Point2{Float64}, Rectangle and then back to Point2f0 seems awkward.

With respect to Rectangle, maybe there could also be convenience function that accepts and converts GeometryBasics.Rect?

[robertdj]

I think both your points are valid. I would also like to make the boundary window more general cf. another issue, so it makes sense to base it on a GeometryBasics type.

Unfortunately, I cannot provide an estimate of when I can finish this.