Jf/deprecate plotting #27
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR deprecates the old plotting functionality in favor of using the new GridVisualize plotting APIs. Key changes include the introduction of a deprecation warning in plot_triangulateio, removal of the doplot helper in Pluto examples, and updates to dependency and documentation files to reflect the change.
Reviewed Changes
Copilot reviewed 6 out of 6 changed files in this pull request and generated 1 comment.
| File | Description |
|---|---|
| src/plot.jl | Added a global deprecation flag and warning message in the plotting function. |
| examples/pluto-examples.jl | Removed doplot and refactored plotting calls to use the new plot_in_out function. |
| examples/Project.toml | Included GridVisualize in the dependencies. |
| CHANGELOG.md | Updated the changelog to document the deprecation of plotting code. |
Comments suppressed due to low confidence (1)
examples/pluto-examples.jl:229
- The removal of the doplot helper means that the previous figure layout adjustments may no longer be applied. Verify that plot_in_out now handles the figure configuration as intended.
return plot_in_out(
| # plot(Plotter, tio; kwargs...) = plot_triangulateio(Plotter, tio; kwargs...) | ||
|
|
||
|
|
||
| global depwarned::Bool = false |
There was a problem hiding this comment.
Using a global variable to track deprecation warnings might lead to issues in concurrent scenarios or when the module is reloaded. Consider encapsulating this state in a more controlled manner or within a module-level structure.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Address #19