[re-land] Use -Werror (with some exceptions) on Windows builds (#496)

Re-land #484 (as
requested in
#487 (comment))

This will need the treehashes to be signed again.

---------

Co-authored-by: Ian Butterworth <[email protected]>

Author: topolarity

pipelines/main/launch_signed_jobs.yml.signature

@@ -1,2 +1 @@
-Salted__����G4�~�{���C8c�7�}!4U�Y�q��/ 1:�ve�e��v�3���Q
-�R�[)�Vd��!���12�p�����fG�^�ͣ�*
+Salted__>|��k�'����P����/+h����W��{K��+JM�`;{�L�q�+"Y���~{_��Չ���-�77���enؼiOU�%�

pipelines/main/launch_upload_jobs.yml.signature

@@ -1,6 +1,6 @@
-# OS     TRIPLET              ARCH       DOCKER_ARCH   MAKE_FLAGS                                TIMEOUT     DOCKER_TAG
-windows  x86_64-w64-mingw32   x86_64     x86_64        VERBOSE=1                                 .           v7.10
-windows  i686-w64-mingw32     x86_64     i686          VERBOSE=1                                 .           v7.10
+# OS     TRIPLET              ARCH       DOCKER_ARCH   MAKE_FLAGS                                                                                                                                                                                                                                        TIMEOUT     DOCKER_TAG
+windows  x86_64-w64-mingw32   x86_64     x86_64        VERBOSE=1,JL_CFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion",JL_CXXFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion"                                 .           v7.10
+windows  i686-w64-mingw32     x86_64     i686          VERBOSE=1,JL_CFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion",JL_CXXFLAGS="-Werror -Wno-error=array-bounds -Wno-error=array-bounds= -Wno-error=infinite-recursion"                                 .           v7.10
 
 # These special lines allow us to embed default values for the columns above.
 # Any column without a default mapping here will simply substitute a `.` to the empty string

pipelines/main/platforms/build_windows.arches

@@ -1 +1 @@
-Salted__�n�H���~��;gFyi���κ�1��*k��qE���Ѽ��I��/��7��uN߀��Bރ�Z�Dd6�r$57a���]/?�]�
+Salted__��I�e�¡�F_k�m
�A0�wcQu���1Ӏ$���&��]$�hۗ6�v�#�"b�)x�6��%4n����~�6]��u4C�TqZa

pipelines/scheduled/coverage/coverage.yml.signature

@@ -15,7 +15,7 @@ fi
 
 enforce_sanitized() {
     for value in "$@"; do
-        if ! [[ "${value}" =~ ^[a-zA-Z0-9_\.[:space:]=,-]*$ ]]; then
+        if ! [[ "${value}" =~ ^[a-zA-Z0-9_\.\"+[:space:]=,-]*$ ]]; then
             echo "Arches file '${ARCHES_FILE}' contains value '${value}' with non-alphanumeric characters; refusing to parse!" >&2
             exit 1
         fi
@@ -54,7 +54,13 @@ while read -r line; do
     enforce_sanitized "${line}"
 
     # Convert line to array
-    readarray -d ' ' -t line_array <<<"${line}"
+    {
+        set -f
+        # shellcheck disable=SC2207
+        # `read -a` ignores quoted strings when splitting and we are controlling word
+        # splitting via IFS and `set -f` as ShellCheck recommends
+        IFS=$'\n' line_array=( $(xargs -n1 <<<"${line}") )
+    }
 
     # Panic if we don't have the same number of items as our column names:
     if [[ "${#line_array[@]}" != "${#var_names[@]}" ]]; then