Use b.Loop() now that we have Go 1.24

Author: Jacalz

internal/transport/completion_test.go

@@ -6,18 +6,11 @@ import (
 	"github.com/alecthomas/assert/v2"
 )
 
-var completions []string
-
 func BenchmarkNameplateCompletion(b *testing.B) {
 	c := Client{}
-
-	local := []string{}
-
-	for range b.N {
-		local = c.GenerateCodeCompletion("1-letterhead-be")
+	for b.Loop() {
+		c.GenerateCodeCompletion("1-letterhead-be")
 	}
-
-	completions = local
 }
 
 func TestCompletionGeneration_Progressive(t *testing.T) {

internal/ui/tabs_test.go

@@ -5,24 +5,15 @@ import (
 	"testing"
 
 	"fyne.io/fyne/v2/app"
-	"fyne.io/fyne/v2/container"
 )
 
-var globalTabs *container.AppTabs
-
 func BenchmarkCreate(b *testing.B) {
-	b.StopTimer()
 	a := app.NewWithID("io.github.jacalz.rymdport")
 	w := a.NewWindow("Rymdport")
-	var tabs *container.AppTabs
 	os.Args = []string{"rymdport"} // Don't read test arguments as uri input.
-	b.StartTimer()
 
 	b.ReportAllocs()
-	for range b.N {
-		tabs = Create(a, w)
+	for b.Loop() {
+		Create(a, w)
 	}
-
-	// Don't allow the compiler to optimize out.
-	globalTabs = tabs
 }

internal/util/util_test.go

@@ -9,16 +9,11 @@ import (
 	"github.com/alecthomas/assert/v2"
 )
 
-var globalValidationError error
-
 func BenchmarkCodeValidator(b *testing.B) {
-	local := error(nil)
-
-	for range b.N {
-		local = CodeValidator("125-upset-universe-mistake")
+	for b.Loop() {
+		CodeValidator("125-upset-universe-mistake")
 	}
 
-	globalValidationError = local
 }
 
 var codeValidatorTestcases = []struct {