[Peras 9] Peras voting rules prep: parameters, arrival times, and CertDB updates #1784

agustinmista · 2025-11-28T12:11:44Z

This PR introduces some general changes and QoL improvements in anticipation to the introduction of the Peras voting rules. These are separated into hopefully digestible atomic commits:

Introduce Ouroboros.Consensus.Peras.Params module to keep track of Peras protocol parameters in a single place,
Add small helper function onPerasRoundNo,
Tweak HasPerasCertX field projection typeclasses,
Introduce WithArrivalTime combinator to wrap values with a RelativeTime,
Wrap validated Peras certs with their arrival time (and adapt tests), and
Store latest certificate seen in the PerasCertDB and add a getLatestCertSeen method to retrieve it.

Please refer to the corresponding commit messages for more information.

tbagrel1

LGTM!

I think we may change the title of the PR though (and maybe part of its description) to better reflect that most changes are related to adding timestamps on certs and propagate the necessary stuff to make it work.

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Peras/Params.hs

nbacquey

Besides my comments, it seems ok to undraft

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Peras/Params.hs

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Storage/PerasCertDB/API.hs

...consensus/test/consensus-test/Test/Consensus/MiniProtocol/ObjectDiffusion/PerasCert/Smoke.hs

ouroboros-consensus/test/storage-test/Test/Ouroboros/Storage/ChainDB/StateMachine.hs

ouroboros-consensus/test/storage-test/Test/Ouroboros/Storage/PerasCertDB/StateMachine.hs

agustinmista · 2025-12-03T12:55:46Z

...consensus/test/consensus-test/Test/Consensus/MiniProtocol/ObjectDiffusion/PerasCert/Smoke.hs

-      let
-        runOutboundPeer outbound outboundChannel tracer =
-          runPeer
-            ((\x -> "Outbound (Client): " ++ show x) `contramap` tracer)
-            codecObjectDiffusionId
-            outboundChannel
-            (objectDiffusionOutboundPeer outbound)
-            >> pure ()
-        runInboundPeer inbound inboundChannel tracer =
-          runPipelinedPeer
-            ((\x -> "Inbound (Server): " ++ show x) `contramap` tracer)
-            codecObjectDiffusionId
-            inboundChannel
-            (objectDiffusionInboundPeerPipelined inbound)
-            >> pure ()
-        mkPoolInterfaces ::
-          forall m.
-          IOLike m =>
-          m
-            ( ObjectPoolReader PerasRoundNo (PerasCert TestBlock) PerasCertTicketNo m
-            , ObjectPoolWriter PerasRoundNo (PerasCert TestBlock) m
-            , m [PerasCert TestBlock]
-            )
-        mkPoolInterfaces = do
-          outboundPool <- newCertDB perasTestParams certs
-          inboundPool <- newCertDB perasTestParams []
+      forAll arbitrary $ \systemTimeSeed ->
+        let
+          runOutboundPeer outbound outboundChannel tracer =
+            runPeer
+              ((\x -> "Outbound (Client): " ++ show x) `contramap` tracer)
+              codecObjectDiffusionId
+              outboundChannel
+              (objectDiffusionOutboundPeer outbound)
+              >> pure ()
+          runInboundPeer inbound inboundChannel tracer =
+            runPipelinedPeer
+              ((\x -> "Inbound (Server): " ++ show x) `contramap` tracer)
+              codecObjectDiffusionId
+              inboundChannel
+              (objectDiffusionInboundPeerPipelined inbound)
+              >> pure ()
+          mkPoolInterfaces ::
+            forall m.
+            IOLike m =>
+            m
+              ( ObjectPoolReader PerasRoundNo (PerasCert TestBlock) PerasCertTicketNo m
+              , ObjectPoolWriter PerasRoundNo (PerasCert TestBlock) m
+              , m [PerasCert TestBlock]
+              )
+          mkPoolInterfaces = do
+            systemTime <- mockSystemTime systemTimeSeed
+            outboundPool <- newCertDB perasTestParams systemTime certs
+            inboundPool <- newCertDB perasTestParams systemTime []

-          let outboundPoolReader = makePerasCertPoolReaderFromCertDB outboundPool
-              inboundPoolWriter = makePerasCertPoolWriterFromCertDB inboundPool
-              getAllInboundPoolContent = atomically $ do
-                snap <- PerasCertDB.getCertSnapshot inboundPool
-                let rawContent =
-                      Map.toAscList $
-                        PerasCertDB.getCertsAfter snap (PerasCertDB.zeroPerasCertTicketNo)
-                pure $ vpcCert . snd <$> rawContent
+            let outboundPoolReader = makePerasCertPoolReaderFromCertDB outboundPool
+                inboundPoolWriter = makePerasCertPoolWriterFromCertDB systemTime inboundPool
+                getAllInboundPoolContent = atomically $ do
+                  snap <- PerasCertDB.getCertSnapshot inboundPool
+                  let rawContent =
+                        Map.toAscList $
+                          PerasCertDB.getCertsAfter snap (PerasCertDB.zeroPerasCertTicketNo)
+                  pure $ vpcCert . forgetArrivalTime . snd <$> rawContent

-          return (outboundPoolReader, inboundPoolWriter, getAllInboundPoolContent)
-       in
-        prop_smoke_object_diffusion
-          protocolConstants
-          certs
-          runOutboundPeer
-          runInboundPeer
-          mkPoolInterfaces
+            return (outboundPoolReader, inboundPoolWriter, getAllInboundPoolContent)
+         in
+          prop_smoke_object_diffusion
+            protocolConstants
+            certs
+            runOutboundPeer
+            runInboundPeer
+            mkPoolInterfaces


FTR: actual changes here are minimal (masked by new indentation needed by forAll):

Parameterize the property with the seed used to derive a mocked up SystemTime via forAll, and

Instantiate a mocked up SystemTime and pass it around to the places needing it.

This commits introduces the module: Ouroboros.Consensus.Peras.Params To consolidate all the protocol parameters related to Peras in one place. Until we defined concrete BlockSupportsPeras for the different block types + HFC, all blocks satisfy: type PerasCfg blk = PerasParams Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

This commit adds a small helper to compute over Peras round numbers. Will be needed later on to implement the Peras voting rules. Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

This commit simplifies the interface of the HasPerasCertX typeclasses, removing the StandardHash superclass constraint, and splitting them into several smaller typeclasses. Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

This commit defines a generic WithArrivalTime combinator to wrap a value with its arrival time (as a Relative time). This is needed by Peras in several places, e.g., to evaluate the voting rules. Notably, we store a raw Relative time instead of a (arguably more apt) SlotNo or PerasRoundNo to defer as much as possible having to deal with the case where making this translation (timestamp -> slot/round) is not possible due to the HFC time translation horizon. Instead, the client will need to perform this translation in a context where such a failure cannot occur or can be more easily dealt with. Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

This commit wraps the existing ValidatedPerasCerts stored in the PerasCertDB with their corresponding arrival time. In addition, it adapts tests to use either a randomly generated arrival time, or (when appropriate) one generated by a monotonically increasing SystemTime. Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

This commit adds a method to the PerasCertDB API to retrieve the latest certificate seen. This is certificate needed to implement the Peras voting and must be kept around even after garbage collection. Because of this, we extend the internal state of the PerasCertDB to store this special certificate on the side, and (potentially) update it after new certificates are added to the database. Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

agustinmista added the peras label Nov 28, 2025

agustinmista mentioned this pull request Nov 28, 2025

[Peras 10] Add pure voting rules #1785

Draft

3 tasks

agustinmista force-pushed the peras/main-pr/new-defs-and-plumbing branch 6 times, most recently from 14229b9 to 85e4b39 Compare December 1, 2025 11:49

agustinmista requested review from nbacquey and tbagrel1 December 1, 2025 12:37

tbagrel1 approved these changes Dec 1, 2025

View reviewed changes

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Peras/Params.hs Outdated Show resolved Hide resolved

ouroboros-consensus/src/ouroboros-consensus/Ouroboros/Consensus/Peras/Params.hs Outdated Show resolved Hide resolved

nbacquey reviewed Dec 1, 2025

View reviewed changes

agustinmista force-pushed the peras/main-pr/new-defs-and-plumbing branch from 97685c7 to 64748d9 Compare December 2, 2025 15:25

agustinmista self-assigned this Dec 2, 2025

agustinmista force-pushed the peras/main-pr/new-defs-and-plumbing branch 2 times, most recently from 013f36d to 590a1e6 Compare December 3, 2025 08:42

agustinmista changed the title ~~[Peras 9] More type definitions and plumbing~~ [Peras 9] Peras voting rules prep: parameters, arrival times, and CertDB updates Dec 3, 2025

agustinmista force-pushed the peras/main-pr/new-defs-and-plumbing branch from 590a1e6 to 95a3906 Compare December 3, 2025 12:45

agustinmista commented Dec 3, 2025

View reviewed changes

agustinmista force-pushed the peras/main-pr/new-defs-and-plumbing branch from 95a3906 to c0e0683 Compare December 3, 2025 13:10

agustinmista marked this pull request as ready for review December 3, 2025 15:19

agustinmista requested review from amesgen, bladyjoker, dnadales, fraser-iohk, geo2a, jasagredo and nfrisby as code owners December 3, 2025 15:19

agustinmista mentioned this pull request Dec 4, 2025

[Peras 5] Adapt the HFC time translation layer for Peras #1681

Open

agustinmista and others added 6 commits December 4, 2025 15:50

Add changelog entries

2957426

Co-authored-by: Agustin Mista <[email protected]> Co-authored-by: Alexander Esgen <[email protected]> Co-authored-by: Georgy Lukyanov <[email protected]> Co-authored-by: Thomas BAGREL <[email protected]> Co-authored-by: Nicolas BACQUEY <[email protected]>

agustinmista force-pushed the peras/main-pr/new-defs-and-plumbing branch from c0e0683 to 2957426 Compare December 4, 2025 14:50

nbacquey mentioned this pull request Dec 4, 2025

Add Vote and VoteDB for Peras #1768

Draft

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

[Peras 9] Peras voting rules prep: parameters, arrival times, and CertDB updates #1784

[Peras 9] Peras voting rules prep: parameters, arrival times, and CertDB updates #1784

Uh oh!

agustinmista commented Nov 28, 2025 •

edited

Loading

Uh oh!

tbagrel1 left a comment

Uh oh!

Uh oh!

Uh oh!

nbacquey left a comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agustinmista Dec 3, 2025 •

edited

Loading

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

[Peras 9] Peras voting rules prep: parameters, arrival times, and CertDB updates #1784

Are you sure you want to change the base?

[Peras 9] Peras voting rules prep: parameters, arrival times, and CertDB updates #1784

Uh oh!

Conversation

agustinmista commented Nov 28, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

tbagrel1 left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

nbacquey left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

agustinmista Dec 3, 2025 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

agustinmista commented Nov 28, 2025 •

edited

Loading

agustinmista Dec 3, 2025 •

edited

Loading