Skip to content

Commit f2410be

Browse files
committed
[Enhance] rename consumed_tokens to step_* in other_log for consistency
1 parent 7774ecf commit f2410be

4 files changed

Lines changed: 8 additions & 8 deletions

File tree

‎tests/train/test_trainer.py‎

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -57,7 +57,7 @@ def train_step(self, *args, **kwargs):
5757
self.train_step_calls += 1
5858
return (
5959
{"local_loss": 1.0, "reduced_llm_loss": 0.8},
60-
{"consumed_tokens": 100, "grad_norm": torch.tensor(1.0), "efficient_attn_ratio": 0.5}
60+
{"step_consumed_tokens": 100, "grad_norm": torch.tensor(1.0), "efficient_attn_ratio": 0.5}
6161
)
6262

6363
def save_hf(self, hf_path):

‎xtuner/v1/engine/train_engine.py‎

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -53,8 +53,8 @@ class LossLog(TypedDict):
5353
class OtherLog(TypedDict):
5454
__pydantic_config__ = ConfigDict(arbitrary_types_allowed=True) # type: ignore[misc]
5555
maxvio: NotRequired[float]
56-
consumed_tokens: int
57-
consumed_img_tokens: NotRequired[float]
56+
step_consumed_tokens: int
57+
step_consumed_img_tokens: NotRequired[float]
5858
extra_info: ModelForwardExtraLogInfo
5959
efficient_attn_ratio: float
6060

@@ -347,7 +347,7 @@ def train_step(self, data_batches: list[ModelItem]) -> tuple[LossLog, OtherLog]:
347347
reduced_z_loss = step_z_loss
348348
dist.all_reduce(reduced_z_loss.div_(dist.get_world_size()))
349349
loss_log["reduced_z_loss"] = reduced_z_loss.item()
350-
other_log["consumed_tokens"] = cast(int, step_consumed_tokens.item())
350+
other_log["step_consumed_tokens"] = cast(int, step_consumed_tokens.item())
351351
other_log["extra_info"] = train_engine_extra_info
352352
other_log["efficient_attn_ratio"] = (efficient_forward_tokens / total_forward_tokens).item()
353353
return loss_log, other_log

‎xtuner/v1/engine/vision_compose_train_engine.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -220,8 +220,8 @@ def train_step(self, data_batches: List[ModelItem]) -> tuple[LossLog, OtherLog]:
220220
reduced_z_loss = step_z_loss
221221
dist.all_reduce(reduced_z_loss.div_(dist.get_world_size()))
222222
loss_log["reduced_z_loss"] = reduced_z_loss.item()
223-
other_log["consumed_tokens"] = cast(int, step_consumed_tokens.item())
223+
other_log["step_consumed_tokens"] = cast(int, step_consumed_tokens.item())
224224
other_log["extra_info"] = train_engine_extra_info # type: ignore[assignment]
225225
other_log["efficient_attn_ratio"] = (efficient_forward_tokens / total_forward_tokens).item()
226-
other_log["consumed_img_tokens"] = step_consumed_img_tokens
226+
other_log["step_consumed_img_tokens"] = step_consumed_img_tokens
227227
return loss_log, other_log

‎xtuner/v1/train/trainer.py‎

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -760,8 +760,8 @@ def fit(self):
760760
time_after_train_step = time.time()
761761
ProberList.after_step()
762762
step_time = time_after_train_step - time_before_train_step
763-
step_consumed_tokens = other_log["consumed_tokens"]
764-
step_consumed_img_tokens = other_log.get("consumed_img_tokens", None)
763+
step_consumed_tokens = other_log["step_consumed_tokens"]
764+
step_consumed_img_tokens = other_log.get("step_consumed_img_tokens", None)
765765

766766
extra_info = other_log.get("extra_info", {})
767767
if isinstance(extra_info, ModelForwardExtraLogInfo):

0 commit comments

Comments
 (0)