Remove wrong optional typing (#14)

* Remove wrong optional typing

* fix

Author: IlyaGusev

academia_mcp/tools/anthology_search.py

@@ -1,7 +1,9 @@
 import json
 import re
+import os
 from datetime import datetime
 from typing import Optional, List, Dict, Any
+from contextlib import redirect_stdout, redirect_stderr
 
 from acl_anthology import Anthology
 
@@ -12,8 +14,10 @@ class AnthologySingleton:
     @classmethod
     def get(cls) -> Anthology:
         if cls.instance is None:
-            cls.instance = Anthology.from_repo()
-            cls.instance.load_all()
+            with open(os.devnull, "w") as devnull:
+                with redirect_stdout(devnull), redirect_stderr(devnull):
+                    cls.instance = Anthology.from_repo()
+                    cls.instance.load_all()
         return cls.instance
 
 
@@ -93,13 +97,13 @@ def _parse_query(query: str, paper: Any) -> bool:
 
 def anthology_search(
     query: str,
-    offset: Optional[int] = 0,
-    limit: Optional[int] = 5,
+    offset: int = 0,
+    limit: int = 5,
+    sort_by: str = "relevance",
+    sort_order: str = "descending",
+    include_abstracts: bool = False,
     start_date: Optional[str] = None,
     end_date: Optional[str] = None,
-    sort_by: Optional[str] = "relevance",
-    sort_order: Optional[str] = "descending",
-    include_abstracts: Optional[bool] = False,
 ) -> str:
     """
     Search ACL Anthology papers with field-specific queries.
@@ -136,11 +140,11 @@ def anthology_search(
         query: The search query, required.
         offset: The offset in search results. If it is 10, the first 10 items will be skipped. 0 by default.
         limit: The maximum number of items that will be returned. limit=5 by default, limit=10 is the maximum.
-        start_date: Start date in %Y-%m-%d format. None by default.
-        end_date: End date in %Y-%m-%d format. None by default.
         sort_by: 3 options to sort by: relevance, lastUpdatedDate, submittedDate. relevance by default.
         sort_order: 2 sort orders: ascending, descending. descending by default.
         include_abstracts: include abstracts in the result or not. False by default.
+        start_date: Start date in %Y-%m-%d format. None by default.
+        end_date: End date in %Y-%m-%d format. None by default.
     """
     assert isinstance(query, str), "Error: Your search query must be a string"
     assert isinstance(offset, int), "Error: offset should be an integer"

academia_mcp/tools/arxiv_download.py

@@ -272,8 +272,8 @@ def _parse_pdf(paper_id: str) -> Dict[str, Any]:
 
 def arxiv_download(
     paper_id: str,
-    include_references: Optional[bool] = False,
-    mode: Optional[str] = "html",
+    include_references: bool = False,
+    mode: str = "html",
 ) -> DownloadResponse:
     """
     Downloads a paper from Arxiv and converts it to text.

academia_mcp/tools/arxiv_search.py

@@ -142,13 +142,13 @@ def _format_entries(
 
 def arxiv_search(
     query: str,
-    offset: Optional[int] = 0,
-    limit: Optional[int] = 5,
+    offset: int = 0,
+    limit: int = 5,
+    sort_by: str = "relevance",
+    sort_order: str = "descending",
+    include_abstracts: bool = False,
     start_date: Optional[str] = None,
     end_date: Optional[str] = None,
-    sort_by: Optional[str] = "relevance",
-    sort_order: Optional[str] = "descending",
-    include_abstracts: Optional[bool] = False,
 ) -> ArxivSearchResponse:
     """
     Search arXiv papers with field-specific queries.
@@ -178,11 +178,11 @@ def arxiv_search(
         query: The search query, required.
         offset: The offset to scroll search results. 10 items will be skipped if offset=10. 0 by default.
         limit: The maximum number of items to return. limit=5 by default, limit=10 is the maximum.
-        start_date: Start date in %Y-%m-%d format. None by default.
-        end_date: End date in %Y-%m-%d format. None by default.
         sort_by: 3 options to sort by: relevance, lastUpdatedDate, submittedDate. relevance by default.
         sort_order: 2 sort orders: ascending, descending. descending by default.
         include_abstracts: include abstracts in the result or not. False by default.
+        start_date: Start date in %Y-%m-%d format. None by default.
+        end_date: End date in %Y-%m-%d format. None by default.
     """
 
     assert isinstance(query, str), "Error: Your search query must be a string"

academia_mcp/tools/hf_datasets_search.py

@@ -40,9 +40,9 @@ def _format_entries(entries: List[DatasetInfo]) -> str:
 def hf_datasets_search(
     query: Optional[str] = None,
     search_filter: Optional[List[str]] = None,
-    limit: Optional[int] = 5,
-    sort_by: Optional[str] = "trending_score",
-    sort_order: Optional[str] = "descending",
+    limit: int = 5,
+    sort_by: str = "trending_score",
+    sort_order: str = "descending",
 ) -> str:
     """
     Search or filter HF datasets.

academia_mcp/tools/s2.py

@@ -76,8 +76,8 @@ def _format_entries(
 
 def s2_get_citations(
     arxiv_id: str,
-    offset: Optional[int] = 0,
-    limit: Optional[int] = 50,
+    offset: int = 0,
+    limit: int = 50,
 ) -> S2SearchResponse:
     """
     Get all papers that cited a given arXiv paper based on Semantic Scholar info.
@@ -112,8 +112,8 @@ def s2_get_citations(
 
 def s2_get_references(
     arxiv_id: str,
-    offset: Optional[int] = 0,
-    limit: Optional[int] = 50,
+    offset: int = 0,
+    limit: int = 50,
 ) -> S2SearchResponse:
     """
     Get all papers that were cited by a given arXiv paper (references) based on Semantic Scholar info.

academia_mcp/tools/visit_webpage.py

@@ -70,7 +70,7 @@ def _basic_visit_webpage(url: str) -> Dict[str, Any]:
         return {"error": str(e) + "\n" + ERROR_MESSAGE}
 
 
-def visit_webpage(url: str, provider: Optional[str] = "basic") -> VisitWebpageResponse:
+def visit_webpage(url: str, provider: str = "basic") -> VisitWebpageResponse:
     """
     Visit a webpage and return the content.
     Try to use both "tavily" and "basic" providers. They might work differently for the same URL.

academia_mcp/tools/web_search.py

@@ -42,8 +42,8 @@ class WebSearchResponse(BaseModel):  # type: ignore
 
 def web_search(
     query: str,
-    limit: Optional[int] = 20,
-    provider: Optional[str] = "tavily",
+    limit: int = 20,
+    provider: str = "tavily",
     include_domains: Optional[List[str]] = None,
 ) -> WebSearchResponse:
     """
@@ -99,7 +99,7 @@ def web_search(
 
 
 def tavily_web_search(
-    query: str, limit: Optional[int] = 20, include_domains: Optional[List[str]] = None
+    query: str, limit: int = 20, include_domains: Optional[List[str]] = None
 ) -> WebSearchResponse:
     """
     Search the web using Tavily and return results.
@@ -145,7 +145,7 @@ def tavily_web_search(
 
 
 def exa_web_search(
-    query: str, limit: Optional[int] = 20, include_domains: Optional[List[str]] = None
+    query: str, limit: int = 20, include_domains: Optional[List[str]] = None
 ) -> WebSearchResponse:
     """
     Search the web using Exa and return results.
@@ -194,7 +194,7 @@ def exa_web_search(
     return WebSearchResponse(results=entries, search_provider="exa")
 
 
-def brave_web_search(query: str, limit: Optional[int] = 20) -> WebSearchResponse:
+def brave_web_search(query: str, limit: int = 20) -> WebSearchResponse:
     """
     Search the web using Brave and return results.
 

pyproject.toml

@@ -4,7 +4,7 @@ build-backend = "setuptools.build_meta"
 
 [project]
 name = "academia-mcp"
-version = "1.11.8"
+version = "1.11.9"
 description = "MCP server that provides different tools to search for scientific publications"
 readme = "README.md"
 authors = [

tests/test_web_search.py

@@ -4,7 +4,6 @@
 def test_web_search_base() -> None:
     result = web_search("autoregressive models path-star graphs", limit=20)
     assert result.results
-    assert "score" not in str(result)
 
 
 def test_web_search_exa() -> None: