Fix PHP workflows

Author: lippserd

.github/workflows/php.yml

@@ -1,39 +1,35 @@
 # This file defines a reusable GitHub Actions workflow for PHP projects.
 # It runs linting and unit tests across multiple PHP versions, only running tests if a test directory exists.
 
-name: Jobs
-
 on:
   workflow_call:
     inputs:
-      php-version:
+      php-versions:
         required: false
         type: string
         default: '["8.2", "8.3", "8.4"]'
 
-
 jobs:
-
-  phplint:
+  lint:
     name: Lint
     strategy:
       matrix:
-        php: ${{ fromJson(inputs.php-version) }}
-    uses: icinga/github-actions/.github/workflows/phplint.yml@main
+        php: ${{ fromJson(inputs.php-versions) }}
+    uses: ./.github/workflows/phplint.yml
     with:
       php-version: ${{ matrix.php }}
-    secrets: inherit
-
 
   test-exists:
     runs-on: ubuntu-latest
-    name: test-exists
+    name: Check unit tests exist
     outputs:
-      has-tests: ${{ steps.check.outputs.exists }}
-
+      exists: ${{ steps.check.outputs.exists }}
     steps:
       - name: Checkout
         uses: actions/checkout@v4
+        with:
+          fetch-depth: '1'
+
       - name: Check directory
         id: check
         run: |
@@ -45,14 +41,13 @@ jobs:
             echo "exists=false" >> $GITHUB_OUTPUT
           fi
 
-  phpunit:
-    name: Unit Test
+  test:
+    name: Unit tests
     needs: test-exists
-    if: needs.test-exists.outputs.has-tests == 'true'
+    if: needs.test-exists.outputs.exists == 'true'
     strategy:
       matrix:
-        php: ${{ fromJson(inputs.php-version) }}
-    uses: icinga/github-actions/.github/workflows/phpstan.yml
+        php: ${{ fromJson(inputs.php-versions) }}
+    uses: ./.github/workflows/phpunit.yml
     with:
       php-version: ${{ matrix.php }}
-    secrets: inherit

.github/workflows/phplint.yml

@@ -1,5 +1,3 @@
-name: Lint
-
 on:
   workflow_call:
     inputs:
@@ -8,10 +6,9 @@ on:
         required: true
 
 jobs:
-  static-analysis:
-    name: Static analysis for version ${{ inputs.php-version }}
+  lint:
+    name: Lint PHP ${{ inputs.php-version }}
     runs-on: ubuntu-latest
-
     steps:
       - name: Checkout
         uses: actions/checkout@v4

.github/workflows/phpunit.yml

@@ -1,5 +1,3 @@
-name: PHP Unit Tests
-
 on:
   workflow_call:
     inputs:
@@ -8,32 +6,32 @@ on:
         required: true
 
 jobs:
-    test:
-      name: Unit tests with php ${{ inputs.php-version }}
-      runs-on: ubuntu-latest
-
-      steps:
-        - name: Checkout code base
-          uses: actions/checkout@v4
+  test:
+    name: Unit tests PHP ${{ inputs.php-version }}
+    runs-on: ubuntu-latest
+      - name: Checkout
+        uses: actions/checkout@v4
+        with:
+          fetch-depth: '1'
 
-        - name: Setup PHP
-          uses: shivammathur/setup-php@v2
-          with:
-            php-version: ${{ inputs.php-version }}
-            tools: phpunit
+      - name: Set up PHP
+        uses: shivammathur/setup-php@v2
+        with:
+          php-version: ${{ inputs.php-version }}
+          tools: phpunit
 
-        - name: Set up Icinga Web
-          run: |
-            git clone --depth 1 https://github.com/Icinga/icingaweb2.git _icingaweb2
-            ln -s `pwd` _icingaweb2/modules/icingadb
+      - name: Set up Icinga Web
+        run: |
+          git clone --depth 1 https://github.com/Icinga/icingaweb2.git _icingaweb2
+          ln -s `pwd` _icingaweb2/modules/icingadb
 
-        - name: Set up Libraries
-          run: |
-            mkdir _libraries
-            git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-library.git _libraries/ipl
-            git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git _libraries/vendor
+      - name: Set up libraries
+        run: |
+          mkdir _libraries
+          git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-library.git _libraries/ipl
+          git clone --depth 1 -b snapshot/nightly https://github.com/Icinga/icinga-php-thirdparty.git _libraries/vendor
 
-        - name: PHPUnit
-          env:
-            ICINGAWEB_LIBDIR: _libraries
-          run: phpunit --bootstrap _icingaweb2/test/php/bootstrap.php
+      - name: PHPUnit
+        env:
+          ICINGAWEB_LIBDIR: _libraries
+        run: phpunit --bootstrap _icingaweb2/test/php/bootstrap.php