Deletion warning: parent work has a DOI (<%= @presenter.parent.doi %>)
+ <% end %>
<%= link_to "Delete This #{@presenter.human_readable_type}", [main_app, @presenter],
class: 'btn btn-danger', data: { confirm: "Delete this #{@presenter.human_readable_type}?" },
method: :delete %>
diff --git a/config/environments/development.rb b/config/environments/development.rb
index 31f04043..5c5c16d9 100644
--- a/config/environments/development.rb
+++ b/config/environments/development.rb
@@ -62,6 +62,6 @@
# Use a real queuing backend for Active Job (needed for testing resque-scheduler)
# this will force the jobs to be asynchronous (and does not work in dev due to a bug)
- # config.active_job.queue_adapter = :resque
+ config.active_job.queue_adapter = :inline
end
diff --git a/config/initializers/ezid.rb b/config/initializers/ezid.rb
deleted file mode 100644
index dbc71fea..00000000
--- a/config/initializers/ezid.rb
+++ /dev/null
@@ -1,10 +0,0 @@
-# frozen_string_literal: true
-
-Ezid::Client.configure do |config|
- config.host = Settings.ezid.host
- config.port = Settings.ezid.port
- config.user = Settings.ezid.user
- config.password = Settings.ezid.password
- config.timeout = Settings.ezid.timeout
- config.default_shoulder = Settings.ezid.shoulder
-end
diff --git a/config/locales/data_set.en.yml b/config/locales/data_set.en.yml
index 9c872081..ccdfffce 100644
--- a/config/locales/data_set.en.yml
+++ b/config/locales/data_set.en.yml
@@ -4,10 +4,14 @@ en:
"A DOI already exists for this work."
doi_is_being_minted:
"A DOI is currently being minted."
- doi_job_started:
- "DOI process kicked off for work id: %{id}"
+ doi_minting_disabled:
+ "DOI minting is disabled."
+ doi_minting_error:
+ "An error occurred requesting DOI minting."
doi_minting_started:
"DOI minting has started."
+ doi_requires_valid_work:
+ "DOI cannot be minted for a work with incomplete metadata."
doi_requires_work_with_files:
"DOI cannot be minted for a work without files."
doi_user_without_access:
diff --git a/config/locales/deepblue.en.yml b/config/locales/deepblue.en.yml
index 0628b700..1f2f63b3 100644
--- a/config/locales/deepblue.en.yml
+++ b/config/locales/deepblue.en.yml
@@ -48,12 +48,6 @@ en:
deepblue: "deepblue@umich.edu"
generic_work:
- doi_already_exists:
- "A DOI already exists or is being minted."
- doi_job_started:
- "DOI process kicked off for work id: %{id}"
- doi_requires_work_with_files:
- "DOI cannot be minted for a work without files."
globus_clean:
"Files are being delete from %{dirs}"
globus_clean_join_html:
diff --git a/config/routes.rb b/config/routes.rb
index 8b14d8ef..6694cfa1 100644
--- a/config/routes.rb
+++ b/config/routes.rb
@@ -93,7 +93,6 @@
member do
# post 'confirm'
get 'display_provenance_log'
- get 'doi'
post 'doi'
post 'globus_download'
post 'globus_add_email'
diff --git a/config/settings.yml b/config/settings.yml
index 9c898167..74a7f40c 100644
--- a/config/settings.yml
+++ b/config/settings.yml
@@ -63,16 +63,13 @@ redis:
port: 6379
thread_safe: true
-# EZID Client configuration; see initializer/ezid.rb
-# The doi:10.5072/FK2 shoulder is a defined temporary/testing namespace.
+# Datacite client configuration
# Set real values in settings.local.yml or local environment file.
-ezid:
- host: ez.test.datacite.org
- user: eziduser.invalid
- password: ezidpassword.invalid
- shoulder: doi:10.5072/FK2
- port: 443
- timeout: 300
+datacite:
+ host: api.test.datacite.org
+ username: datacite.test.user
+ password: datacite.test.password
+ prefix: '10.5072' # force string interpretation
jira:
username: jirausername.invalid
diff --git a/config/settings/production.yml b/config/settings/production.yml
index d05a7ef7..d9c410c6 100644
--- a/config/settings/production.yml
+++ b/config/settings/production.yml
@@ -19,11 +19,13 @@ solr:
redis:
url: redis://redis/
-# The shoulder is made invalid here to avoid unintentionally creating
-# identifiers in a test namespace and appearing to work if left unconfigured.
+# Datacite client configuration
+# Set real values in settings.production.local.yml or local environment file.
ezid:
- host: ez.datacite.org
- shoulder: invalid:invalid
+ host: api.datacite.org
+ username: datacite.production.user
+ password: datacite.production.password
+ prefix: invalid
jira:
username: jirausername.invalid
diff --git a/config/settings/test.yml b/config/settings/test.yml
index 9206cd4e..afccdacb 100644
--- a/config/settings/test.yml
+++ b/config/settings/test.yml
@@ -1,4 +1,4 @@
-hostname: 'test.datacaore.iu.edu'
+hostname: 'test.datacore.iu.edu'
hyrax:
redis_namespace: 'datacore-test'
@@ -30,3 +30,6 @@ rails:
database: db/test.sqlite3
timeout: 10000
secret_key_base: a8e4aa45a4953ee0263a0df4a33bd051b4db4503d96f93db838730ff93ed413d62dbb6f2feb82ec902d135799e7faf44b815726dc491f5cc3131db394fd2259d
+
+rspec:
+ aggressive_cleaning: false # set to true for local development as needed
diff --git a/spec/controllers/hyrax/data_sets_controller_spec.rb b/spec/controllers/hyrax/data_sets_controller_spec.rb
index 5dbeb728..f24bad85 100644
--- a/spec/controllers/hyrax/data_sets_controller_spec.rb
+++ b/spec/controllers/hyrax/data_sets_controller_spec.rb
@@ -1,38 +1,100 @@
require 'rails_helper'
-RSpec.describe Hyrax::DataSetsController do # rubocop:disable RSpec/EmptyExampleGroup
-
- # before(:all ) do
- # puts "DataSet ids before=#{DataSet.all.map { |ds| ds.id }}"
- # #puts "FileSet ids before=#{FileSet.all.map { |fs| fs.id }}"
- # end
- #
- # after(:all ) do
- # #puts "FileSet ids after=#{FileSet.all.map { |fs| fs.id }}"
- # puts "DataSet ids after=#{DataSet.all.map { |ds| ds.id }}"
- # # clean up created DataSet
- # DataSet.all.each { |ds| ds.delete }
- # #FileSet.all.each { |fs| fs.delete }
- # end
-
- include Devise::Test::ControllerHelpers
- routes { Rails.application.routes }
+RSpec.describe Hyrax::DataSetsController do
+ render_views
let(:main_app) { Rails.application.routes.url_helpers }
let(:hyrax) { Hyrax::Engine.routes.url_helpers }
- let(:user) { create(:user) }
+ let(:user) { FactoryBot.create(:admin) } # FIXME: enable access for depositor?
+ let(:pending_doi) { Deepblue::DoiBehavior::DOI_PENDING }
+ let(:minted_doi) { 'doi:10.82028/18sn-h641' }
+ let(:data_set) { FactoryBot.create(:data_set, user: user, doi: nil) }
+ let(:data_set_with_one_file) { FactoryBot.create(:data_set_with_one_file, user: user, doi: nil) }
before do
sign_in user
end
- context 'someone elses private work' do # rubocop:disable RSpec/EmptyExampleGroup
- # let(:work) { create(:private_data_set) }
- #
- # it 'shows unauthorized message' do
- # get :show, params: { id: work }
- # expect(response.code).to eq '401'
- # expect(response).to render_template(:unauthorized)
- # end
+ describe "#show" do
+ it "renders show page" do
+ get :show, params: { id: data_set.id }
+ expect(response).to render_template(:show)
+ end
end
+ shared_examples "doi_mint! behavior" do |flash_type, flash_match|
+ it "redirects to the work" do
+ expect(response).to redirect_to(main_app.hyrax_data_set_path(data_set, locale: :en))
+ end
+ it "flashes :#{flash_type} message matching #{flash_match}" do
+ expect(flash[flash_type]).to be_a String
+ expect(flash[flash_type]).to match flash_match
+ end
+ end
+
+ describe "#doi" do
+ before(:each) do
+ allow(Datacore::DoiMintingService).to receive(:enabled?).and_return(true)
+ end
+ context "when minting is disabled" do
+ before(:each) do
+ allow(Datacore::DoiMintingService).to receive(:enabled?).and_return(false)
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :alert, /disabled/
+ end
+ context "when minting is in progress" do
+ before(:each) do
+ data_set.doi = pending_doi; data_set.save!
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :notice, /currently/
+ end
+ context "when minting is already done" do
+ before(:each) do
+ data_set.doi = minted_doi; data_set.save!
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :alert, /already/
+ end
+ context "when missing files" do
+ before(:each) do
+ expect(data_set.file_sets.count).to eq 0
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :alert, /files/
+ end
+ context "when invalid metadata" do
+ let(:data_set) { data_set_with_one_file }
+ before(:each) do
+ data_set.title = nil; data_set.save(validate: false)
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :alert, /metadata/
+ end
+ context "when user lacks rights", skip: 'authorization check prevents condition from arising' do
+ let(:data_set) { data_set_with_one_file }
+ before(:each) do
+ allow_any_instance_of(Ability).to receive(:admin?).and_return(false)
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :alert, /access/
+ end
+ context "when user has rights" do
+ let(:data_set) { data_set_with_one_file }
+ context "and minting succeeds" do
+ before(:each) do
+ allow_any_instance_of(data_set.class).to receive(:doi_mint).and_return(true)
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :notice, /started/
+ end
+ context "and minting fails" do
+ before(:each) do
+ allow_any_instance_of(data_set.class).to receive(:doi_mint).and_return(false)
+ post :doi, params: { id: data_set.id }
+ end
+ include_examples "doi_mint! behavior", :error, /error/
+ end
+ end
+ end
end
diff --git a/spec/controllers/hyrax/deepblue_controller_spec.rb b/spec/controllers/hyrax/deepblue_controller_spec.rb
index 962eee25..91daeeb3 100644
--- a/spec/controllers/hyrax/deepblue_controller_spec.rb
+++ b/spec/controllers/hyrax/deepblue_controller_spec.rb
@@ -15,8 +15,8 @@
end
describe "#doi_minting_enabled?" do
- it "returns false" do
- expect(subject.doi_minting_enabled?).to eq false
+ it "returns service value (#{Datacore::DoiMintingService.enabled?}" do
+ expect(subject.doi_minting_enabled?).to eq Datacore::DoiMintingService.enabled?
end
end
diff --git a/spec/factories/data_sets.rb b/spec/factories/data_sets.rb
index 609dce85..ce1a3ada 100644
--- a/spec/factories/data_sets.rb
+++ b/spec/factories/data_sets.rb
@@ -2,6 +2,14 @@
FactoryBot.define do
factory :data_set, aliases: [:data_set_work], class: ::DataSet do
+ title { ["Test title"] }
+ visibility { Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE }
+ authoremail { "test@iu.edu" }
+ description { ["This is the description."] }
+ methodology { "The Methodology" }
+ creator { ['creator1'] }
+ rights_license { "http://creativecommons.org/publicdomain/zero/1.0/" }
+ rights_statement { ["http://rightsstatements.org/vocab/NKC/1.0/"] }
transient do
user { create(:user) }
@@ -25,13 +33,6 @@
work.save! if work.member_of_collections.present?
end
- title { ["Test title"] }
- visibility { Hydra::AccessControls::AccessRight::VISIBILITY_TEXT_VALUE_PRIVATE }
-
- authoremail { "test@umich.edu" }
- description { ["This is the description."] }
- methodology { "The Methodology" }
-
after(:build) do |work, evaluator|
work.apply_depositor_metadata(evaluator.user.user_key)
end
diff --git a/spec/jobs/doi_minting_job_spec.rb b/spec/jobs/doi_minting_job_spec.rb
new file mode 100644
index 00000000..ca64c313
--- /dev/null
+++ b/spec/jobs/doi_minting_job_spec.rb
@@ -0,0 +1,44 @@
+# frozen_string_literal: true
+
+describe DoiMintingJob do
+ let(:current_user) { 'user@example.com' }
+ let(:service) { Datacore::DoiMintingService.new(current_user: current_user, work: work) }
+ let(:work) { FactoryBot.create(:data_set, creator: ['creator'], rights_license: 'rights_license', doi: doi) }
+ let(:doi) { 'doi:10.82028/18sn-h641' }
+ let(:pending_doi) { Deepblue::DoiBehavior::DOI_PENDING }
+ let(:job_run) { DoiMintingJob.perform_now(work.id, current_user: current_user) }
+
+ before do
+ allow(Datacore::DoiMintingService).to receive(:mint_doi_for).and_return('return_value')
+ end
+
+ describe "#perform_now", :clean do
+ context "when work is invalid" do
+ before do
+ work.title = nil
+ work.save(validate: false)
+ expect(work).to be_invalid
+ end
+ it "returns nil" do
+ expect(job_run).to be_nil
+ end
+ end
+ context "when doi blank" do
+ let(:doi) { nil }
+ it "returns nil" do
+ expect(job_run).to be_nil
+ end
+ end
+ context "when doi minted" do
+ it "returns nil" do
+ expect(job_run).to be_nil
+ end
+ end
+ context "when doi pending" do
+ let(:doi) { pending_doi }
+ it "returns true" do
+ expect(job_run).to eq true
+ end
+ end
+ end
+end
diff --git a/spec/models/data_set_spec.rb b/spec/models/data_set_spec.rb
index 11d3b6e6..af343836 100644
--- a/spec/models/data_set_spec.rb
+++ b/spec/models/data_set_spec.rb
@@ -3,7 +3,6 @@
require 'rails_helper'
RSpec.describe DataSet do
-
let( :authoremail ) { 'authoremail@umich.edu' }
let( :creator ) { 'Creator, A' }
let( :current_user ) { 'user@umich.edu' }
@@ -662,4 +661,5 @@ def validate_prov_logger_received( prov_logger_received:,
expect( rv_key_values.size ).to eq size
end
+ include_examples "DeepBlue::DoiBehavior", :data_set
end
diff --git a/spec/rails_helper.rb b/spec/rails_helper.rb
index df9e85f0..c30443a1 100644
--- a/spec/rails_helper.rb
+++ b/spec/rails_helper.rb
@@ -5,6 +5,7 @@
# Prevent database truncation if the environment is production
abort("The Rails environment is running in production mode!") if Rails.env.production?
require 'rspec/rails'
+require 'active_fedora/cleaner'
# Add additional requires below this line. Rails is not loaded until this point!
# Requires supporting ruby files with custom matchers and macros, etc, in
@@ -79,4 +80,7 @@
DatabaseCleaner.clean
end
+ config.after(:each) do
+ ActiveFedora::Cleaner.clean! if Settings.rspec.aggressive_cleaning
+ end
end
diff --git a/spec/services/datacore/doi_minting_service_spec.rb b/spec/services/datacore/doi_minting_service_spec.rb
new file mode 100644
index 00000000..df147a0b
--- /dev/null
+++ b/spec/services/datacore/doi_minting_service_spec.rb
@@ -0,0 +1,108 @@
+# frozen_string_literal: true
+
+require 'rails_helper'
+
+describe Datacore::DoiMintingService do
+ let(:current_user) { 'user@example.com' }
+ # define doi per context
+ let(:work) { FactoryBot.create(:data_set, doi: doi) }
+ let(:service) { Datacore::DoiMintingService.new(current_user: current_user, work: work) }
+ let(:namespaced_doi) { 'doi:10.82028/18sn-h641' }
+ let(:url_doi) { 'https://doi.org/10.82028/18sn-h641' }
+ let(:raw_doi) { '10.82028/18sn-h641' }
+ let(:pending_doi) { Deepblue::DoiBehavior::DOI_PENDING }
+ before do
+ allow(Datacore::DoiMintingService).to receive(:enabled?).and_return(true)
+ allow(service).to receive(:mint_doi!).and_raise(StandardError) # prevent client interactions
+ end
+
+ describe "#id" do
+ context "with a nil DOI" do
+ let(:doi) { nil }
+ it "returns a blank string" do
+ expect(service.id).to eq ''
+ end
+ end
+ context "with a namespaced DOI" do
+ let(:doi) { namespaced_doi }
+ it "returns the raw DOI value" do
+ expect(service.id).to eq raw_doi
+ end
+ end
+ context "with a URL DOI" do
+ let(:doi) { url_doi }
+ it "returns the raw DOI value" do
+ expect(service.id).to eq raw_doi
+ end
+ end
+ context "with a raw DOI" do
+ let(:doi) { raw_doi }
+ it "returns the same value" do
+ expect(service.id).to eq doi
+ end
+ end
+ end
+
+ describe "#run" do
+ context "on a work with a minted DOI" do
+ let(:doi) { namespaced_doi }
+ it "returns false" do
+ expect(service).not_to receive(:mint_doi!)
+ expect(service).not_to receive(:update_work_with_doi!)
+ expect(service.run).to eq false
+ end
+ end
+ context "on a work with a nil DOI" do
+ let(:doi) { nil }
+ it "returns false" do
+ expect(service).not_to receive(:mint_doi!)
+ expect(service).not_to receive(:update_work_with_doi!)
+ expect(service.run).to eq false
+ end
+ end
+ context "on a work with a pending DOI" do
+ let(:doi) { pending_doi }
+ context "but invalid metadata" do
+ before do
+ work.creator = []
+ work.save(validate: false)
+ allow(service).to receive(:mint_doi!).and_return(nil) # prevent client interactions
+ end
+ it "returns false" do
+ expect(service).not_to receive(:mint_doi!)
+ expect(service).not_to receive(:update_work_with_doi!)
+ expect(service.run).to eq false
+ end
+ end
+ context "with successful minting" do
+ before do
+ allow(service).to receive(:mint_doi!).and_return(namespaced_doi) # stub client interaction
+ end
+ it "successfully calls mint_doi!" do
+ expect(service).to receive(:mint_doi!)
+ expect(service.run).to eq namespaced_doi
+ end
+ it "updates the work doi value" do
+ expect(work.doi).to eq Deepblue::DoiBehavior::DOI_PENDING
+ service.run
+ expect(work.doi).to eq namespaced_doi
+ end
+ end
+ context "with failed minting" do
+ before do
+ allow(service).to receive(:mint_doi!).and_return(nil) # stub client interaction
+ end
+ it "returns nil!" do
+ expect(service).to receive(:mint_doi!)
+ expect(service).to receive(:update_work_with_doi!)
+ expect(service.run).to be_nil
+ end
+ it "resets the work doi value to nil" do
+ expect(work.doi).to eq pending_doi
+ service.run
+ expect(work.doi).to be_nil
+ end
+ end
+ end
+ end
+end
diff --git a/spec/services/deepblue/doi_minting_service_spec.rb b/spec/services/deepblue/doi_minting_service_spec.rb
deleted file mode 100644
index 1e44b643..00000000
--- a/spec/services/deepblue/doi_minting_service_spec.rb
+++ /dev/null
@@ -1,71 +0,0 @@
-# frozen_string_literal: true
-
-require 'rails_helper'
-
-describe Deepblue::DoiMintingService do
-
- context "when minting a new doi" do
- subject { described_class.new( work: work, current_user: "test_doi_minting_service@umich.edu" ) }
- let(:work) { mock_model(GenericWork, id: '123', title: ['demotitle'],
- creator: ['Smith, John', 'Smith, Jane', 'O\'Rielly, Kelly'])}
- let(:work_url) { "umrdr-testing.hydra.lib.umich.edu/concern/work/#{work.id}" }
- let(:dummy_doi) { "doi:10.5072/FK2DEAD455BEEF" }
- let(:identifier) { instance_double(Ezid::Identifier, id: dummy_doi) }
-
- before do
- allow(Rails).to receive_message_chain("application.routes.url_helpers.hyrax_data_set_url").and_return(work_url)
- allow(work).to receive(:save)
- allow(work).to receive(:reload)
- allow(work).to receive(:doi).and_return(identifier.id)
- allow(work).to receive(:doi=)
- allow(work).to receive(:provenance_mint_doi)
- allow(subject).to receive(:doi_server_reachable?).and_return(true)
- allow(Ezid::Identifier).to receive(:mint).and_return(identifier)
- end
-
- it "has expected metadata" do
- expect(subject.metadata.datacite_title).to eq(work.title.first)
- expect(subject.metadata.datacite_publisher).to eq(described_class::PUBLISHER)
- expect(subject.metadata.datacite_publicationyear).to eq(Date.today.year.to_s)
- expect(subject.metadata.datacite_resourcetype).to eq(described_class::RESOURCE_TYPE)
- expect(subject.metadata.datacite_creator).to eq(work.creator.join(';'))
- expect(subject.metadata.target).not_to be_empty
- end
-
- it "calls out to EZID to mint a doi" do
- expect(Ezid::Identifier).to receive(:mint)
- subject.run
- end
-
- it "returns the id value of the identifier" do
- expect(subject.run).to eq(identifier.id)
- end
-
- it "assigns the doi value and saves the work" do
- expect(work).to receive(:doi=).with(identifier.id)
- expect(work).to receive(:save)
- subject.run
- end
-
- context "EZID service is unreachable" do
- before do
- allow(subject).to receive(:doi_server_reachable?).and_return(false)
- end
- it "does not attempt to mint a doi" do
- expect(subject).not_to receive(:mint_doi)
- expect(subject.run).to eq "doi:10.5072/FK2DEAD455BEEF"
- end
- end
- end
-
- context "when actually calling out to service" do
- let(:work) { GenericWork.new(id: '123', title: ['demotitle'],
- creator: ['Smith, John', 'Smith, Jane', 'O\'Rielly, Kelly'])}
- let( :current_user ) { "test_doi_minting_service@umich.edu" }
- it "mints a doi" do
- skip unless ENV['INTEGRATION']
- expect(described_class.mint_doi_for( work: work, current_user: current_user ) ).to start_with 'doi:10.5072/FK2'
- end
- end
-
-end
diff --git a/spec/support/shared_examples/doi_behavior.rb b/spec/support/shared_examples/doi_behavior.rb
new file mode 100644
index 00000000..f89b08bc
--- /dev/null
+++ b/spec/support/shared_examples/doi_behavior.rb
@@ -0,0 +1,145 @@
+RSpec.shared_examples "DeepBlue::DoiBehavior" do |object_factory|
+ let(:minted_doi) { 'doi:10.82028/18sn-h641' }
+ let(:pending_doi) { Deepblue::DoiBehavior::DOI_PENDING }
+ let(:minted_work) { FactoryBot.create(object_factory, doi: minted_doi) }
+ let(:pending_work) { FactoryBot.create(object_factory, doi: pending_doi) }
+ let(:unminted_work) { FactoryBot.create(object_factory, doi: nil) }
+ let(:file_set) { FactoryBot.create(:file_set) }
+
+ describe "#doi_minted?" do
+ let(:work) { unminted_work }
+ context "with a nil doi" do
+ it "returns false" do
+ expect(work.doi).to be_nil
+ expect(work.doi_minted?).to eq false
+ end
+ end
+ context "with a pending doi" do
+ let(:work) { pending_work }
+ it "returns false" do
+ expect(work.doi).to eq pending_doi
+ expect(work.doi_minted?).to eq false
+ end
+ end
+ context "with a doi" do
+ let(:work) { minted_work }
+ it "returns true" do
+ expect(work.doi).to eq minted_doi
+ expect(work.doi_minted?).to eq true
+ end
+ end
+ end
+
+ describe "#doi_minting_enabled?" do
+ let(:work) { unminted_work }
+ it "returns server setting" do
+ expect(work.doi_minting_enabled?).to eq Datacore::DoiMintingService.enabled?
+ end
+ end
+
+ describe "#doi_pending?" do
+ context "with a nil doi" do
+ let(:work) { unminted_work }
+ it "returns false" do
+ expect(work.doi).to be_nil
+ expect(work.doi_pending?).to eq false
+ end
+ end
+ context "with a pending doi" do
+ let(:work) { pending_work }
+ it "returns true" do
+ expect(work.doi).to eq pending_doi
+ expect(work.doi_pending?).to eq true
+ end
+ end
+ context "with a doi" do
+ let(:work) { minted_work }
+ it "returns false" do
+ expect(work.doi).to eq minted_doi
+ expect(work.doi_pending?).to eq false
+ end
+ end
+ end
+
+ describe "#doi_minimum_files?" do
+ let(:work) { minted_work }
+ context "without minimum files" do
+ it "returns false" do
+ expect(work.file_sets.count).to eq 0
+ expect(work.doi_minimum_files?).to eq false
+ end
+ end
+ context "with minimum files" do
+ before(:each) do
+ work.ordered_members << file_set
+ work.save
+ end
+ it "returns true" do
+ expect(work.file_sets.count).to eq 1
+ expect(work.doi_minimum_files?).to eq true
+ end
+ end
+ end
+
+ describe "#doi_mint" do
+ before(:each) do
+ allow(work).to receive(:doi_minting_enabled?).and_return(true)
+ allow(Rails.logger).to receive(:warn)
+ allow(Rails.logger).to receive(:info)
+ allow(DoiMintingJob).to receive(:perform_later).and_return(true)
+ end
+ context "when minting is disabled" do
+ let(:work) { unminted_work }
+ before(:each) do
+ allow(work).to receive(:doi_minting_enabled?).and_return(false)
+ end
+ it "logs a warning" do expect(Rails.logger).to receive(:warn); work.doi_mint end
+ it "returns false" do expect(work.doi_mint).to eq false end
+ end
+ context "when metadata is invalid" do
+ let(:work) { unminted_work }
+ before(:each) do
+ work.title = nil
+ work.save(validate: false)
+ expect(work).to be_invalid
+ end
+ it "logs a warning" do expect(Rails.logger).to receive(:warn); work.doi_mint end
+ it "returns false" do expect(work.doi_mint).to eq false end
+ end
+ context "when minting is in progress" do
+ let(:work) { pending_work }
+ it "logs a warning" do expect(Rails.logger).to receive(:warn); work.doi_mint end
+ it "returns false" do expect(work.doi_mint).to eq false end
+ end
+ context "when already minted" do
+ let(:work) { minted_work }
+ it "logs a warning" do expect(Rails.logger).to receive(:warn); work.doi_mint end
+ it "returns false" do expect(work.doi_mint).to eq false end
+ end
+ context "when insufficient files" do
+ let(:work) { unminted_work }
+ before(:each) do
+ allow(work).to receive(:doi_minimum_files?).and_return(false)
+ end
+ it "logs a warning" do expect(Rails.logger).to receive(:warn); work.doi_mint end
+ it "returns false" do expect(work.doi_mint).to eq false end
+ end
+ context "when no doi yet" do
+ let(:work) { unminted_work }
+ before(:each) do
+ allow(work).to receive(:doi_minimum_files?).and_return(true)
+ end
+ it "updates DOI to pending" do
+ expect(work.doi).to be_nil
+ work.doi_mint
+ expect(work.doi).to eq pending_doi
+ end
+ it "calls DoiMintingJob" do
+ expect(DoiMintingJob).to receive(:perform_later).and_return(true)
+ work.doi_mint
+ end
+ it "logs success" do expect(Rails.logger).to receive(:info); work.doi_mint end
+ it "returns true" do expect(work.doi_mint).to eq true end
+ end
+ end
+end