From 668bfdabaa70ed6c5ef99e48333c248dfe25e626 Mon Sep 17 00:00:00 2001 From: Prakhar Date: Sat, 3 Oct 2020 17:06:49 +0530 Subject: [PATCH 1/4] Added exception for when the maintainer group is not created 404 is raised --- views/maintainer_group.py | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/views/maintainer_group.py b/views/maintainer_group.py index cd082d3..26b7257 100644 --- a/views/maintainer_group.py +++ b/views/maintainer_group.py @@ -7,6 +7,8 @@ MaintainerGroupSerializer, ) +from django.core.exceptions import ObjectDoesNotExist + class MaintainerGroupView(generics.RetrieveAPIView): """ @@ -25,3 +27,5 @@ def get_object(self, *args, **kwargs): return MaintainerGroup.objects.get(pk=1) except IndexError: raise Http404 + except ObjectDoesNotExist: + raise Http404 From bd7aeaec95c898a01047ae3f5218116b4aeafc6d Mon Sep 17 00:00:00 2001 From: Prakhar Date: Thu, 8 Oct 2020 23:52:28 +0530 Subject: [PATCH 2/4] Change ObjectDoesNotExist exception to MaintainerGroup.DoesNotExist and remove Index Error exception --- views/maintainer_group.py | 8 ++------ 1 file changed, 2 insertions(+), 6 deletions(-) diff --git a/views/maintainer_group.py b/views/maintainer_group.py index 26b7257..a73e6e5 100644 --- a/views/maintainer_group.py +++ b/views/maintainer_group.py @@ -7,8 +7,6 @@ MaintainerGroupSerializer, ) -from django.core.exceptions import ObjectDoesNotExist - class MaintainerGroupView(generics.RetrieveAPIView): """ @@ -25,7 +23,5 @@ def get_object(self, *args, **kwargs): try: return MaintainerGroup.objects.get(pk=1) - except IndexError: - raise Http404 - except ObjectDoesNotExist: - raise Http404 + except MaintainerGroup.DoesNotExist: + raise Http404h From 272746a8e3e2e1f0c28054342d59c72bfa342ddb Mon Sep 17 00:00:00 2001 From: Prakhar Date: Fri, 9 Oct 2020 00:03:08 +0530 Subject: [PATCH 3/4] Revert changes due to mistyping --- views/maintainer_group.py | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/views/maintainer_group.py b/views/maintainer_group.py index a73e6e5..bd710b2 100644 --- a/views/maintainer_group.py +++ b/views/maintainer_group.py @@ -23,5 +23,10 @@ def get_object(self, *args, **kwargs): try: return MaintainerGroup.objects.get(pk=1) +<<<<<<< HEAD except MaintainerGroup.DoesNotExist: raise Http404h +======= + except IndexError: + raise Http404 +>>>>>>> parent of 668bfda... Added exception for when the maintainer group is not created 404 is raised From cdf4806d8f9983eefd592db840145fef822fd0e1 Mon Sep 17 00:00:00 2001 From: Prakhar Date: Fri, 9 Oct 2020 00:05:18 +0530 Subject: [PATCH 4/4] Change ObjectDoesNotExist exception to MaintainerGroup.DoesNotExist and remove Index Error exception --- views/maintainer_group.py | 5 ----- 1 file changed, 5 deletions(-) diff --git a/views/maintainer_group.py b/views/maintainer_group.py index bd710b2..db70b00 100644 --- a/views/maintainer_group.py +++ b/views/maintainer_group.py @@ -23,10 +23,5 @@ def get_object(self, *args, **kwargs): try: return MaintainerGroup.objects.get(pk=1) -<<<<<<< HEAD except MaintainerGroup.DoesNotExist: - raise Http404h -======= - except IndexError: raise Http404 ->>>>>>> parent of 668bfda... Added exception for when the maintainer group is not created 404 is raised