From 04516a64bc5b5e695e9c6779f1eb7cfa0da07f83 Mon Sep 17 00:00:00 2001 From: Rishi Date: Sun, 19 Feb 2023 01:24:21 +0530 Subject: [PATCH 1/2] add dark mode arrow --- library/javascript/components/slider.js | 13 +++++++++++-- 1 file changed, 11 insertions(+), 2 deletions(-) diff --git a/library/javascript/components/slider.js b/library/javascript/components/slider.js index fa374304..a17ae672 100644 --- a/library/javascript/components/slider.js +++ b/library/javascript/components/slider.js @@ -123,7 +123,11 @@ document.addEventListener('DOMContentLoaded', function (e) { const leftArrowElement = document.createElement('img') leftArrowElement.className = 'arrow' - leftArrowElement.setAttribute('src', leftArrow) + leftArrowElement.setAttribute('data-icon', 'carouselleft') + leftArrowElement.classList.add('ui') + leftArrowElement.classList.add('icon') + leftArrowElement.classList.add('prev') + leftArrowElement.classList.add('icon_image') leftArrowContainer.appendChild(leftArrowElement) const rightArrowContainer = document.createElement('div') @@ -131,8 +135,13 @@ document.addEventListener('DOMContentLoaded', function (e) { const rightArrowElement = document.createElement('img') rightArrowElement.className = 'arrow' - rightArrowElement.setAttribute('src', rightArrow) + rightArrowElement.setAttribute('data-icon', 'carouselright') + rightArrowElement.classList.add('ui') + rightArrowElement.classList.add('icon') + rightArrowElement.classList.add('next') + rightArrowElement.classList.add('icon_image') rightArrowContainer.appendChild(rightArrowElement) + loadIcons() sliders[i].appendChild(leftArrowContainer) sliders[i].appendChild(container) From faae1d0bd029c800f40adb52ac20cb371b1fb2ee Mon Sep 17 00:00:00 2001 From: Rishi Date: Wed, 5 Apr 2023 17:54:45 +0530 Subject: [PATCH 2/2] fix loadIcons --- library/javascript/components/slider.js | 4 ++-- test/components/slider.html | 1 + 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/library/javascript/components/slider.js b/library/javascript/components/slider.js index a17ae672..ca2d92f9 100644 --- a/library/javascript/components/slider.js +++ b/library/javascript/components/slider.js @@ -140,12 +140,12 @@ document.addEventListener('DOMContentLoaded', function (e) { rightArrowElement.classList.add('icon') rightArrowElement.classList.add('next') rightArrowElement.classList.add('icon_image') - rightArrowContainer.appendChild(rightArrowElement) - loadIcons() + rightArrowContainer.appendChild(rightArrowElement) sliders[i].appendChild(leftArrowContainer) sliders[i].appendChild(container) sliders[i].appendChild(rightArrowContainer) + loadIcons() leftArrowElement.addEventListener('click', function (e) { e.stopPropagation() diff --git a/test/components/slider.html b/test/components/slider.html index 513f3fba..efb3f244 100644 --- a/test/components/slider.html +++ b/test/components/slider.html @@ -51,5 +51,6 @@ +