-
Notifications
You must be signed in to change notification settings - Fork 0
Closed
Description
This issue collects a few well-defined minor issues found during recent code review (excluding previously reported pandas usage):
1. Unused Import
- File:
core/monitor.py - Line:
import platform - Problem: The
platformimport is not used in the file and can be safely removed.
2. Redundant GPU Check Logic
- File:
core/monitor.py - Method:
_get_gpu_percent - Problem: The check
if not _GPUS_AVAILABLE: return 0.0and the surrounding logic can be streamlined or simplified. Dead/never-reached path is present. Consider refactoring to clarify GPU detection and fallback behavior.
3. Requirements File, tkinter/tk Declarations
- File:
requirements.txt - Problem:
tkinterandtkare listed as pip dependencies, but these are standard library/built-in in Python and usually not installed with pip. They can cause install errors. Remove them from requirements and consider describing the dependency in documentation instead (with a note about system requirements for Linux users).
4. Package Name Consistency for GPUtil
- File:
requirements.txt - Problem: The package is referenced as
gputilin requirements but imported asGPUtil(case-sensitive). Confirm the correct pip install name (GPUtil) and standardize the spelling in requirements, docs, and code.
5. Unclear Error Logging
- Files: Several (e.g.
core/monitor.py,core/hardware_sensors.py, UI modules) - Problem: Many exception blocks use
except: passwith no log or traceback, which may hide issues while debugging or in production. Use proper logging in all broad except blocks.
Improvements to the codebase are progressing really well.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels