refactor: remove native bindings support

- Removed the `gaussdb.native` interface and all native-specific code.
- Simplified the test suite to only run against the JS implementation.
- Updated docs about `pg-native`.

BREAKING CHANGE: The `gaussdb.native` interface has been removed.

Author: happy-game

README.md

@@ -5,15 +5,14 @@
 <span class="badge-npmversion"><a href="https://npmjs.org/package/gaussdb" title="View this project on NPM"><img src="https://img.shields.io/npm/v/gaussdb.svg" alt="NPM version" /></a></span>
 <span class="badge-npmdownloads"><a href="https://npmjs.org/package/gaussdb" title="View this project on NPM"><img src="https://img.shields.io/npm/dm/gaussdb.svg" alt="NPM downloads" /></a></span> -->
 
-Non-blocking GaussDB client for Node.js. Pure JavaScript and optional native libpq bindings.
+Non-blocking GaussDB client for Node.js.
 
 ## Monorepo
 
 This repo is a monorepo which contains the core [gaussdb](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/gaussdb) module as well as a handful of related modules.
 
 - [gaussdb](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/gaussdb)
 - [gaussdb-pool](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/gaussdb-pool)
-- [pg-native](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/pg-native)
 - [gaussdb-cursor](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/gaussdb-cursor)
 - [gaussdb-query-stream](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/gaussdb-query-stream)
 - [gaussdb-connection-string](https://github.com/HuaweiCloudDeveloper/gaussdb-node/tree/master/packages/gaussdb-connection-string)
@@ -37,7 +36,6 @@ The source repo for the documentation is available for contribution [here](https
 
 ### Features
 
-- Pure JavaScript client and native libpq bindings share _the same API_
 - Connection pooling
 - Extensible JS ↔ GaussDB data-type coercion
 - Supported GaussDB features
@@ -77,11 +75,10 @@ If your change involves breaking backwards compatibility please please point tha
 ### Setting up for local development
 
 1. Clone the repo
-2. Ensure you have installed libpq-dev in your system.
-3. From your workspace root run `yarn` and then `yarn lerna bootstrap`
-4. Ensure you have a GaussDB instance running with SSL enabled and an empty database for tests
-5. Ensure you have the proper environment variables configured for connecting to the instance
-6. Run `yarn test` to run all the tests
+2. From your workspace root run `yarn` and then `yarn lerna bootstrap`
+3. Ensure you have a GaussDB instance running with SSL enabled and an empty database for tests
+4. Ensure you have the proper environment variables configured for connecting to the instance
+5. Run `yarn test` to run all the tests
 
 ## License
 

docs/pages/features/_meta.json

@@ -5,7 +5,6 @@
   "transactions": "Transactions",
   "types": "Data Types",
   "ssl": "SSL",
-  "native": "Native",
   "esm": "ESM",
   "callbacks": "Callbacks"
 }

docs/pages/features/native.mdx

@@ -7,5 +7,5 @@
       "allowBranch": "master"
     }
   },
-  "ignoreChanges": ["**/*.md", "**/test/**", "packages/pg-native/**", "packages/pg-native-*/**"]
+  "ignoreChanges": ["**/*.md", "**/test/**"]
 }

lerna.json

@@ -8,7 +8,7 @@ Use a GaussDB result cursor from node with an easy to use API.
 ```sh
 $ npm install gaussdb-cursor
 ```
-___note___: this depends on _either_ `npm install gaussdb` or `npm install gaussdb.js`, but you __must__ be using the pure JavaScript client.  This will __not work__ with the native bindings.
+___note___: this depends on _either_ `npm install gaussdb` or `npm install gaussdb.js`, but you __must__ be using the pure JavaScript client.
 
 ### :star: Documentation :star:
 

packages/gaussdb-cursor/README.md

@@ -7,7 +7,6 @@ const paths = [
   'gaussdb-node/lib/index.js',
   'gaussdb-node/lib/connection-parameters.js',
   'gaussdb-protocol/dist/messages.js',
-  'pg-native/lib/build-result.js',
 ]
 for (const path of paths) {
   describe(`importing ${path}`, () => {
@@ -18,13 +17,3 @@ for (const path of paths) {
   })
 }
 
-describe('pg-native', () => {
-  it('should work with commonjs', async () => {
-    const gaussdb = require('gaussdb-node')
-
-    const pool = new gaussdb.native.Pool()
-    const result = await pool.query('SELECT 1')
-    assert.strictEqual(result.rowCount, 1)
-    pool.end()
-  })
-})

packages/gaussdb-esm-test/common-js-imports.test.cjs

@@ -18,8 +18,7 @@
     "gaussdb-cursor": "^0.2.0",
     "gaussdb-pool": "^0.2.0",
     "gaussdb-protocol": "^0.2.0",
-    "gaussdb-query-stream": "^0.2.0",
-    "pg-native": "^3.5.0"
+    "gaussdb-query-stream": "^0.2.0"
   },
   "author": "Brian M. Carlson <[email protected]>",
   "license": "MIT"

packages/gaussdb-esm-test/package.json

@@ -6,7 +6,7 @@ params := $(connectionString)
 
 node-command := xargs -n 1 -I file node file $(params)
 
-.PHONY : test test-connection test-integration bench test-native \
+.PHONY : test test-connection test-integration bench \
 	 publish update-npm
 
 all:
@@ -17,7 +17,7 @@ help:
 
 test: test-unit
 
-test-all: test-unit test-integration test-native test-worker
+test-all: test-unit test-integration test-worker
 
 
 update-npm:
@@ -33,15 +33,6 @@ test-connection:
 	@echo "***Testing connection***"
 	@node script/create-test-tables.js $(params)
 
-test-native: test-connection
-	@echo "***Testing native bindings***"
-ifeq ($(TEST_SKIP_NATIVE), true)
-	@echo "***Skipping tests***"
-else
-	@find test/native -name "*-tests.js" | $(node-command)
-	@find test/integration -name "*-tests.js" | $(node-command) native
-endif
-
 test-integration: test-connection
 	@echo "***Testing Pure Javascript***"
 	@find test/integration -name "*-tests.js" | $(node-command)

packages/gaussdb-esm-test/pg-native.test.js

@@ -4,16 +4,15 @@
 
 ### Features
 
-- Pure JavaScript client and native libpq bindings share _the same API_
 - Connection pooling
 - Extensible JS ↔ GaussDB data-type coercion
 
-Non-blocking GaussDB client for Node.js. Pure JavaScript and optional native libpq bindings.
+Non-blocking GaussDB client for Node.js.
 
 ## Install
 
 ```sh
-$ npm install gaussdb
+$ npm install gaussdb-node
 ```
 
 ---
@@ -22,7 +21,6 @@ $ npm install gaussdb
 
 ### Features
 
-- Pure JavaScript client and native libpq bindings share _the same API_
 - Connection pooling
 - Extensible JS ↔ Gaussdb data-type coercion
 - Supported Gaussdb features