Skip to content

Commit acdd6f7

Browse files
committed
Fail on unknown brew subcommand
Previously brew would return a 0 exit code and no output if someone typos a command. Before: ```console ❯ brew instlal ❯ echo $? 0 ``` After: ```console ❯ brew instlal Example usage: brew search TEXT|/REGEX/ brew info [FORMULA|CASK...] brew install FORMULA|CASK... brew update brew upgrade [FORMULA|CASK...] brew uninstall FORMULA|CASK... brew list [FORMULA|CASK...] Troubleshooting: brew config brew doctor brew install --verbose --debug FORMULA|CASK Contributing: brew create URL [--no-fetch] brew edit [FORMULA|CASK...] Further help: brew commands brew help [COMMAND] man brew https://docs.brew.sh Error: Invalid usage: Unknown command: brew instlal ❯ echo $? 1 ```
1 parent b3dc297 commit acdd6f7

File tree

1 file changed

+2
-0
lines changed

1 file changed

+2
-0
lines changed

Library/Homebrew/brew.rb

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -120,6 +120,8 @@
120120
ENV["HOMEBREW_#{env}"] = Object.const_get(:"HOMEBREW_#{env}").to_s
121121
end
122122
exec "brew-#{cmd}", *ARGV
123+
else
124+
raise UsageError, "Unknown command: brew #{cmd}"
123125
end
124126
rescue UsageError => e
125127
require "help"

0 commit comments

Comments
 (0)