Improve Cask upgrades

- Don't download unnecessary casks with download queue
- Don't show "no outdated dependents to upgrade" message
- Skip some messages/work if there's no outdated casks

Author: MikeMcQuaid

Library/Homebrew/cask/upgrade.rb

@@ -9,6 +9,53 @@ module Cask
   class Upgrade
     extend ::Utils::Output::Mixin
 
+    sig { returns(T::Array[String]) }
+    def self.greedy_casks
+      if (upgrade_greedy_casks = Homebrew::EnvConfig.upgrade_greedy_casks.presence)
+        upgrade_greedy_casks.split
+      else
+        []
+      end
+    end
+
+    sig {
+      params(
+        casks:               T::Array[Cask],
+        args:                Homebrew::CLI::Args,
+        force:               T.nilable(T::Boolean),
+        quiet:               T.nilable(T::Boolean),
+        greedy:              T.nilable(T::Boolean),
+        greedy_latest:       T.nilable(T::Boolean),
+        greedy_auto_updates: T.nilable(T::Boolean),
+      ).returns(T::Array[Cask])
+    }
+    def self.outdated_casks(casks, args:, force:, quiet:,
+                            greedy: false, greedy_latest: false, greedy_auto_updates: false)
+      greedy = true if Homebrew::EnvConfig.upgrade_greedy?
+
+      if casks.empty?
+        Caskroom.casks(config: Config.from_args(args)).select do |cask|
+          cask_greedy = greedy || greedy_casks.include?(cask.token)
+          cask.outdated?(greedy: cask_greedy, greedy_latest:,
+                         greedy_auto_updates:)
+        end
+      else
+        casks.select do |cask|
+          raise CaskNotInstalledError, cask if !cask.installed? && !force
+
+          if cask.outdated?(greedy: true)
+            true
+          elsif cask.version.latest?
+            opoo "Not upgrading #{cask.token}, the downloaded artifact has not changed" unless quiet
+            false
+          else
+            opoo "Not upgrading #{cask.token}, the latest version is already installed" unless quiet
+            false
+          end
+        end
+      end
+    end
+
     sig {
       params(
         casks:               Cask,
@@ -43,35 +90,8 @@ def self.upgrade_casks!(
     )
       quarantine = true if quarantine.nil?
 
-      greedy = true if Homebrew::EnvConfig.upgrade_greedy?
-
-      greedy_casks = if (upgrade_greedy_casks = Homebrew::EnvConfig.upgrade_greedy_casks.presence)
-        upgrade_greedy_casks.split
-      else
-        []
-      end
-
-      outdated_casks = if casks.empty?
-        Caskroom.casks(config: Config.from_args(args)).select do |cask|
-          cask_greedy = greedy || greedy_casks.include?(cask.token)
-          cask.outdated?(greedy: cask_greedy, greedy_latest:,
-                         greedy_auto_updates:)
-        end
-      else
-        casks.select do |cask|
-          raise CaskNotInstalledError, cask if !cask.installed? && !force
-
-          if cask.outdated?(greedy: true)
-            true
-          elsif cask.version.latest?
-            opoo "Not upgrading #{cask.token}, the downloaded artifact has not changed" unless quiet
-            false
-          else
-            opoo "Not upgrading #{cask.token}, the latest version is already installed" unless quiet
-            false
-          end
-        end
-      end
+      outdated_casks = \
+        self.outdated_casks(casks, args:, greedy:, greedy_latest:, greedy_auto_updates:, force:, quiet:)
 
       manual_installer_casks = outdated_casks.select do |cask|
         cask.artifacts.any? do |artifact|

Library/Homebrew/cmd/install.rb

@@ -4,6 +4,8 @@
 require "abstract_command"
 require "cask/config"
 require "cask/installer"
+require "cask/upgrade"
+
 require "cask_dependent"
 require "missing_formula"
 require "formula_installer"
@@ -246,13 +248,21 @@ def run
 
           download_queue = Homebrew::DownloadQueue.new_if_concurrency_enabled(pour: true)
           fetch_casks = Homebrew::EnvConfig.no_install_upgrade? ? new_casks : casks
+          outdated_casks = Cask::Upgrade.outdated_casks(fetch_casks, args:, force: true, quiet: true)
+          fetch_casks = outdated_casks.intersection(fetch_casks)
+
+          if download_queue && fetch_casks.any?
+            binaries = args.binaries?
+            verbose = args.verbose?
+            force = args.force?
+            require_sha = args.require_sha?
+            quarantine = args.quarantine?
+            skip_cask_deps = args.skip_cask_deps?
+            zap = args.zap?
 
-          if download_queue
             fetch_cask_installers = fetch_casks.map do |cask|
-              Cask::Installer.new(cask, binaries: args.binaries?, verbose: args.verbose?,
-                                                   force: args.force?, skip_cask_deps: args.skip_cask_deps?,
-                                                   require_sha: args.require_sha?, reinstall: true,
-                                                   quarantine: args.quarantine?, zap: args.zap?, download_queue:)
+              Cask::Installer.new(cask, reinstall: true, binaries:, verbose:, force:, skip_cask_deps:,
+                                  require_sha:, quarantine:, zap:, download_queue:)
             end
 
             # Run prelude checks for all casks before enqueueing downloads
@@ -281,8 +291,6 @@ def run
           end
 
           if !Homebrew::EnvConfig.no_install_upgrade? && installed_casks.any?
-            require "cask/upgrade"
-
             Cask::Upgrade.upgrade_casks!(
               *installed_casks,
               force:          args.force?,

Library/Homebrew/upgrade.rb

@@ -247,9 +247,7 @@ def upgrade_dependents(deps, formulae,
         upgradeable.reject! { |f| FormulaInstaller.installed.include?(f) }
 
         # Print the upgradable dependents.
-        if upgradeable.blank?
-          ohai "No outdated dependents to upgrade!" unless dry_run
-        else
+        if upgradeable.present?
           installed_formulae = (dry_run ? formulae : FormulaInstaller.installed.to_a).dup
           formula_plural = Utils.pluralize("formula", installed_formulae.count)
           upgrade_verb = dry_run ? "Would upgrade" : "Upgrading"