Merge pull request #21169 from Homebrew/deprecate-needs-dsl

Deprecate `Formula#needs` and remove `needs :openmp` support

Author: MikeMcQuaid

Library/Homebrew/compilers.rb

@@ -35,13 +35,6 @@ def version(val = T.unsafe(nil))
   sig { params(_: String).void }
   def cause(_); end
 
-  sig { params(standard: Symbol).returns(T::Array[CompilerFailure]) }
-  def self.for_standard(standard)
-    COLLECTIONS.fetch(standard) do
-      raise ArgumentError, "\"#{standard}\" is not a recognized standard"
-    end
-  end
-
   sig {
     params(spec: T.any(Symbol, T::Hash[Symbol, String]), block: T.nilable(T.proc.void)).returns(T.attached_class)
   }
@@ -101,13 +94,6 @@ def initialize(type, version, exact_major_match:, &block)
   def gcc_major(version)
     Version.new(version.major.to_s)
   end
-
-  COLLECTIONS = T.let({
-    openmp: [
-      create(:clang),
-    ],
-  }.freeze, T::Hash[Symbol, T::Array[CompilerFailure]])
-  private_constant :COLLECTIONS
 end
 
 # Class for selecting a compiler for a formula.

Library/Homebrew/formula.rb

@@ -4381,20 +4381,20 @@ def fails_with(compiler, &block)
       specs.each { |spec| spec.fails_with(compiler, &block) }
     end
 
-    # Marks the {Formula} as needing a certain standard, so Homebrew
-    # will fall back to other compilers if the default compiler
-    # does not implement that standard.
+    # Used to mark the {Formula} as needing a certain standard, so Homebrew
+    # would fall back to other compilers if the default compiler
+    # did not implement that standard.
     #
-    # We generally prefer to {.depends_on} a desired compiler and to
-    # explicitly use that compiler in a formula's {#install} block,
+    # This is now a no-op as we prefer to {.depends_on} a desired compiler
+    # and explicitly use that compiler in a formula's {#install} block,
     # rather than implicitly finding a suitable compiler with `needs`.
     #
     # @see .fails_with
     #
     # @api public
-    sig { params(standards: Symbol).void }
-    def needs(*standards)
-      specs.each { |spec| spec.needs(*standards) }
+    sig { params(_standards: Symbol).void }
+    def needs(*_standards)
+      odeprecated "`needs :openmp`", '`depends_on "gcc"`'
     end
 
     # A test is required for new formulae and makes us happy.

Library/Homebrew/software_spec.rb

@@ -323,13 +323,6 @@ def fails_with(compiler, &block)
     compiler_failures << CompilerFailure.create(compiler, &block)
   end
 
-  sig { params(standards: Symbol).void }
-  def needs(*standards)
-    standards.each do |standard|
-      compiler_failures.concat CompilerFailure.for_standard(standard)
-    end
-  end
-
   sig { params(dep: Dependable).void }
   def add_dep_option(dep)
     dep.option_names.each do |name|