Merge pull request #21174 from Homebrew/test-setup_test_formula

test: replace some install_test_formula with setup_test_formula

Author: cho-m

Library/Homebrew/test/cmd/autoremove_spec.rb

@@ -12,18 +12,12 @@
 
     before do
       # Make testball1 poured from a bottle
-      install_test_formula "testball1"
-      tab = Tab.for_name("testball1")
-      tab.poured_from_bottle = true
-      tab.write
+      tab_attributes = { poured_from_bottle: true, installed_on_request: true, installed_as_dependency: false }
+      setup_test_formula("testball1", tab_attributes:)
 
       # Make testball2 poured from a bottle and an unused dependency
-      install_test_formula "testball2"
-      tab = Tab.for_name("testball2")
-      tab.installed_on_request = false
-      tab.installed_as_dependency = true
-      tab.poured_from_bottle = true
-      tab.write
+      tab_attributes = { poured_from_bottle: true, installed_on_request: false, installed_as_dependency: true }
+      setup_test_formula("testball2", tab_attributes:)
     end
 
     it "only removes unused dependencies", :integration_test do

Library/Homebrew/test/cmd/link_spec.rb

@@ -7,12 +7,15 @@
   it_behaves_like "parseable arguments"
 
   it "links a given Formula", :integration_test do
-    install_test_formula "testball"
+    setup_test_formula "testball", tab_attributes: { installed_on_request: true }
     Formula["testball"].any_installed_keg.unlink
+    Formula["testball"].bin.mkpath
+    FileUtils.touch Formula["testball"].bin/"testfile"
 
     expect { brew "link", "testball" }
       .to output(/Linking/).to_stdout
       .and not_to_output.to_stderr
       .and be_a_success
+    expect(HOMEBREW_PREFIX/"bin/testfile").to be_a_file
   end
 end

Library/Homebrew/test/cmd/pin_spec.rb

@@ -7,7 +7,7 @@
   it_behaves_like "parseable arguments"
 
   it "pins a Formula's version", :integration_test do
-    install_test_formula "testball"
+    setup_test_formula "testball", tab_attributes: { installed_on_request: true }
 
     expect { brew "pin", "testball" }.to be_a_success
   end

Library/Homebrew/test/cmd/reinstall_spec.rb

@@ -8,11 +8,10 @@
   it_behaves_like "parseable arguments"
 
   it "reinstalls a Formula", :aggregate_failures, :integration_test do
-    install_test_formula "testball"
+    setup_test_formula "testball", tab_attributes: { installed_on_request: true }
 
     testball_bin = HOMEBREW_CELLAR/"testball/0.1/bin"
-    expect(testball_bin).to exist
-    FileUtils.rm_r(testball_bin)
+    expect(testball_bin).not_to exist
 
     expect { brew "reinstall", "testball" }
       .to output(/Reinstalling testball/).to_stdout

Library/Homebrew/test/cmd/uninstall_spec.rb

@@ -7,11 +7,13 @@
   it_behaves_like "parseable arguments"
 
   it "uninstalls a given Formula", :integration_test do
-    install_test_formula "testball"
+    setup_test_formula "testball", tab_attributes: { installed_on_request: true }
 
+    expect(HOMEBREW_CELLAR/"testball").to exist
     expect { brew "uninstall", "--force", "testball" }
       .to output(/Uninstalling testball/).to_stdout
       .and not_to_output.to_stderr
       .and be_a_success
+    expect(HOMEBREW_CELLAR/"testball").not_to exist
   end
 end

Library/Homebrew/test/cmd/unpin_spec.rb

@@ -7,7 +7,7 @@
   it_behaves_like "parseable arguments"
 
   it "unpins a Formula's version", :integration_test do
-    install_test_formula "testball"
+    setup_test_formula "testball", tab_attributes: { installed_on_request: true }
     Formula["testball"].pin
 
     expect { brew "unpin", "testball" }.to be_a_success

Library/Homebrew/test/formula_info_spec.rb

@@ -4,9 +4,8 @@
 
 RSpec.describe FormulaInfo, :integration_test do
   it "tests the FormulaInfo class" do
-    install_test_formula "testball"
-
-    info = described_class.lookup(Formula["testball"].path)
+    formula_path = setup_test_formula "testball"
+    info = described_class.lookup(formula_path)
     expect(info).not_to be_nil
     expect(info.revision).to eq(0)
     expect(info.bottle_tags).to eq([])