fix console completion selection on HTML5 (#3225)

ninjamuffin99 · Geokureli · web-flow · commit 9954eb5f0bef · 2024-08-14T14:28:44.000-05:00
* fix completion selection on HTML

revert formatting

* remove trailing whitespace

* Update flixel/system/debug/console/Console.hx

---------

Co-authored-by: George Kurelic &lt;Gkurelic@gmail.com&gt;
diff --git a/flixel/system/debug/completion/CompletionList.hx b/flixel/system/debug/completion/CompletionList.hx
@@ -37,8 +37,6 @@ class CompletionList extends Sprite
 		createPopupEntries(capacity);
 		createScrollBar();
 		updateSelectedItem();
-
-		FlxG.stage.addEventListener(KeyboardEvent.KEY_DOWN, onKeyDown);
 	}
 
 	public function show(x:Float, items:Array<String>)
@@ -82,7 +80,7 @@ class CompletionList extends Sprite
 		addChild(scrollBar);
 	}
 
-	function onKeyDown(e:KeyboardEvent)
+	public function onKeyDown(e:KeyboardEvent)
 	{
 		if (!visible)
 			return;
diff --git a/flixel/system/debug/console/Console.hx b/flixel/system/debug/console/Console.hx
@@ -196,7 +196,11 @@ class Console extends Window
 	function onKeyDown(e:KeyboardEvent)
 	{
 		if (completionList.visible)
+		{
+			// Fixes issue with listening for key down events - https://github.com/HaxeFlixel/flixel/pull/3225
+			completionList.onKeyDown(e);
 			return;
+		}
 
 		switch (e.keyCode)
 		{

Original file line number	Diff line number	Diff line change
`@@ -37,8 +37,6 @@ class CompletionList extends Sprite`
`37`	`37`	`createPopupEntries(capacity);`
`38`	`38`	`createScrollBar();`
`39`	`39`	`updateSelectedItem();`
`40`		`-`
`41`		`- FlxG.stage.addEventListener(KeyboardEvent.KEY_DOWN, onKeyDown);`
`42`	`40`	`}`
`43`	`41`
`44`	`42`	`public function show(x:Float, items:Array<String>)`
`@@ -82,7 +80,7 @@ class CompletionList extends Sprite`
`82`	`80`	`addChild(scrollBar);`
`83`	`81`	`}`
`84`	`82`
`85`		`- function onKeyDown(e:KeyboardEvent)`
	`83`	`+ public function onKeyDown(e:KeyboardEvent)`
`86`	`84`	`{`
`87`	`85`	`if (!visible)`
`88`	`86`	`return;`
Original file line number	Diff line number	Diff line change
`@@ -196,7 +196,11 @@ class Console extends Window`
`196`	`196`	`function onKeyDown(e:KeyboardEvent)`
`197`	`197`	`{`
`198`	`198`	`if (completionList.visible)`
	`199`	`+ {`
	`200`	`+ // Fixes issue with listening for key down events - https://github.com/HaxeFlixel/flixel/pull/3225`
	`201`	`+ completionList.onKeyDown(e);`
`199`	`202`	`return;`
	`203`	`+ }`
`200`	`204`
`201`	`205`	`switch (e.keyCode)`
`202`	`206`	`{`