Add useful internal vllm test #200
Draft
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nirda7
requested review from
afierka-intel,
jikunshang,
kzawora-intel,
madamczyk-intel,
mgawarkiewicz-intel,
michalkuligowski,
mswiniarsk,
tzielinski-habana and
xuechendi
as code owners
dudilester
reviewed
May 27, 2025
Contributor
There was a problem hiding this comment.
pytest will automatically run every file that is named test_*.py , since this is a manual script example of how to run quantization, maybe add it under examples folder and rename the file name.
As well this repo is used by customers, if we add the script here we will need to maintain it constantly to be aligned with latest vllm interface. (@linoybu , @ulivne, what is your opinion?)
Yantom1
reviewed
May 27, 2025
| os.environ['EXPERIMENTAL_WEIGHT_SHARING'] = "0" | ||
| os.environ['PT_HPU_ENABLE_LAZY_COLLECTIVES'] = "true" | ||
| os.environ['PT_HPU_LAZY_MODE'] = "1" | ||
| #PT_HPUGRAPH_DISABLE_TENSOR_CACHE=true |
Contributor
There was a problem hiding this comment.
Do we want to remain with all the lines the are commented?
Maybe add some description of the available options in each argument and leave only one default LLM creation and the script user will edit it for himself.
| end = time.time() | ||
| if is_fp8: | ||
| #if is_measure: | ||
| # llm.llm_engine.model_executor.shutdown_inc() |
| @@ -0,0 +1,15 @@ | |||
| { | |||
Contributor
There was a problem hiding this comment.
we should ship internal tests
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.