Merge pull request #50 from HPInc/fix/decode-url-path

juanjoseruiz · web-flow · commit cbd5a0e141f1 · 2023-09-04T15:48:28.000+02:00
Fix: decode url path before sign
diff --git a/src/OneflowSDK.php b/src/OneflowSDK.php
@@ -431,7 +431,7 @@ protected function post_file_s3($uploadUrl, $localPath)	{
 	 * @return string
 	 */
 	private function token($method, $path, $timestamp){
-		$stringToSign = strtoupper($method) . ' ' . $path . ' ' . $timestamp;
+		$stringToSign = strtoupper($method) . ' ' . urldecode($path) . ' ' . $timestamp;
 		return $this->key . ':' . hash_hmac('sha256', $stringToSign, $this->secret);
 	}
 

Original file line number	Diff line number	Diff line change
`@@ -431,7 +431,7 @@ protected function post_file_s3($uploadUrl, $localPath) {`
`431`	`431`	`* @return string`
`432`	`432`	`*/`
`433`	`433`	`private function token($method, $path, $timestamp){`
`434`		`- $stringToSign = strtoupper($method) . ' ' . $path . ' ' . $timestamp;`
	`434`	`+ $stringToSign = strtoupper($method) . ' ' . urldecode($path) . ' ' . $timestamp;`
`435`	`435`	`return $this->key . ':' . hash_hmac('sha256', $stringToSign, $this->secret);`
`436`	`436`	`}`
`437`	`437`