Skip to content

feat: improving wasm tracing for string params #252

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

feat: improving wasm tracing for string params #252

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
dc325a8
feat: improving wasm tracing for string params
mateustd-ciandt Jul 23, 2025
d7658e6
Merge branch 'main' into improve-trace-logs-195
mateustd-ciandt Jul 25, 2025
691cad6
Merge branch 'main' into improve-trace-logs-195
mateustd-ciandt Nov 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions plugins/test/framework.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -69,10 +69,14 @@ uint64_t TestContext::getMonotonicTimeNanoseconds() {
return absl::ToUnixNanos(options().clock_time);
}
proxy_wasm::WasmResult TestContext::log(uint32_t log_level,
std::string_view message) {
std::string_view message) {
logging_bytes_ += message.size();
if (wasmVm()->cmpLogLevel(proxy_wasm::LogLevel::trace)) {
std::cout << "TRACE from testcontext: [log] " << message << std::endl;
std::cout << "TRACE from integration: [vm->host] env.proxy_log("
<< log_level << ", "
<< reinterpret_cast<uint64_t>(message.data()) << ", "
Copy link
Collaborator

@mpwarres mpwarres Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not sure how useful it is to display the address and size of the message string, given that the value of the string is already output. Did you have a case in mind where this information would be valuable?

Copy link
Collaborator

@martijneken martijneken Nov 21, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Friendly ping on this PR. I had a use for it today (testing/inspecting a plugin I did not write and trying to understand its behaviors).

Copy link
Contributor Author

@mateustd-ciandt mateustd-ciandt Nov 24, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think this could be usefull especially in scenarios where memory management issues may arise, but I don't have a case in mind yet. @martijneken do you think the current modifications would bring additional benefits this way? thanks!

<< message.size() << ") \""
<< message << "\"" << std::endl;
}
if (wasmVm()->cmpLogLevel(static_cast<proxy_wasm::LogLevel>(log_level))) {
phase_logs_.emplace_back(message);
Expand Down