feat: improving wasm tracing for string params #252
+6
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mpwarres
reviewed
Aug 13, 2025
| std::cout << "TRACE from testcontext: [log] " << message << std::endl; | ||
| std::cout << "TRACE from integration: [vm->host] env.proxy_log(" | ||
| << log_level << ", " | ||
| << reinterpret_cast<uint64_t>(message.data()) << ", " |
Collaborator
There was a problem hiding this comment.
I'm not sure how useful it is to display the address and size of the message string, given that the value of the string is already output. Did you have a case in mind where this information would be valuable?
Collaborator
There was a problem hiding this comment.
Friendly ping on this PR. I had a use for it today (testing/inspecting a plugin I did not write and trying to understand its behaviors).
Contributor
Author
There was a problem hiding this comment.
I think this could be usefull especially in scenarios where memory management issues may arise, but I don't have a case in mind yet. @martijneken do you think the current modifications would bring additional benefits this way? thanks!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #195
This PR updates the logging mechanism in TestContext::log by enhancing the output format. The previous implementation simply printed the log message, while the new version provides more context by displaying the log level, memory address of the message, and its size.
This change will improve our debugging and tracing capabilities, making it easier to monitor logs and evaluate performance during development. Feel free to modify it as necessary!