Update recommended FI_UNIVERSE_SIZE setting for startup script

[linsword13]

This change makes libfabric to behave consistently, regardless whether it is dynamic or static built.

Submission Checklist

NOTE: Community submissions can take up to 2 weeks to be reviewed.

Please take the following actions before submitting this pull request.

• Fork your PR branch from the Toolkit "develop" branch (not main)
• Test all changes with pre-commit in a local branch #
• Confirm that "make tests" passes all tests
• Add or modify unit tests to cover code changes
• Ensure that unit test coverage remains above 80%
• Update all applicable documentation
• Follow Cluster Toolkit Contribution guidelines #

[gemini-code-assist]

Summary of Changes

Hello @linsword13, I'm Gemini Code Assist¹! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed!

This pull request addresses an inconsistency in libfabric's behavior by modifying a critical environment variable within the startup script. The change specifically targets the FI_UNIVERSE_SIZE setting, which is crucial for how libfabric operates, ensuring a uniform experience across different build configurations.

Highlights

• FI_UNIVERSE_SIZE Update: The FI_UNIVERSE_SIZE environment variable in the startup-script/main.tf module has been updated from 3072 to 1024. This adjustment aims to ensure consistent behavior for libfabric regardless of whether it is dynamically or statically built.

Using Gemini Code Assist

The full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips.

Invoking Gemini

You can request assistance from Gemini at any point by creating a comment using either /gemini <command> or @gemini-code-assist <command>. Below is a summary of the supported commands on the current page.

Feature	Command	Description
Code Review	/gemini review	Performs a code review for the current pull request in its current state.
Pull Request Summary	/gemini summary	Provides a summary of the current pull request in its current state.
Comment	@gemini-code-assist	Responds in comments when explicitly tagged, both in pull request comments and review comments.
Help	/gemini help	Displays a list of available commands.

Customization

To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a .gemini/ folder in the base of the repository. Detailed instructions can be found here.

Limitations & Feedback

Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here.

You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension.

Footnotes

1. Review the Privacy Notices, Generative AI Prohibited Use Policy, Terms of Service, and learn how to configure Gemini Code Assist in GitHub here. Gemini can make mistakes, so double check it and use code with caution. ↩

[gemini-code-assist]

Code Review

This pull request updates the FI_UNIVERSE_SIZE environment variable from 3072 to 1024 within the startup script. According to the description, this is to ensure consistent behavior for libfabric regardless of whether it's built statically or dynamically. The change is straightforward and seems correct. I have added one suggestion to include a comment explaining the reason for this specific value to improve code maintainability.

[gemini-code-assist]

For better maintainability, it would be helpful to add a comment explaining why FI_UNIVERSE_SIZE is set to 1024. This context, which you've provided in the pull request description, will be valuable for future developers working on this script.

        export FI_UNIVERSE_SIZE=1024 # Recommended for consistent behavior between static and dynamic libfabric builds.

[linsword13]

@samskillman, any concern regarding this change? (I tried to apply label to the PR, but didn't have the permission.)

[bytetwin]

I don't see any issues with this change as its restricted only rdma networking through this flag https://github.com/search?q=repo%3AGoogleCloudPlatform%2Fcluster-toolkit%20set_ofi_cloud_rdma_tunables&type=code

[bytetwin]

/gcbrun