diff --git a/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResult.java b/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResult.java index 4e896e2e..d5c67d59 100644 --- a/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResult.java +++ b/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResult.java @@ -31,18 +31,18 @@ class SpannerClientLibraryResult implements Result { private final Flux resultRows; - private final int numRowsUpdated; + private final long numRowsUpdated; private RowMetadata rowMetadata; public SpannerClientLibraryResult( - Flux resultRows, int numRowsUpdated) { + Flux resultRows, long numRowsUpdated) { this.resultRows = Assert.requireNonNull(resultRows, "A non-null flux of rows is required."); this.numRowsUpdated = numRowsUpdated; } @Override - public Publisher getRowsUpdated() { + public Publisher getRowsUpdated() { return Mono.just(this.numRowsUpdated); } diff --git a/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryRowMetadata.java b/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryRowMetadata.java index 88973c46..da8d6c93 100644 --- a/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryRowMetadata.java +++ b/cloud-spanner-r2dbc/src/main/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryRowMetadata.java @@ -81,7 +81,6 @@ public List getColumnMetadatas() { return this.columnMetadatas; } - @Override public Collection getColumnNames() { return this.columnNames; } diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryBasedIntegrationTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryBasedIntegrationTest.java index 13157f6c..7792838b 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryBasedIntegrationTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryBasedIntegrationTest.java @@ -144,7 +144,7 @@ void testMetadata() { .bind("price", new BigDecimal("123.99")) .execute()) .flatMapMany(rs -> rs.getRowsUpdated()) - ).expectNext(1).verifyComplete(); + ).expectNext(1L).verifyComplete(); StepVerifier.create( Mono.from(conn.createStatement("SELECT AUTHOR, PRICE FROM BOOKS LIMIT 1").execute()) @@ -195,7 +195,7 @@ void testDmlInsert() { ) .execute()) .flatMapMany(rs -> rs.getRowsUpdated()) - ).expectNext(1).verifyComplete(); + ).expectNext(1L).verifyComplete(); StepVerifier.create( Mono.from(conn.createStatement("SELECT count(*) FROM BOOKS").execute()) @@ -244,7 +244,7 @@ void testJsonFieldInsert() { .bind("extra", JsonWrapper.of("{\"b\":9,\"a\":true}")) .execute()) .flatMapMany(rs -> rs.getRowsUpdated())) - .expectNext(1) + .expectNext(1L) .verifyComplete(); StepVerifier.create( @@ -467,7 +467,7 @@ void selectMultipleBoundParameterSetsNoTransaction() { ).flatMap(r -> r.getRowsUpdated()) )) - ).expectNext(1, 1, 1).verifyComplete(); + ).expectNext(1L, 1L, 1L).verifyComplete(); StepVerifier.create( Mono.from(connectionFactory.create()).flatMapMany( @@ -511,7 +511,7 @@ void selectMultipleBoundParameterSetsInTransaction() { ).flatMap(r -> r.getRowsUpdated()) )) - ).expectNext(1, 1, 1).verifyComplete(); + ).expectNext(1L, 1L, 1L).verifyComplete(); StepVerifier.create( Mono.from(connectionFactory.create()).flatMapMany( @@ -553,7 +553,7 @@ void insertMultipleBoundParameterSetsNoTransaction() { .execute() ) .flatMap(rs -> rs.getRowsUpdated())) - ).expectNext(1, 1, 1).as("Row insert count matches").verifyComplete(); + ).expectNext(1L, 1L, 1L).as("Row insert count matches").verifyComplete(); StepVerifier.create( Mono.from(connectionFactory.create()) @@ -767,7 +767,7 @@ void testBatchDml() { .add("UPDATE BOOKS SET CATEGORY=17 WHERE CATEGORY=29") .execute() ).flatMap(r -> r.getRowsUpdated()) - ).expectNext(1, 1, 2) + ).expectNext(1L, 1L, 2L) .verifyComplete(); verifyIds(uuid1, uuid2); diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryDdlIntegrationTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryDdlIntegrationTest.java index bf0e46f5..9f6f20e4 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryDdlIntegrationTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/ClientLibraryDdlIntegrationTest.java @@ -79,7 +79,7 @@ void ddlCreateAndDrop() { .execute()) .log("Table" + tableName + " created") .flatMap(res -> Mono.from(res.getRowsUpdated())) - ).expectNext(0).as("DDL execution returns zero affected rows") + ).expectNext(0L).as("DDL execution returns zero affected rows") .verifyComplete(); StepVerifier.create( diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerDmlReactiveStreamVerification.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerDmlReactiveStreamVerification.java index a07a449a..f29f1115 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerDmlReactiveStreamVerification.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerDmlReactiveStreamVerification.java @@ -36,7 +36,7 @@ import reactor.core.publisher.Mono; class SpannerDmlReactiveStreamVerification extends - PublisherVerification { + PublisherVerification { private static ConnectionFactory connectionFactory; @@ -71,7 +71,7 @@ public SpannerDmlReactiveStreamVerification() { } @Override - public Publisher createPublisher(long l) { + public Publisher createPublisher(long l) { return Mono.from(connectionFactory.create()) .flatMapMany(conn -> Flux.from(conn.createStatement( @@ -82,7 +82,7 @@ public Publisher createPublisher(long l) { } @Override - public Publisher createFailedPublisher() { + public Publisher createFailedPublisher() { return Mono.from(connectionFactory.create()) .flatMapMany(conn -> conn.createStatement("UPDATE BOOKS SET bad syntax ").execute()) .flatMap(rs -> rs.getRowsUpdated()); diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerQueryUtil.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerQueryUtil.java index 6df711d9..64190f97 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerQueryUtil.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/it/SpannerQueryUtil.java @@ -43,10 +43,10 @@ static List executeReadQuery( /** * Executes a DML query and returns the rows updated. */ - static int executeDmlQuery(Connection connection, String sql) { + static long executeDmlQuery(Connection connection, String sql) { Mono.from(connection.beginTransaction()).block(); - int rowsUpdated = Mono.from(connection.createStatement(sql).execute()) + long rowsUpdated = Mono.from(connection.createStatement(sql).execute()) .flatMap(result -> Mono.from(result.getRowsUpdated())) .block(); Mono.from(connection.commitTransaction()).block(); diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/AbstractSpannerClientLibraryStatementTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/AbstractSpannerClientLibraryStatementTest.java index c7aa1d32..9813e6e8 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/AbstractSpannerClientLibraryStatementTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/AbstractSpannerClientLibraryStatementTest.java @@ -61,7 +61,7 @@ void noParametersSendsSingleStatement() { FakeStatement statement = new FakeStatement(this.mockAdapter, query); StepVerifier.create(Flux.from(statement.execute()).flatMap(r -> r.getRowsUpdated())) - .expectNext(19) + .expectNext(19L) .verifyComplete(); ArgumentCaptor capturedStatement = ArgumentCaptor.forClass(Statement.class); @@ -82,7 +82,7 @@ void singleSetOfParametersWithNoAddSendsOneStatement() { statement.bind("three", "333"); StepVerifier.create(Flux.from(statement.execute()).flatMap(r -> r.getRowsUpdated())) - .expectNext(19) + .expectNext(19L) .verifyComplete(); ArgumentCaptor capturedStatement = ArgumentCaptor.forClass(Statement.class); @@ -108,7 +108,7 @@ void singleSetOfParametersWithAddTriggersBatchWithOneStatement() { statement.add(); StepVerifier.create(Flux.from(statement.execute()).flatMap(r -> r.getRowsUpdated())) - .expectNext(7, 11, 13) + .expectNext(7L, 11L, 13L) .verifyComplete(); ArgumentCaptor> params = ArgumentCaptor.forClass(List.class); @@ -139,7 +139,7 @@ void twoParameterSetsWithNoTrailingAddSendsTwoStatements() { statement.bind("three", "B333"); StepVerifier.create(Flux.from(statement.execute()).flatMap(r -> r.getRowsUpdated())) - .expectNext(7, 11, 13) + .expectNext(7L, 11L, 13L) .verifyComplete(); ArgumentCaptor> params = ArgumentCaptor.forClass(List.class); @@ -175,7 +175,7 @@ void twoParameterSetsWithTrailingAddSendsTwoStatements() { statement.add(); StepVerifier.create(Flux.from(statement.execute()).flatMap(r -> r.getRowsUpdated())) - .expectNext(7, 11, 13) + .expectNext(7L, 11L, 13L) .verifyComplete(); ArgumentCaptor> params = ArgumentCaptor.forClass(List.class); diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/DatabaseClientReactiveAdapterTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/DatabaseClientReactiveAdapterTest.java index 2e231818..71917014 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/DatabaseClientReactiveAdapterTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/DatabaseClientReactiveAdapterTest.java @@ -283,7 +283,7 @@ void runBatchDml() { this.adapter.runBatchDml( ImmutableList.of(Statement.of("UPDATE something"), Statement.of("UPDATE something else"))) .flatMap(result -> result.getRowsUpdated()) - ).expectNext(42, 81) + ).expectNext(42L, 81L) .verifyComplete(); } @@ -299,7 +299,7 @@ void runBatchDml_rowCountAboveMaxIntIsTruncated() { this.adapter.runBatchDml( ImmutableList.of(Statement.of("UPDATE something"))) .flatMap(result -> result.getRowsUpdated()) - ).expectNext(Integer.MAX_VALUE) + ).expectNext(Long.valueOf(Integer.MAX_VALUE)) .verifyComplete(); } } diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerBatchTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerBatchTest.java index dec84f7c..14a37f49 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerBatchTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerBatchTest.java @@ -78,7 +78,7 @@ void batchPassesCorrectQueriesToAdapter() { batch.add("UPDATE tbl SET col1=val1") .add("UPDATE tbl SET col2=val2").execute() ).flatMap(r -> r.getRowsUpdated()) - ).expectNext(35, 47) + ).expectNext(35L, 47L) .verifyComplete(); ArgumentCaptor> argCaptor = ArgumentCaptor.forClass(List.class); diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnectionTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnectionTest.java index 467c187c..dbeed991 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnectionTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryConnectionTest.java @@ -71,7 +71,7 @@ void batchUsesCorrectAdapter() { Flux.from( batch.add("UPDATE tbl SET col1=val1").execute() ).flatMap(r -> r.getRowsUpdated()) - ).expectNext(35) + ).expectNext(35L) .verifyComplete(); ArgumentCaptor> argCaptor = ArgumentCaptor.forClass(List.class); diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDdlStatementTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDdlStatementTest.java index 37b31abc..4cf75284 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDdlStatementTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDdlStatementTest.java @@ -59,7 +59,7 @@ void executeDdlAffectsZeroRows() { StepVerifier.create( statement.execute().flatMap((Result r) -> Mono.from(r.getRowsUpdated())) - ).expectNext(0) + ).expectNext(0L) .verifyComplete(); } diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDmlStatementTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDmlStatementTest.java index a6708627..c129b2dc 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDmlStatementTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryDmlStatementTest.java @@ -48,7 +48,7 @@ void executeSingleNoRowsUpdated() { StepVerifier.create( Flux.from(dmlStatement.execute()).flatMap(result -> result.getRowsUpdated()) ) - .expectNext(0) + .expectNext(0L) .verifyComplete(); } @@ -68,7 +68,7 @@ void executeMultiple() { StepVerifier.create( Flux.from(dmlStatement.execute()).flatMap(result -> result.getRowsUpdated())) - .expectNext(2, 5) + .expectNext(2L, 5L) .verifyComplete(); } } diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResultTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResultTest.java index 539fe3dd..7a40c8dd 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResultTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryResultTest.java @@ -41,7 +41,7 @@ void nullRowsNotAllowed() { void getRowsUpdatedReturnsCorrectNumber() { SpannerClientLibraryResult result = new SpannerClientLibraryResult(Flux.empty(), 42); StepVerifier.create(result.getRowsUpdated()) - .expectNext(42) + .expectNext(42L) .verifyComplete(); } diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryStatementTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryStatementTest.java index 17938148..56f382bf 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryStatementTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerClientLibraryStatementTest.java @@ -56,7 +56,7 @@ void executeSingleNoRowsUpdated() { StepVerifier.create( Flux.from(statement.execute()).flatMap(result -> result.getRowsUpdated())) - .expectNext(0) + .expectNext(0L) .verifyComplete(); StepVerifier.create( diff --git a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerResultTest.java b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerResultTest.java index 9849759f..b1c2906a 100644 --- a/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerResultTest.java +++ b/cloud-spanner-r2dbc/src/test/java/com/google/cloud/spanner/r2dbc/v2/SpannerResultTest.java @@ -50,7 +50,7 @@ public void setup() { void getRowsUpdatedTest() { StepVerifier.create( ((Mono) new SpannerClientLibraryResult(this.resultSet, 2).getRowsUpdated())) - .expectNext(2) + .expectNext(2L) .verifyComplete(); } diff --git a/pom.xml b/pom.xml index e1aaf461..3e88e15b 100644 --- a/pom.xml +++ b/pom.xml @@ -86,7 +86,7 @@ 26.16.0 - 0.9.0.RELEASE + 1.0.0.RELEASE 2022.0.7 4.9.0