Skip to content

Conversation

@nikochiko
Copy link
Member

Legal Boilerplate

Look, I get it. The entity doing business as “Gooey.AI” and/or “Dara.network” was incorporated in the State of Delaware in 2020 as Dara Network Inc. and is gonna need some rights from me in order to utilize my contributions in this PR. So here's the deal: I retain all rights, title and interest in and to my contributions, and by keeping this boilerplate intact I confirm that Dara Network Inc can use, modify, copy, and redistribute my contributions, under its choice of terms.

@coderabbitai
Copy link

coderabbitai bot commented Sep 17, 2025

📝 Walkthrough

Walkthrough

Updates in chart/model-values.yaml adjust autoscaling settings for two deployments:

  • common-whisper-sunbird-short: autoscaling.minReplicaCount changed from 1 to 0.
  • retro-nemo-mbaza-asr: autoscaling.minReplicaCount changed from 0 to 1.
    No other fields in these deployment blocks are modified.

Estimated code review effort

🎯 1 (Trivial) | ⏱️ ~2 minutes

Possibly related PRs

Suggested reviewers

  • devxpy

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title "scale mbaza asr to 1 and sunbird to 0" concisely and accurately summarizes the primary change in chart/model-values.yaml: retro-nemo-mbaza-asr minReplicaCount is set to 1 and common-whisper-sunbird-short minReplicaCount is set to 0. It specifically references the affected components, avoids extraneous detail, and is clear for reviewers scanning PR history. Therefore the title matches the main changeset.
Description Check ✅ Passed The PR description exactly matches the repository's required Legal Boilerplate template and therefore satisfies the mandated template section. The description lacks a brief functional summary or rationale for the scaling changes (the file diffs show those changes), which is not required by the template but would help reviewers. Because the required template content is present and complete, this check passes.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment
  • Commit unit tests in branch mbaza-min-scale-1

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5ed6ae0 and ccf4704.

📒 Files selected for processing (1)
  • chart/model-values.yaml (2 hunks)
🔇 Additional comments (2)
chart/model-values.yaml (2)

159-173: Sunbird short ASR: scale-to-zero set — verify cold-start & KEDA routing

  • chart/model-values.yaml (lines 159–166) contains autoscaling.minReplicaCount: 0 for common-whisper-sunbird-short.
  • Confirm cooldownPeriod/scalingBehavior and acceptable cold-start latency under bursty traffic.
  • Verify KEDA ScaledObject/ScaledJob in chart/templates still match QUEUE_PREFIX + WHISPER_MODEL_IDS (e.g. "gooey-gpu/short" + "Sunbird/asr-whisper-large-v3-salt") so jobs route correctly when scaled to zero.

326-338: Mbaza ASR — set explicit maxReplicaCount if you want a single always‑on pod

  • chart/model-values.yaml (model block around lines ~326–338): autoscaling.minReplicaCount: 1 is set but no maxReplicaCount, so it inherits the global autoscaling.maxReplicaCount: 3. If you intend exactly one always‑on pod, add maxReplicaCount: 1; otherwise leave as-is.
  • Operational: verify the cluster has a GPU node able to satisfy limits_gpu: "4Gi" and memory: "10Gi"; consider adding a PodDisruptionBudget (minAvailable: 1).

Suggested patch:

  autoscaling:
    minReplicaCount: 1
+   maxReplicaCount: 1

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

@nikochiko nikochiko merged commit b75844c into main Sep 17, 2025
6 checks passed
@nikochiko nikochiko deleted the mbaza-min-scale-1 branch September 17, 2025 09:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants