Skip to content

Deforum Dockerfile update #38

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 3 commits into from
Closed

Deforum Dockerfile update #38

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
053b6ef
feat: enhance DeforumArgs and DeforumAnimArgs with new parameters and…
avi-007 Aug 13, 2025
ee0dc87
fix: update deforum_sd Dockerfile
avi-007 Aug 13, 2025
882ec46
Merge branch 'main' into deforum-update
avi-007 Aug 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions deforum_sd/Dockerfile
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,7 +28,7 @@ RUN curl -s -S -L https://raw.githubusercontent.com/pyenv/pyenv-installer/master
pyenv global 3.10

# copy to /src
ENV WORKDIR /src
ENV WORKDIR=/src
RUN mkdir -p $WORKDIR
WORKDIR $WORKDIR

Expand All @@ -40,7 +40,7 @@ RUN apt-get update && apt-get install -y --no-install-recommends \
libgl1-mesa-glx \
ffmpeg \
&& rm -rf /var/lib/apt/lists/*
COPY deforum_sd/requirements.txt .
COPY ./requirements.txt .
RUN pip install --no-cache-dir -U pip && pip install --no-cache-dir Cython && pip install --no-cache-dir -r requirements.txt
Comment on lines +43 to 44
Copy link

@coderabbitai coderabbitai bot Aug 13, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Verification agent

🧩 Analysis chain

Potential build break: COPY source path likely wrong for typical build context

If you build with context at the repo root (common when using -f deforum_sd/Dockerfile .), requirements.txt is usually at deforum_sd/requirements.txt. Changing to COPY ./requirements.txt . will fail unless requirements.txt was moved to the repo root. Line 44 relies on this file being present, so pip install will error if the COPY misses.

Recommended fix (assuming build context is repo root and requirements.txt remains under deforum_sd/):

-COPY ./requirements.txt .
+COPY deforum_sd/requirements.txt .

If instead you build with context set to deforum_sd/ (e.g., docker build deforum_sd/), keep COPY requirements.txt . but ensure your CI/build scripts use that context consistently.

Run this script to verify where requirements.txt lives and how Docker builds are invoked:

🏁 Script executed:

#!/bin/bash
set -euo pipefail

echo "Found requirements.txt files:"
fd -a --full-path -t f -g "requirements.txt" || true

echo
echo "Dockerfiles referencing deforum_sd:"
fd -a --full-path -t f -g "Dockerfile" | sed 's|^| - |'

echo
echo "Grepping for docker build commands in repo (Makefiles, scripts, CI):"
rg -n -A2 -i "docker build" || true

echo
echo "Heuristic check:"
if fd -t f -g "deforum_sd/requirements.txt" >/dev/null; then
  echo "deforum_sd/requirements.txt exists. With repo-root build context, use: COPY deforum_sd/requirements.txt ."
fi
if fd -t f -g "requirements.txt" | rg -q "^requirements.txt$"; then
  echo "Root-level requirements.txt exists. COPY ./requirements.txt . is valid if that is the intended file."
fi

Length of output: 1252

Update COPY path for requirements.txt in deforum_sd/Dockerfile

The project’s Docker build scripts invoke docker build . -f deforum_sd/Dockerfile from the repo root, but requirements.txt lives under deforum_sd/. As a result,
COPY ./requirements.txt . fails (there’s no root-level file). Update the COPY line to reference the correct path:

deforum_sd/Dockerfile (around lines 43–44):

-COPY ./requirements.txt .
+COPY deforum_sd/requirements.txt .
RUN pip install --no-cache-dir -U pip \
    && pip install --no-cache-dir Cython \
    && pip install --no-cache-dir -r requirements.txt

This ensures the file is found when building with context at the repository root.

📝 Committable suggestion

‼️ IMPORTANT
Carefully review the code before committing. Ensure that it accurately replaces the highlighted code, contains no missing lines, and has no issues with indentation. Thoroughly test & benchmark the code to ensure it meets the requirements.

Suggested change
COPY ./requirements.txt .
RUN pip install --no-cache-dir -U pip && pip install --no-cache-dir Cython && pip install --no-cache-dir -r requirements.txt
COPY deforum_sd/requirements.txt .
RUN pip install --no-cache-dir -U pip && pip install --no-cache-dir Cython && pip install --no-cache-dir -r requirements.txt
🤖 Prompt for AI Agents 
In deforum_sd/Dockerfile around lines 43 to 44, the COPY instruction references
./requirements.txt at repo root but the file actually lives in deforum_sd/, so
update the COPY path to point to the correct relative location (e.g., COPY
./deforum_sd/requirements.txt .) so the Docker build invoked from the repository
root can locate and include requirements.txt.


# copy sources
Expand Down
Loading