Logo URL Bug Fixed (#105)

* logo URL Bug fixed

Author: Manvityagi

controllers/opportunity/index.js

@@ -16,6 +16,7 @@ class opportunityController {
       opportunityDate,
       opportunityURL,
       onlyForFemale,
+      organisationLogoURL,
     } = req.body;
 
     try {
@@ -29,7 +30,8 @@ class opportunityController {
         opportunityRegistrationDeadline,
         opportunityDate,
         opportunityURL,
-        onlyForFemale
+        onlyForFemale,
+        organisationLogoURL
       );
 
       return res.status(201).json({

managers/opportunity/index.js

@@ -14,7 +14,8 @@ class opportunityManager {
     opportunityRegistrationDeadline,
     opportunityDate,
     opportunityURL,
-    onlyForFemale
+    onlyForFemale,
+    organisationLogoURL
   ) {
     let opportunity = {
       opportunityTitle: opportunityTitle,
@@ -27,8 +28,8 @@ class opportunityManager {
       opportunityDate: opportunityDate,
       opportunityURL: opportunityURL,
       onlyForFemale: onlyForFemale,
+      organisationLogoURL: organisationLogoURL,
     };
-    //console.log('Values received in manager', opportunity);
 
     try {
       let newOpportunity = await this.opportunity.create(opportunity);

models/opportunity.js

@@ -56,19 +56,16 @@ let opportunitySchema = new mongoose.Schema({
     required: true,
   },
 
-  onlyForFemale:{
-    type:Boolean,
-    required:true,
-    default:false
-  } 
-  ,
-  organisationLogoURL:{
-
-    type :String ,
-    required : false ,
-    default : "https://picsum.photos/200"
-  }
-
+  onlyForFemale: {
+    type: Boolean,
+    required: true,
+    default: false,
+  },
+  organisationLogoURL: {
+    type: String,
+    required: false,
+    default: 'https://picsum.photos/200',
+  },
 });
 
 export default mongoose.model('opportunity', opportunitySchema);

routes/opportunity.js

@@ -66,8 +66,8 @@ const opportunityManager = new OpportunityManager(),
  *                   example: true
  *                 organisationLogoURL:
  *                   type:string
- *                   description:URL of the organisation 
- *                   example:www.amazon.com 
+ *                   description:URL of the organisation
+ *                   example:www.amazon.com
  *       post_schema:
  *         type: object
  *         required:
@@ -180,7 +180,6 @@ router.get('/', (req, res) => {
  *        description: Sorry, opportunity could not be created!
  */
 router.post('/', (req, res) => {
-  console.log('Inside Route');
   opportunityController.createOpportunity(req, res);
 });
 
@@ -233,7 +232,7 @@ router.post('/', (req, res) => {
  *                type: string
  *                description: URL of the opportunity
  *              organisationLogoURL:
- *                type:string 
+ *                type:string
  *                description :URL of the organisation
  *     responses:
  *      201:

services/opportunity/index.js

@@ -12,10 +12,9 @@ class opportunityService {
     opportunityRegistrationDeadline,
     opportunityDate,
     opportunityURL,
-    onlyForFemale
+    onlyForFemale,
+    organisationLogoURL
   ) {
-    console.log('Inside Service');
-
     try {
       let newOpportunity = await this.opportunityManager.createOpportunity(
         opportunityTitle,
@@ -27,7 +26,8 @@ class opportunityService {
         opportunityRegistrationDeadline,
         opportunityDate,
         opportunityURL,
-        onlyForFemale
+        onlyForFemale,
+        organisationLogoURL
       );
       return newOpportunity;
     } catch (err) {
@@ -50,7 +50,9 @@ class opportunityService {
 
   async deleteOpportunity(opportunity_id) {
     try {
-      let deletedDocument = await this.opportunityManager.deleteOpportunity(opportunity_id);
+      let deletedDocument = await this.opportunityManager.deleteOpportunity(
+        opportunity_id
+      );
       return deletedDocument;
     } catch (err) {
       console.log('ERROR IN deleteOpportunity Service');

tests/managers/opportunity-test.js

@@ -176,6 +176,10 @@ describe('OpportunityManager', function () {
       expect(deletedOpportunity.opportunityRegistrationDeadline).to.equal(
         stubValue.opportunityRegistrationDeadline
       );
+
+      expect(deletedOpportunity.organisationLogoURL).to.equal(
+        stubValue.organisationLogoURL
+      );
     });
   });
 });