SpigotMC#3866: Make use of new ByteBuf#readString

Outfluencer · web-flow · commit df5305367753 · 2025-07-17T21:14:18.000+10:00
diff --git a/protocol/src/main/java/net/md_5/bungee/protocol/DefinedPacket.java b/protocol/src/main/java/net/md_5/bungee/protocol/DefinedPacket.java
@@ -129,8 +129,7 @@ public static String readString(ByteBuf buf, int maxLen)
             throw new OverflowPacketException( "Cannot receive string longer than " + maxLen * 3 + " (got " + len + " bytes)" );
         }
 
-        String s = buf.toString( buf.readerIndex(), len, StandardCharsets.UTF_8 );
-        buf.readerIndex( buf.readerIndex() + len );
+        String s = buf.readString( len, StandardCharsets.UTF_8 );
 
         if ( s.length() > maxLen )
         {

Original file line number	Diff line number	Diff line change
`@@ -129,8 +129,7 @@ public static String readString(ByteBuf buf, int maxLen)`
`129`	`129`	`throw new OverflowPacketException( "Cannot receive string longer than " + maxLen * 3 + " (got " + len + " bytes)" );`
`130`	`130`	`}`
`131`	`131`
`132`		`- String s = buf.toString( buf.readerIndex(), len, StandardCharsets.UTF_8 );`
`133`		`- buf.readerIndex( buf.readerIndex() + len );`
	`132`	`+ String s = buf.readString( len, StandardCharsets.UTF_8 );`
`134`	`133`
`135`	`134`	`if ( s.length() > maxLen )`
`136`	`135`	`{`