Merge pull request #160 from GetStream/release-0.4.0

Author: sachaarbonel

.github/workflows/build.yaml

@@ -57,12 +57,16 @@ jobs:
 
       - name: Post Codecov report
         run: bash <(curl -s https://codecov.io/bash) -t ${{ secrets.CODECOV_TOKEN }}
-
-      - uses: VeryGoodOpenSource/very_good_coverage@v1.1.1
+  
+      - uses: VeryGoodOpenSource/very_good_coverage@v1.2.0
         with:
           path: packages/stream_feed/coverage/lcov.info
-          min_coverage: 82  
-      - uses: VeryGoodOpenSource/very_good_coverage@v1.1.1
+          min_coverage: 81 
+      - uses: VeryGoodOpenSource/very_good_coverage@v1.2.0
         with:
           path: packages/faye_dart/coverage/lcov.info
           min_coverage: 49
+      - uses: VeryGoodOpenSource/[email protected]
+        with:
+          path: packages/stream_feed_flutter_core/coverage/lcov.info
+          min_coverage: 65

.gitignore

@@ -29,4 +29,6 @@
 build/
 example/pubspec.lock
 coverage.lcov
-coverage/
+coverage/
+packages/stream_feed_flutter/example/.flutter-plugins-dependencies
+packages/stream_feed_flutter/example/.flutter-plugins-dependencies

README.md

@@ -50,10 +50,10 @@ const apiKey = 'my-API-key';
 const secret = 'my-API-secret';
 
 // Instantiate a new client (server side)
-var client = StreamFeedClient.connect(apiKey, secret: secret);
+var client = StreamFeedClient(apiKey, secret: secret);
 
 // Optionally supply the app identifier and an options object specifying the data center to use and timeout for requests (15s)
-client = StreamFeedClient.connect(apiKey,
+client = StreamFeedClient(apiKey,
       secret: secret,
       appId: 'yourappid',
       options: StreamHttpClientOptions(
@@ -70,7 +70,7 @@ final userToken = client.frontendToken('the-user-id');
 
 ```dart
 // Instantiate new client with a user token
-var client = StreamFeedClient.connect(apiKey, token: Token('userToken'));
+var client = StreamFeedClient(apiKey, token: Token('userToken'));
 ```
 
 ### 🔮 Examples
@@ -235,7 +235,7 @@ Stream uses [Faye](https://faye.jcoglan.com) for realtime notifications. Below i
 ```dart
 
 // ⚠️ userToken is generated server-side (see previous section)
-final client = StreamFeedClient.connect('YOUR_API_KEY', token: userToken,appId: 'APP_ID');
+final client = StreamFeedClient('YOUR_API_KEY', token: userToken,appId: 'APP_ID');
 final user1 = client.flatFeed('user', '1');
 
 // subscribe to the changes

analysis_options.yaml

@@ -41,7 +41,6 @@ linter:
     - use_key_in_widget_constructors
     - valid_regexps
     - always_declare_return_types
-    - always_put_required_named_parameters_first
     - always_require_non_null_named_parameters
     - annotate_overrides
     - avoid_bool_literals_in_conditional_expressions
@@ -96,7 +95,6 @@ linter:
     - prefer_constructors_over_static_methods
     - prefer_contains
     - prefer_equal_for_default_values
-    - prefer_expression_function_bodies
     - prefer_final_fields
     - prefer_final_in_for_each
     - prefer_final_locals
@@ -116,7 +114,7 @@ linter:
     - prefer_spread_collections
     - prefer_typing_uninitialized_variables
     - provide_deprecation_message
-    - public_member_api_docs
+    # - public_member_api_docs
     - recursive_getters
     - sized_box_for_whitespace
     - slash_for_doc_comments

example/lib/activity_item.dart

@@ -1,20 +1,26 @@
+import 'package:example/app_user.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:stream_feed/stream_feed.dart';
 import 'package:timeago/timeago.dart' as timeago;
 
-import 'app_user.dart';
-
+//ignore: public_member_api_docs
 class ActivityCard extends StatelessWidget {
-  final Activity activity;
+  //ignore: public_member_api_docs
+  const ActivityCard({
+    required this.activity,
+    Key? key,
+  }) : super(key: key);
 
-  const ActivityCard({Key? key, required this.activity}) : super(key: key);
+  //ignore: public_member_api_docs
+  final Activity activity;
 
   @override
   Widget build(BuildContext context) {
     final user = appUsers
         .firstWhere((it) => createUserReference(it.id) == activity.actor);
     return Padding(
-      padding: const EdgeInsets.symmetric(horizontal: 16.0, vertical: 8),
+      padding: const EdgeInsets.symmetric(horizontal: 16, vertical: 8),
       child: Column(
         crossAxisAlignment: CrossAxisAlignment.start,
         children: [
@@ -23,14 +29,14 @@ class ActivityCard extends StatelessWidget {
               CircleAvatar(
                 child: Text(user.name[0]),
               ),
-              SizedBox(width: 16),
+              const SizedBox(width: 16),
               Expanded(
                 child: Column(
                   crossAxisAlignment: CrossAxisAlignment.start,
                   children: [
                     Text(
                       user.name,
-                      style: TextStyle(
+                      style: const TextStyle(
                         fontSize: 18,
                       ),
                     ),
@@ -39,7 +45,7 @@ class ActivityCard extends StatelessWidget {
                         activity.time!,
                         allowFromNow: true,
                       )}',
-                      style: TextStyle(
+                      style: const TextStyle(
                         fontWeight: FontWeight.w300,
                       ),
                     ),
@@ -48,15 +54,21 @@ class ActivityCard extends StatelessWidget {
               )
             ],
           ),
-          SizedBox(height: 16),
+          const SizedBox(height: 16),
           Text(
-            activity.extraData!['tweet'] as String,
-            style: TextStyle(
+            activity.extraData!['tweet'].toString(),
+            style: const TextStyle(
               fontSize: 24,
             ),
           ),
         ],
       ),
     );
   }
+
+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
+    properties.add(DiagnosticsProperty<Activity>('activity', activity));
+  }
 }

example/lib/add_activity_dialog.dart

@@ -1,6 +1,10 @@
 import 'package:flutter/material.dart';
 
+//ignore: public_member_api_docs
 class AddActivityDialog extends StatefulWidget {
+  //ignore: public_member_api_docs
+  const AddActivityDialog({Key? key}) : super(key: key);
+
   @override
   _AddActivityDialogState createState() => _AddActivityDialogState();
 }
@@ -9,28 +13,31 @@ class _AddActivityDialogState extends State<AddActivityDialog> {
   final _activityController = TextEditingController();
 
   @override
+  //ignore: prefer_expression_function_bodies
   Widget build(BuildContext context) {
     return Dialog(
       child: Padding(
-        padding: const EdgeInsets.all(24.0),
+        padding: const EdgeInsets.all(24),
         child: Column(
           mainAxisSize: MainAxisSize.min,
           children: [
             TextField(
               controller: _activityController,
               decoration: const InputDecoration(
                 hintText: "What's happening?",
-                border: const OutlineInputBorder(),
+                border: OutlineInputBorder(),
               ),
             ),
-            SizedBox(height: 12),
-            RaisedButton(
+            const SizedBox(height: 12),
+            ElevatedButton(
               onPressed: () {
                 final message = _activityController.text;
                 Navigator.pop<String>(context, message);
               },
-              color: Colors.blue,
-              child: Text(
+              style: ElevatedButton.styleFrom(
+                primary: Colors.blue,
+              ),
+              child: const Text(
                 'POST ACTIVITY',
                 style: TextStyle(
                   color: Colors.white,

example/lib/app_user.dart

@@ -1,26 +1,43 @@
+//ignore: public_member_api_docs
 class AppUser {
-  final String id;
-  final String name;
-  final String token;
-
+  //ignore: public_member_api_docs
   const AppUser.sahil()
       : id = 'sahil-kumar',
         name = 'Sahil Kumar',
         token =
-            'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoic2FoaWwta3VtYXIifQ.d6RW5eZedEl949w-IeZ40Ukji3yXfFnMw3baLsow028';
+            '''eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoic2FoaWwta3VtYXIifQ.d6RW5eZedEl949w-IeZ40Ukji3yXfFnMw3baLsow028''';
 
+  //ignore: public_member_api_docs
   const AppUser.sacha()
       : id = 'sacha-arbonel',
         name = 'Sacha Arbonel',
         token =
-            'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoic2FjaGEtYXJib25lbCJ9.fzDKEyiQ40J4YYgtZxpeQhn6ajX-GEnKZOOmcb-xa7M';
+            '''eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoic2FjaGEtYXJib25lbCJ9.fzDKEyiQ40J4YYgtZxpeQhn6ajX-GEnKZOOmcb-xa7M''';
 
+  //ignore: public_member_api_docs
   const AppUser.nash()
       : id = 'neevash-ramdial',
         name = 'Neevash Ramdial',
         token =
-            'eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoibmVldmFzaC1yYW1kaWFsIn0.yKqSehu_O5WJGh3-aa5qipnBRs7Qtue-1T9TZhT2ejw';
+            '''eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoibmVldmFzaC1yYW1kaWFsIn0.yKqSehu_O5WJGh3-aa5qipnBRs7Qtue-1T9TZhT2ejw'''; //ignore: public_member_api_docs
+
+  //ignore: public_member_api_docs
+  const AppUser.reuben()
+      : id = 'groovin',
+        name = 'Reuben Turner',
+        token =
+            '''eyJhbGciOiJIUzI1NiIsInR5cCI6IkpXVCJ9.eyJ1c2VyX2lkIjoiZ3Jvb3ZpbiJ9.6uMlHDLHpiHubWbcTztZO7NbFFZozuhwgNdrGgObgTE''';
+
+  //ignore: public_member_api_docs
+  final String id;
+
+  //ignore: public_member_api_docs
+  final String name;
+
+  //ignore: public_member_api_docs
+  final String token;
 
+  //ignore: public_member_api_docs
   Map<String, Object> get data {
     final parts = name.split(' ');
     return {
@@ -31,8 +48,10 @@ class AppUser {
   }
 }
 
+//ignore: public_member_api_docs
 const appUsers = [
   AppUser.sahil(),
   AppUser.sacha(),
   AppUser.nash(),
+  AppUser.reuben(),
 ];

example/lib/extension.dart

@@ -1,13 +1,16 @@
+import 'package:example/client_provider.dart';
 import 'package:flutter/material.dart';
 import 'package:stream_feed/stream_feed.dart';
 
-import 'client_provider.dart';
-
+//ignore: public_member_api_docs
 extension ProviderX on BuildContext {
+  //ignore: public_member_api_docs
   StreamFeedClient get client => ClientProvider.of(this).client;
 }
 
+//ignore: public_member_api_docs
 extension Snackbar on BuildContext {
+  //ignore: public_member_api_docs
   void showSnackBar(final String message) {
     ScaffoldMessenger.of(this).showSnackBar(SnackBar(content: Text(message)));
   }

example/lib/home.dart

@@ -1,27 +1,41 @@
 import 'package:example/people_screen.dart';
 import 'package:example/profile_screen.dart';
 import 'package:example/timeline_screen.dart';
+import 'package:flutter/foundation.dart';
 import 'package:flutter/material.dart';
 import 'package:stream_feed/stream_feed.dart';
 
+//ignore: public_member_api_docs
 class HomeScreen extends StatefulWidget {
-  final StreamUser currentUser;
+  //ignore: public_member_api_docs
+  const HomeScreen({
+    required this.currentUser,
+    Key? key,
+  }) : super(key: key);
 
-  const HomeScreen({Key? key, required this.currentUser}) : super(key: key);
+  //ignore: public_member_api_docs
+  final StreamUser currentUser;
 
   @override
   _HomeScreenState createState() => _HomeScreenState();
+
+  @override
+  void debugFillProperties(DiagnosticPropertiesBuilder properties) {
+    super.debugFillProperties(properties);
+    properties.add(DiagnosticsProperty<StreamUser>('currentUser', currentUser));
+  }
 }
 
 class _HomeScreenState extends State<HomeScreen> {
   int _currentIndex = 0;
 
   @override
+  //ignore: prefer_expression_function_bodies
   Widget build(BuildContext context) {
     return Scaffold(
       appBar: AppBar(
         title: Row(
-          children: [
+          children: const [
             Icon(Icons.bike_scooter_rounded),
             SizedBox(width: 16),
             Text('Tweet It!'),
@@ -38,14 +52,12 @@ class _HomeScreenState extends State<HomeScreen> {
       ),
       bottomNavigationBar: BottomNavigationBar(
         selectedItemColor: Colors.blue,
-        elevation: 16.0,
+        elevation: 16,
         type: BottomNavigationBarType.fixed,
         iconSize: 22,
-        selectedFontSize: 14,
-        unselectedFontSize: 12,
         currentIndex: _currentIndex,
         onTap: (index) => setState(() => _currentIndex = index),
-        items: [
+        items: const [
           BottomNavigationBarItem(
             backgroundColor: Colors.black,
             icon: Icon(Icons.timeline),