Fix missing 'template' keyword on dependent template names#114
Open
furiousdbd wants to merge 1 commit into
Open
Fix missing 'template' keyword on dependent template names#114furiousdbd wants to merge 1 commit into
furiousdbd wants to merge 1 commit into
Conversation
Calls to the dependent template member CloneExistingLayer<T>() omit the 'template' disambiguator required by [temp.names]. MSVC accepts this in its default permissive mode, so the Windows build stays green, but Clang and GCC reject it: error: missing 'template' keyword prior to dependent template name 'CloneExistingLayer' Add the keyword at the three affected call sites in the texture tools so the project also builds on conforming compilers. Co-Authored-By: Claude Opus 4.7 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
ShipBuilderLibcalls the dependent template memberModelController::CloneExistingLayer<T>()without thetemplatedisambiguator. Per[temp.names], the keyword is required when a dependent name is followed by an explicit template argument list.MSVC accepts the code in its default (permissive) mode, so the Windows build is unaffected — but Clang and GCC reject it:
This blocks the build on macOS and on Linux with a recent Clang.
Fix
Adds the
templatekeyword at the three affected call sites:Sources/ShipBuilderLib/Tools/TextureEraserTool.cpp(x2)Sources/ShipBuilderLib/Tools/TextureMagicWandTool.cpp(x1)No behavior change. Verified with a full build on macOS (Apple Silicon, Clang).