Compiling on macOS

[The-SamminAter]

Hello, I figured that it might be easier and quicker in the long run if I add compilation issues here, instead of sending them on discord.
Compilation is being done on macOS Catalina (10.15.2), with CMake 3.16.3 3.17.1 and Xcode 11.3.1 11.4.1 with the default SDK.

Errors and warnings:

FloatingSandbox Group
	Semantic Issue Group
		/Users/ffs/Downloads/Floating-Sandbox-github/FloatingSandbox/SettingsDialog.cpp:85:13: Use of undeclared identifier 'BBB_SHIP_ICON_xpm'
			/usr/local/include/wx-3.0/wx/gdicmn.h:190:31: Expanded from macro 'wxICON'
			/Users/ffs/Downloads/Floating-Sandbox-github/<scratch space>:82:1: Expanded from here
GameLib Group
	Semantic Issue Group
		/Users/ffs/Downloads/Floating-Sandbox-github/Game/ShipRenderContext.cpp:2230:26: Use of undeclared identifier 'mHighlightVertexBuffer'

I think that I also got the same googletest warnings, so here are those (these are from the last document that I sent you):

UnitTests Group
	Deprecations Group
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/GameMathTests.cpp:24:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/GameMathTests.cpp:82:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/LayoutHelperTests.cpp:60:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/LayoutHelperTests.cpp:390:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/SegmentTests.cpp:12:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/SliderCoreTests.cpp:16:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/TaskThreadPoolTests.cpp:56:1: 'InstantiateTestCase_P_IsDeprecated' is deprecated: INSTANTIATE_TEST_CASE_P is deprecated, please use INSTANTIATE_TEST_SUITE_P
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/gtest-param-test.h:504:38: Expanded from macro 'INSTANTIATE_TEST_CASE_P'
			/Users/ffs/Downloads/googletest-master/googletest/include/gtest/internal/gtest-internal.h:1236:1: 'InstantiateTestCase_P_IsDeprecated' has been explicitly marked deprecated here

[GabrieleGiuseppini]

Awesome move, Sam! It will definitely be easier!

[The-SamminAter]

Please disregard my last (now deleted) comment, I am compiling now. The errors and warnings will go where the last ones should have, in the original comment/issue

[The-SamminAter]

@GabrieleGiuseppini errors and warnings are now in the original comment/issue

[GabrieleGiuseppini]

Sam, you may try now.

[GabrieleGiuseppini]

I'm also upgrading to googletest 1.10, will get rid of the deprecation warnings soon.

[The-SamminAter]

Understood.
The issues that I received building (excluding UnitTests issues):

FloatingSandbox Group
	Semantic Issue Group
                /Users/ffs/Downloads/Floating-Sandbox-github/FloatingSandbox/StandardSystemPaths.cpp:17:50: No member named 'GetUserDir' in 'wxStandardPaths'
                /Users/ffs/Downloads/Floating-Sandbox-github/FloatingSandbox/StandardSystemPaths.cpp:17:78: No member named 'Dir' in 'wxStandardPaths'

[GabrieleGiuseppini]

The UnitTests issues are now gone, you may pull.
Regarding these new issues, which version of wxWidgets are you using? Should be at least 3.1.2...

[The-SamminAter]

I checked, I am using wxmac 3.0.4_2. I'll try to update that.
It says on wxmac's homebrew page that the latest version is 3.0.5...

[The-SamminAter]

Should I download 3.1.3's source and build it? It might not work.

[The-SamminAter]

I'm going to try to do that, if it doesn't work then I'll remove it and install homebrew's version again.

[GabrieleGiuseppini]

It would be awesome if you could try to build 3.1.2 or 3.1.3; according to this it shouldn't be a hassle: https://docs.wxwidgets.org/trunk/plat_osx_install.html. Let me know if it's a huge pain.

[The-SamminAter]

I'm running make right now, I am just not sure where my wxWidgets_ROOT_DIR should be set to after it's done.

[GabrieleGiuseppini]

I normally set it to the folder that ends up having the "include" and "lib" subfolders, but according to the Mac guide, you should try this first: "simply use the full path to wx-config under the build directory when building application using the library"

[The-SamminAter]

Here is the current issue:

UnitTests Group
	Semantic Issue Group
		/Users/ffs/Downloads/Floating-Sandbox-github/UnitTests/GameEventDispatcherTests.cpp:22:12: No matching constructor for initialization of 'StructuralMaterial'
			/Users/ffs/Downloads/Floating-Sandbox-github/Game/Materials.h:116:5: Candidate constructor not viable: requires 25 arguments, but 24 were provided
			/Users/ffs/Downloads/Floating-Sandbox-github/Game/Materials.h:17:8: Candidate constructor (the implicit copy constructor) not viable: requires 1 argument, but 24 were provided
			/Users/ffs/Downloads/Floating-Sandbox-github/Game/Materials.h:17:8: Candidate constructor (the implicit move constructor) not viable: requires 1 argument, but 24 were provided

[GabrieleGiuseppini]

Hey Sam, fixed - thanks to much!

Try again, let me know how it goes.