Skip to content

Update extension: PlaygamaBridge v1.23.0 #1716

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

lysoff
Copy link
Contributor

@lysoff lysoff commented Jun 27, 2025

  • Added Discord platform [beta]
  • Added new loading screen
  • Added backfill advertisements for MSN
  • Added built-in advertisement popups for MSN and Facebook
  • Improved leaderboards module
  • Improved Facebook integration
  • Updated currency code for Playgama.com
  • Fixed social.share for Playdeck
  • Removed Yandex deprecated methods

@lysoff lysoff requested a review from a team as a code owner June 27, 2025 09:44
@Bouh
Copy link
Contributor

Bouh commented Jun 27, 2025

Thank you for keeping the extension up to date.

Please note we added a way to inform people about breaking changes.

Once the file is exported, you can add a new key/value just above the dependencies, with the extension version number and the note about the breaking change(s) if needed.

 "changelog": [
    {
      "version": "1.23.0",
      "breaking": "- Removal of deprecated Yandex methods."
    }
  ],
  "dependencies": [],

Comment on lines +3771 to +3772
"description": "Leaderboards Type = Native.",
"fullName": "Leaderboards Type = Native",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This does not look like it is fitting our naming conventions, user visible text should use natural language and no abbreviations like the equal sign, something like The leaderboard is of type "Native" might be more fitting.

Additionally, instead of making a condition for each possible value of the variable, maybe consider a function of the type "Expression and Condition" with a "String from a list of options" return type, this would simplify things a lot, keep things flexible, and be more idiomatic.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants