Skip to content

Commit 706ee8f

Browse files
authored
#211 click close issue fix (#213)
* #211 click close issue fix * Changelog Update
1 parent 5ca4056 commit 706ee8f

File tree

3 files changed

+9
-6
lines changed

3 files changed

+9
-6
lines changed

CHANGELOG.md

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ This document follows the conventions laid out in [Keep a CHANGELOG][].
2020
### Bugfix
2121
- [#202](https://github.com/GDATASoftwareAG/robotframework-flaui/issues/202) Bad Naming changed
2222
- Argument naming in all Click Hold keywords updated from timeout_in_ms to hold_time
23+
- [#211](https://github.com/GDATASoftwareAG/robotframework-flaui/issues/211) Click Close TypoFix
24+
- the default timeout of click close changed from 1ms to 1000ms
2325
2426
## [Release][3.4.0] [3.4.0][3.3.0-3.4.0] - 2024-08-22
2527

src/FlaUILibrary/flaui/module/element.py

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,8 @@
44
from System import Exception as CSharpException # pylint: disable=import-error
55
from System import InvalidOperationException # pylint: disable=import-error
66
from FlaUI.Core import Debug as FlaUIDebug # pylint: disable=import-error
7-
from FlaUI.Core.Exceptions import PropertyNotSupportedException, ElementNotAvailableException # pylint: disable=import-error
7+
from FlaUI.Core.Exceptions import PropertyNotSupportedException # pylint: disable=import-error
8+
from FlaUI.Core.Exceptions import ElementNotAvailableException # pylint: disable=import-error
89
from FlaUILibrary.flaui.util.converter import Converter
910
from FlaUILibrary.flaui.exception import FlaUiError
1011
from FlaUILibrary.flaui.interface import (ModuleInterface, ValueContainer)

src/FlaUILibrary/keywords/mouse.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -558,7 +558,7 @@ def click_close(self, click_element_identifier: str,
558558
focus_element_identifier_before_click: str = None,
559559
focus_element_identifier_after_close: str = None,
560560
max_repeat: int = 5,
561-
timeout_between_repeates: int = 1,
561+
timeout_between_repeates: int = 1000,
562562
ignore_if_already_close: bool = True,
563563
msg=None):
564564
# pylint: disable=C0301
@@ -607,7 +607,7 @@ def double_click_close(self, click_element_identifier: str,
607607
focus_element_identifier_before_click: str = None,
608608
focus_element_identifier_after_close: str = None,
609609
max_repeat: int = 5,
610-
timeout_between_repeates: int = 1,
610+
timeout_between_repeates: int = 1000,
611611
ignore_if_already_close: bool = True,
612612
msg=None):
613613
# pylint: disable=C0301
@@ -656,7 +656,7 @@ def right_click_close(self, click_element_identifier: str,
656656
focus_element_identifier_before_click: str = None,
657657
focus_element_identifier_after_close: str = None,
658658
max_repeat: int = 5,
659-
timeout_between_repeates: int = 1,
659+
timeout_between_repeates: int = 1000,
660660
ignore_if_already_close: bool = True,
661661
msg=None):
662662
# pylint: disable=C0301
@@ -705,7 +705,7 @@ def middle_click_close(self, click_element_identifier: str,
705705
focus_element_identifier_before_click: str = None,
706706
focus_element_identifier_after_close: str = None,
707707
max_repeat: int = 5,
708-
timeout_between_repeates: int = 1,
708+
timeout_between_repeates: int = 1000,
709709
ignore_if_already_close: bool = True,
710710
msg=None):
711711
# pylint: disable=C0301
@@ -755,7 +755,7 @@ def click_hold_close(self, click_element_identifier: str,
755755
focus_element_identifier_before_click: str = None,
756756
focus_element_identifier_after_close: str = None,
757757
max_repeat: int = 5,
758-
timeout_between_repeates: int = 1,
758+
timeout_between_repeates: int = 1000,
759759
ignore_if_already_close: bool = True,
760760
msg=None):
761761
# pylint: disable=C0301

0 commit comments

Comments
 (0)