Skip to content

Commit 0758d2d

Browse files
refactor: flatten legacy modules, fix clippy, ignore Python bytecode
- Move coordinator sources from legacy/ to src/coordinator/src; embed via coordinator_body.rs; update function-stream #[path]. - Move servicer sources from legacy/; embed via servicer_body.rs; update function-stream #[path]. - Remove unused config legacy shim (src/config/src/legacy/mod.rs). - Drop empty function-stream-job-manager workspace member; refresh Cargo.lock. - CLI: collapse nested ifs in repl.rs for clippy::collapsible_if. - streaming_planner: add crate-level #![allow(dead_code)] for reserved APIs under -D warnings. - .gitignore: **/__pycache__/ and *.py[cod] so bytecode is never committed. Co-authored-by: Cursor <cursoragent@cursor.com>
1 parent d80f700 commit 0758d2d

75 files changed

Lines changed: 28 additions & 76 deletions

File tree

Some content is hidden

Large Commits have some content hidden by default. Use the searchbox below for content that may be hidden.

.gitignore

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -38,3 +38,7 @@ python/**/target/
3838
tests/integration/target/
3939
tests/integration/.venv/
4040
tests/integration/install
41+
42+
# Python bytecode (do not commit)
43+
**/__pycache__/
44+
*.py[cod]

Cargo.lock

Lines changed: 0 additions & 4 deletions
Some generated files are not rendered by default. Learn more about customizing how changed files appear on GitHub.

Cargo.toml

Lines changed: 0 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,6 @@ members = [
88
"src/common",
99
"src/config",
1010
"src/coordinator",
11-
"src/job_manager",
1211
"src/logger",
1312
"src/runtime_common",
1413
"src/servicer",

cli/cli/src/repl.rs

Lines changed: 18 additions & 18 deletions
Original file line numberDiff line numberDiff line change
@@ -158,17 +158,17 @@ impl Repl {
158158
}
159159

160160
// 3. Strict Data Check: Only proceed if data is explicitly present and non-empty
161-
if let Some(bytes) = response.data {
162-
if !bytes.is_empty() {
163-
// format_arrow_data returns Ok(Some(Table)) ONLY if row_count > 0
164-
match self.format_arrow_data(&bytes) {
165-
Ok(Some(table)) => println!("{}", table),
166-
Ok(None) => {
167-
// Data was present but contained 0 rows (e.g., empty result set)
168-
// We print nothing here to keep output clean as requested
169-
}
170-
Err(e) => eprintln!("Failed to parse result data: {}", e),
161+
if let Some(bytes) = response.data
162+
&& !bytes.is_empty()
163+
{
164+
// format_arrow_data returns Ok(Some(Table)) ONLY if row_count > 0
165+
match self.format_arrow_data(&bytes) {
166+
Ok(Some(table)) => println!("{}", table),
167+
Ok(None) => {
168+
// Data was present but contained 0 rows (e.g., empty result set)
169+
// We print nothing here to keep output clean as requested
171170
}
171+
Err(e) => eprintln!("Failed to parse result data: {}", e),
172172
}
173173
}
174174

@@ -403,10 +403,10 @@ impl Repl {
403403
println!();
404404
}
405405

406-
if !skip_save_history {
407-
if let Some(ref mut ed) = repl.lock().await.editor {
408-
let _ = ed.save_history(".function-stream-cli-history");
409-
}
406+
if !skip_save_history
407+
&& let Some(ref mut ed) = repl.lock().await.editor
408+
{
409+
let _ = ed.save_history(".function-stream-cli-history");
410410
}
411411
Ok(())
412412
}
@@ -448,10 +448,10 @@ impl Repl {
448448
}
449449

450450
fn add_history_entry(&mut self, entry: &str) {
451-
if let Some(ed) = self.editor.as_mut() {
452-
if !entry.trim().is_empty() {
453-
let _ = ed.add_history_entry(entry.trim());
454-
}
451+
if let Some(ed) = self.editor.as_mut()
452+
&& !entry.trim().is_empty()
453+
{
454+
let _ = ed.add_history_entry(entry.trim());
455455
}
456456
}
457457

src/config/src/legacy/mod.rs

Lines changed: 0 additions & 38 deletions
This file was deleted.
File renamed without changes.
File renamed without changes.

0 commit comments

Comments
 (0)