Skip to content

Commit 52b4dab

Browse files
authored
Merge pull request #96 from FlowFuse/ci-node-24-as-default-gha-runtime
feat: Use NodeJS v24 as a default version across all reusable workflows
2 parents c2fad63 + 2339189 commit 52b4dab

3 files changed

Lines changed: 11 additions & 10 deletions

File tree

.github/workflows/build_node_package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -7,7 +7,7 @@ on:
77
description: 'JSON array of Node.js versions and parameters'
88
required: false
99
type: string
10-
default: '[{"version": "20", "tests": true, "lint": true}]'
10+
default: '[{"version": "24", "tests": true, "lint": true}]'
1111

1212
jobs:
1313
build:

.github/workflows/build_node_package_with_pgsql.yml

Lines changed: 9 additions & 8 deletions
Original file line numberDiff line numberDiff line change
@@ -3,11 +3,11 @@ name: Build and test npm package with PostgreSQL service
33
on:
44
workflow_call:
55
inputs:
6-
run_tests:
7-
description: 'Run tests'
6+
node:
7+
description: 'JSON array of Node.js versions and parameters'
88
required: false
9-
type: boolean
10-
default: false
9+
type: string
10+
default: '[{"version": "24", "tests": true, "lint": true}]'
1111

1212
jobs:
1313
build:
@@ -27,22 +27,23 @@ jobs:
2727
- 5432:5432
2828
strategy:
2929
matrix:
30-
node-version: [20.x]
30+
node: ${{ fromJson(inputs.node)}}
3131
steps:
3232
- name: Checkout
3333
uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
3434

35-
- name: Use Node.js ${{ inputs.node_version }}
35+
- name: Use Node.js ${{ matrix.node.version }}
3636
uses: actions/setup-node@cdca7365b2dadb8aad0a33bc7601856ffabcc48e # v4.3.0
3737
with:
38-
node-version: ${{ inputs.node_version }}
38+
node-version: ${{ matrix.node.version }}
3939

4040
- name: Install Dependencies
4141
run: npm ci
4242

4343
- name: Run lint
44+
if: ${{ fromJson(matrix.node.lint) }}
4445
run: npm run lint
4546

4647
- name: Run tests
47-
if: ${{ fromJson(inputs.run_tests) }}
48+
if: ${{ fromJson(matrix.node.tests) }}
4849
run: npm run test

.github/workflows/publish_node_package.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -22,7 +22,7 @@ on:
2222
description: 'Node.js version'
2323
required: false
2424
type: string
25-
default: '20'
25+
default: '24'
2626
npm_registry_url:
2727
description: 'NPM registry URL'
2828
required: false

0 commit comments

Comments
 (0)