Skip to content

Commit 658efce

Browse files
committed
Revert "Revert "update events for different device id.""
This reverts commit 2a8706f.
1 parent bd92436 commit 658efce

File tree

3 files changed

+28
-8
lines changed

3 files changed

+28
-8
lines changed

fedml_api/distributed/fedavg_cross_silo/ClientMasterManager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -139,7 +139,7 @@ def finish(self):
139139
self.communication_manager.finish()
140140

141141
def send_model_to_server(self, receive_id, weights, local_sample_num):
142-
self.event_sdk.log_event_started("comm_c2s")
142+
self.event_sdk.log_event_started("comm_c2s", event_edge_id=0)
143143

144144
message = Message(MyMessage.MSG_TYPE_C2S_SEND_MODEL_TO_SERVER, self.client_real_id, receive_id)
145145
message.add_params(MyMessage.MSG_ARG_KEY_MODEL_PARAMS, weights)

fedml_api/distributed/fedavg_cross_silo/FedAvgServerManager.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -121,7 +121,7 @@ def handle_message_client_status_update(self, msg_params):
121121
self.send_init_msg()
122122

123123
def handle_message_receive_model_from_client(self, msg_params):
124-
self.event_sdk.log_event_ended("comm_c2s")
124+
self.event_sdk.log_event_ended("comm_c2s", event_edge_id=0)
125125
self.event_sdk.log_event_ended("wait")
126126

127127
sender_id = msg_params.get(MyMessage.MSG_ARG_KEY_SENDER)

fedml_api/distributed/fedavg_cross_silo/FedEventSDK.py

Lines changed: 26 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -35,16 +35,36 @@ def __init__(self, args):
3535
self.com_manager = MqttS3StatusManager(
3636
args.mqtt_config_path, args.s3_config_path, topic=args.run_id)
3737

38-
def log_event_started(self, event_name, event_value=None):
39-
event_topic, event_msg = self.__build_event_mqtt_msg(self.args.run_id, self.edge_id,
38+
def log_event_started(self, event_name, event_value=None, event_edge_id=None):
39+
if event_value is None:
40+
event_value_passed = ""
41+
else:
42+
event_value_passed = event_value
43+
44+
if event_edge_id is not None:
45+
edge_id = event_edge_id
46+
else:
47+
edge_id = self.edge_id
48+
49+
event_topic, event_msg = self.__build_event_mqtt_msg(self.args.run_id, edge_id,
4050
FedEventSDK.EVENT_TYPE_STARTED,
41-
event_name, event_value)
51+
event_name, event_value_passed)
4252
self.com_manager.send_message_json(event_topic, json.dumps(event_msg))
4353

44-
def log_event_ended(self, event_name, event_value=None):
45-
event_topic, event_msg = self.__build_event_mqtt_msg(self.args.run_id, self.edge_id,
54+
def log_event_ended(self, event_name, event_value=None, event_edge_id=None):
55+
if event_value is None:
56+
event_value_passed = ""
57+
else:
58+
event_value_passed = event_value
59+
60+
if event_edge_id is not None:
61+
edge_id = event_edge_id
62+
else:
63+
edge_id = self.edge_id
64+
65+
event_topic, event_msg = self.__build_event_mqtt_msg(self.args.run_id, edge_id,
4666
FedEventSDK.EVENT_TYPE_ENDED,
47-
event_name, event_value)
67+
event_name, event_value_passed)
4868
self.com_manager.send_message_json(event_topic, json.dumps(event_msg))
4969

5070
@staticmethod

0 commit comments

Comments
 (0)