fix: reuse persistent browser tab in Playwright profiles#37
Open
vladislav23811 wants to merge 1 commit into
Open
fix: reuse persistent browser tab in Playwright profiles#37vladislav23811 wants to merge 1 commit into
vladislav23811 wants to merge 1 commit into
Conversation
- Prefer an existing Playwright page in persistent profiles instead of always calling new_page() (fixes duplicate-tab / BrowserContext issues). - Add JARVIS_CAMERA_INDEX env for webcam selection on multi-camera systems. Refs FatihMakes/Mark-XL#31 Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
new_page().JARVIS_CAMERA_INDEXenvironment variable for webcam selection on multi-camera systems.Motivation
Addresses duplicate-tab /
BrowserContext.new_pageissues with persistent Playwright profiles (#31) and camera index selection (#20).Test plan
JARVIS_CAMERA_INDEX=1and confirm webcam on multi-camera PCs