"NPC turns into a container"

[FakelsHub]

Do I understand correctly that this bug occurred when the DAM_LOSE_TURN flag was not reset ?

If so, then the purpose of hacking the critter_wake_clear_ function is not entirely clear
https://github.com/FakelsHub/sFall-Extended/blob/765a593f91c397a95aadae86552a63d5f1510af8/sfall/Modules/BugFixes.cpp#L1057
He does an excellent job of "stand up" the critters when exiting the map.

[NovaRain]

Here's Crafty's old post about this:
https://www.nma-fallout.com/threads/fo2-engine-tweaks-sfall.178390/page-123#post-4065690

I'm not entirely sure what's the root cause of the bug, but leaving the map when party members are in "lost his turn" in combat did trigger the bug in the past.

[FakelsHub]

I'm just trying to sort out the critter_wake_clear_hack and DAM_KNOCKED_OUT bug fixes again
I remember that we have already talked about this topic, and this communication is somewhere lost in the comits.

[NovaRain]

I'm just trying to sort out the critter_wake_clear_hack and DAM_KNOCKED_OUT bug fixes again
I remember that we have already talked about this topic, and this communication is somewhere lost in the comits.

Is that about the order of proc execution? Probably around the commits during 4.1.9.
Maybe the whole bug/fix need some reviews?

[FakelsHub]

about the flag, now I have questions about this flag check
https://github.com/FakelsHub/sFall-Extended/blob/765a593f91c397a95aadae86552a63d5f1510af8/sfall/Modules/BugFixes.cpp#L1090

This check was not included in the original fix.

[NovaRain]

about the flag, now I have questions about this flag check

https://github.com/FakelsHub/sFall-Extended/blob/765a593f91c397a95aadae86552a63d5f1510af8/sfall/Modules/BugFixes.cpp#L1090

This check was not included in the original fix.

You added it in commit 6336d68.

[FakelsHub]

it remains for me to remember for what occasion I put it there, now I have no idea what it is there for, maybe it's my mistake.
too bad I didn't put a comment there.