Nested (check)lists?

[daturkel]

Hi, thanks for the great extension!

I was wondering if support could be added for nested checklists:

- [x] top
- [x] level
- [ ] items
  - [ ] second level
    - [ ] third level

would become

<ul class="checklist">
<li><input type="checkbox" disabled checked>top</li>
<li><input type="checkbox" disabled checked>level</li>
<li><input type="checkbox" disabled>items
  <ul class="checklist">
    <li><input type="checkbox" disabled>second level
      <ul class="checklist">
        <li><input type="checkbox" disabled>third level</li>
      </ul>
    </li>
  </ul>
</li>
</ul>

It's currently implemented in Github markdown:

• first level
  • second level

How difficult would something like this be to add? Or maybe it already works and I just am getting the syntax wrong?

Thanks again!

[FND]

Hey, thanks for your interest.

I'm not currently using this extension myself, but I believe @radude's mdx_truly_sane_lists could solve this issue for you - see details in #7 (comment). Hope that helps.

[daturkel]

Thanks for such a quick response! I tried out radude's extension and unfortunately the example in #7 no longer worked. I used git bisect to track down the breaking commit: 41a2418

Unsurprisingly, it was a fairly large change. I think the issue is that the old version managed to work recursively while the current version does not (since it runs the ul rule once and then the li rule once).

I need to think a little more about a good workaround, though maybe you have ideas.

[FND]

I'm afraid I'm not much help there: I haven't really worked with or on this extension in ages.

[Erik-J-D]

I just wrote my own checkbox thing here that works fine with nested lists, I could port it over if you're open to a PR.

[thomashope]

I was able to get this working locally by removing </li> from the end of the regex in markdown_checklist/extension.py. The issue is the opening <ul> is placed on the same line as the opening <li> when generating the html for tested lists.

I tried adding tests to make a PR but I think I was running into issues because this plugin hasn't been updated in a long time and I'm not familiar with python enough to work through them. If a python developer has time it probably isn't that hard though.

Here's the patch.

diff --git a/markdown_checklist/extension.py b/markdown_checklist/extension.py
index 33b53a3..a0ceea6 100644
--- a/markdown_checklist/extension.py
+++ b/markdown_checklist/extension.py
@@ -35,7 +35,7 @@ class ChecklistPostprocessor(Postprocessor):
     """
 
     list_pattern = re.compile(r'(<ul>\n<li>\[[ Xx]\])')
-    item_pattern = re.compile(r'^<li>\[([ Xx])\](.*)</li>$', re.MULTILINE)
+    item_pattern = re.compile(r'^<li>\[([ Xx])\](.*)$', re.MULTILINE)
 
     def __init__(self, list_class, render_item, *args, **kwargs):
         self.list_class = list_class