Skip to content

Commit 9e08f26

Browse files
committed
fix(ui-predicate-vue3): correct typo in dispatched event name
1 parent 29ec70a commit 9e08f26

File tree

5 files changed

+25
-11
lines changed

5 files changed

+25
-11
lines changed

packages/ui-predicate-vue3/getting-started/simple.vue

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@
44
<ui-predicate
55
v-model="predicate"
66
:columns="columns"
7-
@change="onChange"
7+
@changed="onChange"
88
@initialized="onInitialized"
99
/>
1010
</div>

packages/ui-predicate-vue3/src/default-components/predicate-add.vue

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,9 @@ defineProps({
88
type: Boolean,
99
default: false,
1010
},
11+
predicate: {
12+
type: Object,
13+
required: true,
14+
},
1115
})
1216
</script>

packages/ui-predicate-vue3/src/default-components/predicate-remove.vue

Lines changed: 3 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -8,5 +8,8 @@ defineProps({
88
type: Boolean,
99
default: false,
1010
},
11+
predicate: {
12+
type: Object,
13+
},
1114
});
1215
</script>

packages/ui-predicate-vue3/src/ui-predicate.stories.js

Lines changed: 7 additions & 7 deletions
Original file line numberDiff line numberDiff line change
@@ -46,10 +46,10 @@ export const Events = {
4646
setup() {
4747
return { ...args };
4848
},
49-
template: '<ui-predicate :columns="columns" v-model="data" @change="onChange" @initialized="onInit"></ui-predicate>',
49+
template: '<ui-predicate :columns="columns" v-model="data" @changed="onChange" @initialized="onInit"></ui-predicate>',
5050
}),
5151
args: {
52-
onChange: action('`change` event'),
52+
onChanged: action('`changed` event'),
5353
onInit: action('`initialized` event'),
5454
},
5555
};
@@ -84,7 +84,7 @@ export const CustomizeDefaultUIComponents = {
8484
:columns="columns"
8585
v-model="data"
8686
:ui="ui"
87-
@change="onChange"
87+
@changed="onChange"
8888
@initialized="onInit"/>`,
8989
}),
9090
args: {
@@ -111,7 +111,7 @@ export const CustomizeDefaultUIComponents = {
111111
>
112112
<datalist
113113
id="targets-datalist"
114-
@change="$emit('change', $event.target.value)">
114+
@changed="$emit('changed', $event.target.value)">
115115
<option
116116
v-for="target in columns.targets"
117117
:key="target.target_id"
@@ -122,7 +122,7 @@ export const CustomizeDefaultUIComponents = {
122122
`,
123123
},
124124
},
125-
onChange: action('`change` event'),
125+
onChanged: action('`changed` event'),
126126
onInit: action('`initialized` event'),
127127
},
128128
};
@@ -154,11 +154,11 @@ export const CustomizeCSS = {
154154
class="custom-css"
155155
:columns="columns"
156156
v-model="data"
157-
@change="onChange"
157+
@changed="onChange"
158158
@initialized="onInit"/>`,
159159
}),
160160
args: {
161-
onChange: action('`change` event'),
161+
onChanged: action('`changed` event'),
162162
onInit: action('`initialized` event'),
163163
},
164164
};

packages/ui-predicate-vue3/src/ui-predicate.vue

Lines changed: 10 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -34,7 +34,13 @@ const props = defineProps({
3434
},
3535
});
3636
37-
const emit = defineEmits(['change', 'initialized', 'error', 'isInAddCompoundMode']);
37+
const emit = defineEmits([
38+
'error',
39+
'changed',
40+
'initialized',
41+
'isInAddCompoundMode',
42+
'update:model-value'
43+
]);
3844
3945
// Reactive state
4046
const isCoreReady = ref(false);
@@ -94,7 +100,7 @@ const triggerChanged = () => {
94100
* @event change
95101
* @type {Object}
96102
*/
97-
emit("change", jsonValue);
103+
emit("changed", jsonValue);
98104
model.value = jsonValue;
99105
100106
// A small hack (for now) to handle reactivity (since ui-predicate-core doesn't handle js Proxies for now)
@@ -127,7 +133,7 @@ onMounted(() => {
127133
});
128134
129135
onBeforeUnmount(() => {
130-
if (ctrl) {
136+
if (ctrl.value) {
131137
ctrl.value.off();
132138
}
133139
window.removeEventListener('keyup', onAltReleased);
@@ -140,6 +146,7 @@ onBeforeUnmount(() => {
140146
display: flex;
141147
}
142148
.ui-predicate__row {
149+
display: flex;
143150
flex-direction: row;
144151
}
145152
.ui-predicate__col {

0 commit comments

Comments
 (0)