-
-
Notifications
You must be signed in to change notification settings - Fork 37
Description
Since we already moved the js files to dist, next up would be images and css.
Why?
-
the entry is used on the root path 'public->""' here, so every file not found will create a request and will trigger the 404 handler and we can't configure with fallthrough
this is problematic if we deliver html for a jpeg and loads of wasted cpu cycles.
example favicon.png, index.js.map etc. are common requests that a browser does without telling them todo so. -
making all the scss publicly available is nothing too risky, since we are opensource, but also not clean
3.when everything is in dist, it is also clearer what will be delivered, and what is private.
PS: the images used are mostly not optimized for web, big sizes with poor compression, we could auto optimize them on docker-build, or use a one-time conversion to reduce some of the size without too much complexity as if we use a cdn.