extract DatePeriod date as time

Author: gqcorneby

src/domain/entities/DatePeriod.ts

@@ -41,22 +41,18 @@ export class DatePeriod extends Struct<DatePeriodAttrs>() {
             return [];
         }
 
-        const allStartTimes = _(periods)
-            .compactMap(p => stringToTime(p.startDate))
-            .value();
-        const allEndTime = _(periods)
-            .compactMap(p => stringToTime(p.endDate))
-            .value();
+        const allStartTimes = this.extractPeriodDateAsTimes("startDate");
+        const allEndTimes = this.extractPeriodDateAsTimes("endDate");
 
-        if (!allStartTimes.length || !allEndTime.length) {
+        if (!allStartTimes.length || !allEndTimes.length) {
             return [];
         }
 
         const startDate = new Date(startDateStr);
         const endDate = new Date(endDateStr);
 
         const openingDate = new Date(Math.min(...allStartTimes, startDate.getTime()));
-        const closingDate = new Date(Math.max(...allEndTime, endDate.getTime()));
+        const closingDate = new Date(Math.max(...allEndTimes, endDate.getTime()));
 
         const startYear = startDate.getFullYear();
         const startMonth = startDate.getMonth();
@@ -78,6 +74,12 @@ export class DatePeriod extends Struct<DatePeriodAttrs>() {
             .value();
     }
 
+    private extractPeriodDateAsTimes<K extends "startDate" | "endDate">(field: K) {
+        return _(this.periods)
+            .compactMap(p => stringToTime(p[field]))
+            .value();
+    }
+
     generatePeriods(config: DataPeriodConfig): DatePeriod["periods"] {
         const { startDate, endDate, periods, years } = this;