Scope operational errors

Author: kronicker

lib/arbiquelize/index.js

@@ -2,7 +2,6 @@
 
 const Arbiter = require('./arbiter');
 const difference = require('lodash/difference');
-const errors = require('../errors');
 const filter = require('lodash/filter');
 const flatMap = require('lodash/flatMap');
 const { format } = require('util');
@@ -16,6 +15,7 @@ const pick = require('lodash/pick');
 const Promise = require('bluebird');
 const reduce = require('lodash/reduce');
 const sortBy = require('lodash/sortBy');
+const { SfPersistanceError } = require('../errors');
 const Sqlize = require('../sqlize');
 
 const { Sequelize } = Sqlize;
@@ -25,7 +25,6 @@ const isModel = Ctor => Ctor && Ctor.prototype instanceof Arbiquelize.Model;
 const isProduction = process.env.NODE_ENV === 'production';
 
 const { DataTypes } = Sequelize;
-const { SfPersistanceError } = errors;
 const { validate } = DataTypes.STRING.prototype;
 DataTypes.STRING.prototype.validate = function (value, options) {
   let isValid = validate.call(this, value, options);

lib/errors/index.js

@@ -1,7 +1,8 @@
 'use strict';
 
-exports.ErrorManager = require('./error-manager');
-
-exports.SfPersistanceError = require('./sf-persistance-error');
-exports.SyncModulePullError = require('./sync-module-pull-error');
-exports.Validation = require('./validation');
+module.exports = {
+  ErrorManager: require('./error-manager'),
+  SyncError: require('./error-manager'),
+  ...require('./validation'),
+  ...require('./operational')
+};

lib/errors/operational/index.js

@@ -0,0 +1,5 @@
+'use strict';
+
+exports.OperationalError = require('./operational-error');
+exports.SfPersistanceError = require('./sf-persistance-error');
+exports.SyncModulePullError = require('./sync-module-pull-error');

lib/errors/operational/operational-error.js

@@ -0,0 +1,5 @@
+'use strict';
+
+const SyncError = require('../sync-error');
+
+module.exports = class OperationalError extends SyncError {};

lib/errors/sf-persistance-error.js renamed to lib/errors/operational/sf-persistance-error.js

@@ -2,14 +2,14 @@
 
 const find = require('lodash/find');
 const matchAll = require('match-all');
+const OperationalError = require('./operational-error');
 
-class SfPersistanceError {
+class SfPersistanceError extends OperationalError {
   constructor(original, Model, entries) {
-    this.name = 'SfPersistanceError';
+    super(`Unable to persist fetched ${Model.name} salesforce entries`);
     this.original = original;
     this.Model = Model;
     this.entries = entries;
-    this.message = `Unable to persist fetched ${Model.name} salesforce entries`;
 
     if (!this[original.name]) throw original;
     this.failingField = this[original.name]();

lib/errors/operational/sync-module-pull-error.js

@@ -0,0 +1,13 @@
+'use strict';
+
+const OperationalError = require('./operational-error');
+
+class SyncModulePullError extends OperationalError {
+  constructor(original, SyncModule) {
+    super(`Error pulling ${SyncModule.Model.name} salesforce records`);
+    this.original = original;
+    this.SyncModule = SyncModule;
+  }
+}
+
+module.exports = SyncModulePullError;

lib/errors/sync-module-pull-error.js

@@ -1,6 +1,6 @@
 'use strict';
 
-const errors = require('../errors/validation');
+const errors = require('../errors');
 const filter = require('lodash/filter');
 const map = require('lodash/map');
 const Promise = require('bluebird');

lib/sync/sync-module-validator.js

@@ -1,15 +1,13 @@
 'use strict';
 
-const errors = require('../errors');
+const { ErrorManager, SfPersistanceError, SyncModulePullError } = require('../errors');
 const filter = require('lodash/filter');
 const Loader = require('../utils/loader');
 const once = require('lodash/once');
 const partition = require('lodash/partition');
 const Promise = require('bluebird');
 const SyncModuleValidator = require('./sync-module-validator');
 
-const { ErrorManager, SfPersistanceError, SyncModulePullError } = errors;
-
 class SyncModule {
   constructor({ Model, sync }) {
     this.Model = Model;