Skip to content

[No QA] Docs updates for E/A#92128 add Create and Use Custom Agents article#93610

Merged
VictoriaExpensify merged 7 commits into
mainfrom
claude-custom-agents-help-article
Jun 17, 2026
Merged

[No QA] Docs updates for E/A#92128 add Create and Use Custom Agents article#93610
VictoriaExpensify merged 7 commits into
mainfrom
claude-custom-agents-help-article

Conversation

@MelvinBot

@MelvinBot MelvinBot commented Jun 15, 2026

Copy link
Copy Markdown
Contributor

Explanation of Change

While reviewing #92128, I found that the Agents settings page (Account > Agents) now renders a Learn more link in its subtitle and empty state. That link points to CONST.CUSTOM_AGENTS_HELP_URL:

https://help.expensify.com/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents

No article exists at that path. The PR added two Agent Rules articles (Create-Agent-Rules.md, How-to-Write-Agent-Rules.md — a separate, workspace-level RuleBot feature) and two unreferenced images (ExpensiHelp-CustomAgents-1.png, ExpensiHelp-CustomAgents-2.png), but never created the Custom Agents article the product links to. As a result, the in-product Learn more link 404s.

This PR adds the missing article so the link resolves:

  • New article: docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md — explains what Custom Agents are and how to create one, write instructions, chat with an agent, Copilot into an agent's account, edit, and delete. It also reuses the orphaned ExpensiHelp-CustomAgents-1.png asset.

Scope notes

  • All UI labels were verified against the live source: nav path Account > Agents (Beta badge), New agent, Agent name, Write custom instructions, Create agent, Edit, Copilot, Chat with agent, Copilot into account, Delete agent.
  • ExpensiHelp-CustomAgents-2.png shows a Custom Agent set as a workflow approver via an Add agent button. That label does not exist in the current source (only Add approver does), so the approver flow appears to be an unreleased/design state. I intentionally did not document it, to keep the article aligned with shipped behavior. It can be added in a follow-up once the approver flow ships.

Fixed Issues

$ https://github.com/Expensify/Expensify/issues/643049

Tests/QA

  • None
Click to expand

Explanation of Change

Fixed Issues

$
PROPOSAL:

Tests

  • Verify that no errors appear in the JS console

Offline tests

N/A

QA Steps

Same as tests.

  • Verify that no errors appear in the JS console

PR Author Checklist

  • I linked the correct issue in the ### Fixed Issues section above
  • I wrote clear testing steps that cover the changes made in this PR
    • I added steps for local testing in the Tests section
    • I added steps for the expected offline behavior in the Offline steps section
    • I added steps for Staging and/or Production testing in the QA steps section
    • I added steps to cover failure scenarios (i.e. verify an input displays the correct error message if the entered data is not correct)
    • I turned off my network connection and tested it while offline to ensure it matches the expected behavior (i.e. verify the default avatar icon is displayed if app is offline)
    • I tested this PR with a High Traffic account against the staging or production API to ensure there are no regressions (e.g. long loading states that impact usability).
  • I included screenshots or videos for tests on all platforms
  • I ran the tests on all platforms & verified they passed on:
    • Android: Native
    • Android: mWeb Chrome
    • iOS: Native
    • iOS: mWeb Safari
    • MacOS: Chrome / Safari
  • I verified there are no console errors (if there's a console error not related to the PR, report it or open an issue for it to be fixed)
  • I followed proper code patterns (see Reviewing the code)
    • I verified that any callback methods that were added or modified are named for what the method does and never what callback they handle (i.e. toggleReport and not onIconClick)
    • I verified that comments were added to code that is not self explanatory
    • I verified that any new or modified comments were clear, correct English, and explained "why" the code was doing something instead of only explaining "what" the code was doing.
    • I verified any copy / text shown in the product is localized by adding it to src/languages/* files and using the translation method
      • If any non-english text was added/modified, I used JaimeGPT to get English > Spanish translation. I then posted it in #expensify-open-source and it was approved by an internal Expensify engineer. Link to Slack message:
    • I verified all numbers, amounts, dates and phone numbers shown in the product are using the localization methods
    • I verified any copy / text that was added to the app is grammatically correct in English. It adheres to proper capitalization guidelines (note: only the first word of header/labels should be capitalized), and is either coming verbatim from figma or has been approved by marketing (in order to get marketing approval, ask the Bug Zero team member to add the Waiting for copy label to the issue)
    • I verified proper file naming conventions were followed for any new files or renamed files. All non-platform specific files are named after what they export and are not named "index.js". All platform-specific files are named for the platform the code supports as outlined in the README.
    • I verified the JSDocs style guidelines (in STYLE.md) were followed
  • If a new code pattern is added I verified it was agreed to be used by multiple Expensify engineers
  • I followed the guidelines as stated in the Review Guidelines
  • I tested other components that can be impacted by my changes (i.e. if the PR modifies a shared library or component like Avatar, I verified the components using Avatar are working as expected)
  • I verified all code is DRY (the PR doesn't include any logic written more than once, with the exception of tests)
  • I verified any variables that can be defined as constants (ie. in CONST.ts or at the top of the file that uses the constant) are defined as such
  • I verified that if a function's arguments changed that all usages have also been updated correctly
  • If any new file was added I verified that:
    • The file has a description of what it does and/or why is needed at the top of the file if the code is not self explanatory
  • If a new CSS style is added I verified that:
    • A similar style doesn't already exist
    • The style can't be created with an existing StyleUtils function (i.e. StyleUtils.getBackgroundAndBorderStyle(theme.componentBG))
  • If new assets were added or existing ones were modified, I verified that:
    • The assets are optimized and compressed (for SVG files, run npm run compress-svg)
    • The assets load correctly across all supported platforms.
  • If the PR modifies code that runs when editing or sending messages, I tested and verified there is no unexpected behavior for all supported markdown - URLs, single line code, code blocks, quotes, headings, bold, strikethrough, and italic.
  • If the PR modifies a generic component, I tested and verified that those changes do not break usages of that component in the rest of the App (i.e. if a shared library or component like Avatar is modified, I verified that Avatar is working as expected in all cases)
  • If the PR modifies a component related to any of the existing Storybook stories, I tested and verified all stories for that component are still working as expected.
  • If the PR modifies a component or page that can be accessed by a direct deeplink, I verified that the code functions as expected when the deeplink is used - from a logged in and logged out account.
  • If the PR modifies the UI (e.g. new buttons, new UI components, changing the padding/spacing/sizing, moving components, etc) or modifies the form input styles:
    • I verified that all the inputs inside a form are aligned with each other.
    • I added Design label and/or tagged @Expensify/design so the design team can review the changes.
  • If a new page is added, I verified it's using the ScrollView component to make it scrollable when more elements are added to the page.
  • I added unit tests for any new feature or bug fix in this PR to help automatically prevent regressions in this user flow.
  • If the main branch was merged into this PR after a review, I tested again and verified the outcome was still expected according to the Test steps.

Screenshots/Videos

The Agents settings page links Learn more to
ai-agents/Create-and-Use-Custom-Agents, but that article did not exist.
Add it so the in-product link resolves, using the orphaned
ExpensiHelp-CustomAgents-1.png asset.

Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
@MelvinBot MelvinBot requested a review from a team June 15, 2026 18:19
@MelvinBot MelvinBot added the HelpDot Apply this label if the issue relates to ExpensifyHelp label Jun 15, 2026
@github-actions github-actions Bot changed the title Docs updates for E/A#92128 add Create and Use Custom Agents article [No QA] Docs updates for E/A#92128 add Create and Use Custom Agents article Jun 15, 2026
@OSBotify

This comment has been minimized.

@yuwenmemon yuwenmemon marked this pull request as ready for review June 15, 2026 18:34
@melvin-bot

melvin-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

Concierge reviewer checklist:

  • I have verified the accuracy of the article
    • The article is within a hub that makes sense, and the navigation is correct
    • All processes, screenshots, and examples align with current product behavior.
    • All links within the doc have been verified for correct destination and functionality.
  • I have verified the readability of the article
    • The article's language is clear, concise, and free of jargon.
    • The grammar, spelling, and punctuation are correct.
    • The article contains at least one image, or that an image is not necessary
  • I have verified the formatting of the article
    • The article has consistent formatting (headings, bullet points, etc.) with other HelpDot articles and that aligns with the HelpDot formatting standards.
    • The article has proper text spacing and breaks for readability.
  • I have verified the article has the appropriate tone and style
    • The article's tone is professional, friendly, and suitable for the target audience.
    • The article's tone, terminology, and voice are consistent throughout.
  • I have verified the overall quality of the article
    • The article is not missing any information, nor does it contain redundant information.
    • The article fully addresses user needs.
  • I have verified that all requested improvements have been addressed

For more detailed instructions on completing this checklist, see How do I review a HelpDot PR as a Concierge Team member?

cc @bfitzexpensify

@melvin-bot melvin-bot Bot requested review from bfitzexpensify and removed request for a team June 15, 2026 18:34
@melvin-bot

melvin-bot Bot commented Jun 15, 2026

Copy link
Copy Markdown

@bfitzexpensify Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

Comment thread docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md Outdated
Comment thread docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md Outdated
Comment thread docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md Outdated
@github-actions

Copy link
Copy Markdown
Contributor

HelpDot Documentation Review

Overall Assessment

This PR adds a new article for Custom Agents, a Beta feature in New Expensify. The article is well-structured, follows the single-workflow principle, and covers creating, chatting with, editing, and deleting Custom Agents. It closely adheres to governance standards with only minor deviations.

Scores Summary

  • Readability: 9/10 - Steps are clear, concise, and action-oriented. The intro paragraph effectively communicates value. Instruction examples for agent behavior are a nice touch.
  • AI Readiness: 9/10 - YAML metadata is complete and well-crafted. The internalScope field clearly defines audience and exclusions. Multiple task-based "How to" headings with the feature name support strong retrieval.
  • Style Compliance: 8/10 - UI elements are properly bolded, headings are task-based, and cross-links follow formatting rules. One recurring navigation phrasing issue lowers this score (see below).

Key Findings

Positive aspects:

  • YAML frontmatter is thorough: title, description, keywords, and internalScope all present and well-written.
  • Heading hierarchy is correct: one # title, all sections use ##, and # FAQ at the end.
  • All headings are task-based with action verbs or question words.
  • Cross-links use relative paths, descriptive anchor text, and are placed outside of numbered steps.
  • Screenshot placeholder uses the correct HTML comment format.
  • FAQ questions are user-oriented and use the feature name.

Issues to address:

  1. Navigation phrasing mismatch (recurring, 5 occurrences): The article uses "In the navigation tabs (on the left on web, and at the bottom on mobile)" but the governance standard in HELPSITE_NAMING_CONVENTIONS.md specifies "In the navigation tabs (on the left on web, on the bottom on mobile)" -- no "and", and "on the bottom" not "at the bottom". This appears in every procedural section.

  2. Cross-link anchor text: The two internal cross-links use bare text like "how to edit a Custom Agent" and "how to delete a Custom Agent". Per governance, descriptive formats such as "Learn how to [task]" or "See [task description]" are preferred. The current "See [how to delete...]" pattern is acceptable but could be slightly more explicit.

Recommendations

  1. Fix navigation phrasing in all five occurrences: change "and at the bottom on mobile" to "on the bottom on mobile" (remove "and", change "at" to "on") to match the exact governance-specified format.
  2. Consider whether the image path ExpensiHelp-CustomAgents-1.png asset exists or will be added -- the screenshot placeholder comment is present, but the actual image tag references a specific file.

Files Reviewed

  • docs/articles/new-expensify/ai-agents/Create-and-Use-Custom-Agents.md -- New file. Strong overall compliance with minor navigation phrasing fix needed.

This review is based solely on the proposed changes in the PR diff, scored against the governance files: HELPSITE_NAMING_CONVENTIONS.md, HELP_AUTHORING_GUIDELINES.md, and TEMPLATE.md.

@yuwenmemon

Copy link
Copy Markdown
Contributor

@MelvinBot apply the fixes from review

Co-authored-by: Yuwen Memon <yuwenmemon@users.noreply.github.com>
@OSBotify

This comment has been minimized.

@yuwenmemon

Copy link
Copy Markdown
Contributor

@bfitzexpensify bump!

@OSBotify

This comment has been minimized.

@stephanieelliott stephanieelliott requested a review from a team as a code owner June 17, 2026 01:13
@melvin-bot melvin-bot Bot requested review from Ollyws and removed request for a team June 17, 2026 01:13
@melvin-bot

melvin-bot Bot commented Jun 17, 2026

Copy link
Copy Markdown

@Ollyws Please copy/paste the Reviewer Checklist from here into a new comment on this PR and complete it. If you have the K2 extension, you can simply click: [this button]

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@OSBotify

This comment has been minimized.

@stephanieelliott

stephanieelliott commented Jun 17, 2026

Copy link
Copy Markdown
Contributor

We had deleted the Custom Agents article in favor of the Agent Rules article, but I it seems like we'll have both? I replaced this draft with the original one, since some of the UI steps were wrong and the one had screenshots. Also updated all 3 articles to cross-link with one another!

@OSBotify

Copy link
Copy Markdown
Contributor

A preview of your ExpensifyHelp changes have been deployed to https://098f032b.helpdot.pages.dev ⚡️

Updated articles:

@stephanieelliott stephanieelliott requested review from VictoriaExpensify and removed request for Ollyws and bfitzexpensify June 17, 2026 01:22
@VictoriaExpensify

Copy link
Copy Markdown
Contributor

Hmm this formatting is not right. I don't think it's from a change you've made here but we should fix it:

2026-06-17_11-25-18

@VictoriaExpensify

Copy link
Copy Markdown
Contributor

NM - I was looking at the live helpsite and not dev. Everything looks good

@VictoriaExpensify VictoriaExpensify merged commit 0e8a142 into main Jun 17, 2026
14 of 18 checks passed
@VictoriaExpensify VictoriaExpensify deleted the claude-custom-agents-help-article branch June 17, 2026 01:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

HelpDot Apply this label if the issue relates to ExpensifyHelp

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants