Skip to content

[BT-139] Migrate Workspace - Tags (Part 3) #83861

@mjasikowski

Description

@mjasikowski

Description

Current State:

  • 5 routes for workspace tag list and settings tags
  • These routes use backTo parameter for return navigation

Implementation:

  • Replace getRoute(..., backTo) with createDynamicRoute()
  • Add source screens to entryScreens array
  • Remove backTo parameter from route definitions
  • Test forward/back navigation

Scope

Routes (5):

Route Constant Path
WORKSPACE_TAG_LIST_VIEW workspaces/:policyID/tag-list/:orderWeight
WORKSPACE_TAGS_IMPORT workspaces/:policyID/tags/import
WORKSPACE_TAGS_IMPORTED workspaces/:policyID/tags/imported
SETTINGS_TAGS_ROOT settings/:policyID/tags
SETTINGS_TAGS_SETTINGS settings/:policyID/tags/settings

Usages

WORKSPACE_TAG_LIST_VIEW:

  • src/pages/workspace/tags/WorkspaceViewTagsPage.tsx

WORKSPACE_TAGS_IMPORT:

  • src/pages/workspace/tags/ImportTagsOptionsPage.tsx:83

WORKSPACE_TAGS_IMPORTED:

  • Search for usages in imported tags flow

SETTINGS_TAGS_ROOT:

  • src/pages/workspace/tags/ImportTagsOptionsPage.tsx:83,210,248,268
  • src/pages/iou/request/step/IOURequestStepTag.tsx:188
  • src/pages/workspace/tags/WorkspaceViewTagsPage.tsx:113,353
  • src/pages/workspace/tags/ImportedTagsPage.tsx:132

SETTINGS_TAGS_SETTINGS:

  • Search for usages in settings tags settings flow

Files to modify:

  • src/ROUTES.ts - Update route definitions
  • src/libs/Navigation/types.ts - Remove backTo from params
  • Components listed above

Migration Progress

  • WORKSPACE_TAG_LIST_VIEW
  • WORKSPACE_TAGS_IMPORT
  • WORKSPACE_TAGS_IMPORTED
  • SETTINGS_TAGS_ROOT
  • SETTINGS_TAGS_SETTINGS
Issue OwnerCurrent Issue Owner: @huult

Metadata

Metadata

Labels

InternalRequires API changes or must be handled by Expensify staffNot a priorityWeeklyKSv2

Type

No type
No fields configured for issues without a type.

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions